LPS-121903 Migrate v2 usages in roles/roles-admin-web by julien · Pull Request #835 · liferay-frontend/liferay-portal

julien · 2021-02-24T16:44:44Z

The <clay:management-toolbar-v2 /> tag has been replaced with the
<clay:management-toolbar /> tag (which uses clay v3).

Creating and deleting roles should work as expected, as well as adding or
removing assignees from these roles.

Test plan (1):

From the global menu, select the Control Panel tab
Navigate to Roles
Make sure you can:
- Create and delete Regular Roles
- Create and delete Site Roles
- Create and delete Organization Roles
- Create and delete Asset Library Roles
- Create and delete Account Roles

Test Plan (2):

Create a Regular Role
Select (click) the Regular Role you created previously
Navigate to the Assignees tab
Make sure you can add assignees from this role
Make sure you can remove assignees from this role

Additional notes

Submitting this as a draft before forwarding to @drewbrokke so that @ambrinchaudhary , @john-co and @markocikos can review
This module had an <aui:script> that was defining one of the management toolbar's event handler, and at the same time calling that handler depending on values present in session storage. Since this might be hard to understand, this is what I'm referring to.
In this change, what I've done is replaced that by using a "propsTransformer" for the management toolbar, another JS module that defines the addAssignees function and a <liferay-frontend:component> to check session storage and conditionally call the addAssignees function.

I think this is OK and I've actually mentioned it to @drewbrokke to make sure, but I'm adding this here so that everyone following this pull request thread knows why this change was made.

liferay-continuous-integration · 2021-02-24T16:44:48Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-02-24T16:48:08Z

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c

Sender Branch:

Branch Name: LPS-121903
Branch GIT ID: 90f89fef729a68c2bf57afa9a358999f794d52e7

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:290)
[stopwatch] [run.batch.test.action: 1:09.830 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1
      [get] Getting: http://test-1-17/job/test-portal-source-format/4747//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210224084756345.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210224084756345.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null422311912.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null385030468

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 204ms

[junitreport] Deleting: /tmp/null385030468

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 02-24-2021 08:48:01:249 PST

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[echo]

[echo] Ant GC log:

[echo]

[echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)

[echo] Memory: 4k page, physical 32902020k(5202252k free), swap 0k(0k free)

julien · 2021-02-24T16:50:36Z

Oops

julien · 2021-02-24T16:50:42Z

ci:test:sf

liferay-continuous-integration · 2021-02-24T16:55:34Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c

Sender Branch:

Branch Name: LPS-121903
Branch GIT ID: 3f4739d3177df9a0e28a949ff1312d7c88459374

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-02-24T17:13:44Z

Jenkins Build:test-portal-source-format#5041
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-02-24[08:51:16]
Spira Jenkins Build:publish-spira-report#16472

julien · 2021-02-24T17:37:40Z

ci:test:relevant

liferay-continuous-integration · 2021-02-24T17:59:12Z

Jenkins Build:test-portal-source-format#4747
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-02-24[08:45:26]
Spira Jenkins Build:publish-spira-report#13574

liferay-continuous-integration · 2021-02-24T18:21:56Z

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 hours 47 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c

Upstream Comparison:

Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09
Jenkins Build URL: Acceptance Upstream DXP (master) #1575

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)
Job Results:
0 Jobs Passed.
1 Job Failed.
The sender branch SHA could not be found on julien/LPS-121903. The sender branch may have been force pushed or deleted after the pull request test was initiated.
```
fatal: Not a valid branch point: '90f89fef729a68c2bf57afa9a358999f794d52e7'.
```

For upstream results, click here.

liferay-continuous-integration · 2021-02-24T21:17:16Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 2 hours 24 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c

Upstream Comparison:

Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c
Jenkins Build URL: Acceptance Upstream DXP (master) #1576

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 22 out of 24 jobs PASSED

2 Failed Jobs:

22 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 8b8f62f:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #463483

Please fix semantic versioning on julien/LPS-121903

     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/roles/roles-item-selector-web/build/jspc/org/apache/jsp/role_005fitem_005fselector_jsp.java uses unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:roles:roles-item-selector-web:compileJSP
     [exec] 
     [exec] > Task :apps:roles:roles-admin-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:roles:roles-admin-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.40/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] 
     [exec] > Task :apps:roles:roles-item-selector-web:jar
     [exec] > Task :apps:roles:roles-item-selector-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:roles:roles-item-selector-web:baseline SKIPPED
     [exec] > Task :apps:roles:roles-item-selector-web:syncVersions
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:roles:roles-admin-web:compileJSP
     [exec] 
     [exec] > Task :apps:roles:roles-admin-web:jar
     [exec] > Task :apps:roles:roles-admin-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:roles:roles-admin-web:baseline SKIPPED
     [exec] > Task :apps:roles:roles-admin-web:syncVersions
     [exec] Gradle build finished at 2021-02-24 20:57:41.039.
     [exec] 
     [exec] 
     [exec] FAILURE: Build completed with 2 failures.
     [exec] 
     [exec] 1: Task failed with an exception.
     [exec] -----------
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

liferay-continuous-integration · 2021-03-03T21:20:09Z

✔️ ci:test:bundle - 1 out of 1 jobs passed in 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ef1e49a5565418b5bf991238ee548fb8a8965e2

ci:test:bundle - 1 out of 1 jobs PASSED

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

calvinctvo · 2021-03-04T00:39:10Z

Hi @julien , the failure doesn't seem to be related to the PR. I've retrigger ci:test:stable and it hasn't finish running.

liferay-continuous-integration · 2021-03-04T00:45:46Z

✔️ ci:test:stable - 10 out of 10 jobs passed in 4 hours 12 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ef1e49a5565418b5bf991238ee548fb8a8965e2

Upstream Comparison:

Branch GIT ID: 4ef1e49a5565418b5bf991238ee548fb8a8965e2
Jenkins Build URL: Acceptance Upstream DXP (master) #1603

ci:test:stable - 10 out of 10 jobs PASSED

10 Successful Jobs:

For more details click here.

liferay-continuous-integration · 2021-03-04T05:31:00Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8482
Jenkins Report:jenkins-report.html
Jenkins Suite: stable
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:stable
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-03-03[12:43:18]
Spira Jenkins Build:publish-spira-report#20957

julien · 2021-03-04T07:52:09Z

@calvinctvo thanks for the help 👍

@drewbrokke if you have time could you please let me know if we can forward this one?
Thanks

jbalsas · 2021-03-05T09:40:22Z

ci:forward

liferay-continuous-integration · 2021-03-05T09:40:25Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-03-05T09:40:28Z

Skipping previously passed test suites:
ci:test:sf

liferay-continuous-integration · 2021-03-05T12:32:57Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 3 hours 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7deedb562a6145be11b327fc35f9693b6b4e1541

Upstream Comparison:

Branch GIT ID: 7deedb562a6145be11b327fc35f9693b6b4e1541
Jenkins Build URL: Acceptance Upstream DXP (master) #1608

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 22 out of 24 jobs PASSED

2 Failed Jobs:

22 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 7deedb5:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
63 Tests Passed.
3 Tests Failed.

liferay-continuous-integration · 2021-03-05T12:33:22Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2021-03-05T12:33:42Z

Pull request has been successfully forwarded to brianchandotcom#99554

liferay-continuous-integration · 2021-03-05T12:54:59Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7852
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-03-05[01:40:37]
Spira Jenkins Build:publish-spira-report#17062

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - pending labels Feb 24, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending labels Feb 24, 2021

julien changed the title ~~[Don't forward] Migrate v2 usages in roles/roles-admin-web~~ [Don't review yet] Migrate v2 usages in roles/roles-admin-web Feb 24, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure and removed ci:test:relevant - pending labels Feb 24, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - pending ci:test:relevant - pending labels Feb 24, 2021

liferay-continuous-integration added ci:test:bundle - pending ci:test:stable - pending and removed ci:test:stable - failure ci:test:bundle - pending labels Mar 3, 2021

liferay-continuous-integration added ci:test:stable - success and removed ci:test:stable - pending labels Mar 4, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Mar 5, 2021

liferay-continuous-integration mentioned this pull request Mar 5, 2021

LPS-121903 Migrate v2 usages in roles/roles-admin-web brianchandotcom/liferay-portal#99554

Closed

liferay-continuous-integration closed this Mar 5, 2021

julien deleted the LPS-121903 branch March 16, 2021 10:00

Conversation

julien commented Feb 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

Uh oh!

julien commented Feb 24, 2021

Uh oh!

julien commented Feb 24, 2021

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

Uh oh!

julien commented Feb 24, 2021

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 hours 47 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 2 hours 24 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

Uh oh!

liferay-continuous-integration commented Mar 3, 2021

✔️ ci:test:bundle - 1 out of 1 jobs passed in 46 minutes

Base Branch:

For more details click here.

Test bundle downloads:

Uh oh!

calvinctvo commented Mar 4, 2021

Uh oh!

liferay-continuous-integration commented Mar 4, 2021

✔️ ci:test:stable - 10 out of 10 jobs passed in 4 hours 12 minutes

Base Branch:

Upstream Comparison:

For more details click here.

Uh oh!

liferay-continuous-integration commented Mar 4, 2021

Uh oh!

julien commented Mar 4, 2021

Uh oh!

jbalsas commented Mar 5, 2021

Uh oh!

liferay-continuous-integration commented Mar 5, 2021

Uh oh!

liferay-continuous-integration commented Mar 5, 2021

Uh oh!

liferay-continuous-integration commented Mar 5, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 3 hours 4 minutes

Base Branch:

Upstream Comparison:

julien commented Feb 24, 2021 •

edited

Loading