feat: support scoped npm packages #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have changed this logic in bundler 2, but it remains the same in bundler 3 because we don't know if it should be changed there. But, since we need similar changes here I'm copying them. This is also a step towards removing the dependency from js-toolkit-core.
Also write federation config to a persistent temporary file in the build folder for debugging and development purposes.
I'm also fixing the feature, because it wasn't working on successful exit. The rationale behind this feature is that, for webpack federation, I want to keep temporary files in the build directory after the build. This is because it contains very useful information for development/debug purposes and, given that the temporary file is small and written to the build directory, I think it is better to keep it.
github-actions
bot
added
2.x
js-toolkit
npm-bundler-preset-liferay-dev
npm-scripts
npm-tools
labels
izaera
commented
Feb 18, 2021
maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/namespace.ts
Show resolved
Hide resolved
izaera
commented
Feb 18, 2021
projects/npm-tools/packages/npm-scripts/src/utils/createFederationConfig.js
Show resolved
Hide resolved
izaera
commented
Feb 18, 2021
projects/npm-tools/packages/npm-scripts/src/utils/createFederationConfig.js
Show resolved
Hide resolved
izaera
commented
Feb 18, 2021
izaera
commented
Feb 18, 2021
projects/npm-tools/packages/npm-scripts/src/utils/createFederationConfig.js
Outdated
Show resolved
Hide resolved
izaera
added a commit
to izaera/liferay-portal
that referenced
this pull request
Feb 18, 2021
Note this needs liferay/liferay-frontend-projects#408 to be merged to work.
wincent
approved these changes
Feb 19, 2021
Contributor
wincent
left a comment
wincent
left a comment
There was a problem hiding this comment.
I only got nits. Feel free to change/ignore as you see fit.
.../projects/js-toolkit/packages/liferay-npm-build-tools-common/src/__tests__/namespace.test.js
Show resolved
Hide resolved
.../projects/js-toolkit/packages/liferay-npm-build-tools-common/src/__tests__/namespace.test.js
Show resolved
Hide resolved
.../projects/js-toolkit/packages/liferay-npm-build-tools-common/src/__tests__/namespace.test.js
Show resolved
Hide resolved
maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/namespace.ts
Show resolved
Hide resolved
maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/namespace.ts
Show resolved
Hide resolved
projects/npm-tools/packages/npm-scripts/src/utils/bundlerNamespace.js
Outdated
Show resolved
Hide resolved
projects/npm-tools/packages/npm-scripts/src/utils/createTempFile.js
Outdated
Show resolved
Hide resolved
projects/npm-tools/packages/npm-scripts/src/utils/createTempFile.js
Outdated
Show resolved
Hide resolved
Use substring in all places for consistency, too.
Member
Author
|
I'm merging this and will release it then, to test it in liferay-frontend/liferay-portal#813 🕯️ |
izaera
added a commit
to izaera/liferay-portal
that referenced
this pull request
Feb 22, 2021
Note this needs liferay/liferay-frontend-projects#408 to be merged to work.
izaera
added a commit
to izaera/liferay-portal
that referenced
this pull request
Feb 24, 2021
Note this needs liferay/liferay-frontend-projects#408 to be merged to work.
izaera
added a commit
to izaera/liferay-portal
that referenced
this pull request
Feb 25, 2021
Note this needs liferay/liferay-frontend-projects#408 to be merged to work.
brianchandotcom
pushed a commit
to brianchandotcom/liferay-portal
that referenced
this pull request
Feb 25, 2021
Note this needs liferay/liferay-frontend-projects#408 to be merged to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as a prerequisite for https://issues.liferay.com/browse/LPS-127990
I've tested it locally and build is OK. Runtime doesn't fail but we'll see in the CI if we need anything else. 🤞
Server side PR here 👉 liferay-frontend/liferay-portal#813