transports/noise: Migrate away from deprecated sodiumoxide for tests#2817
Merged
mxinden merged 10 commits intolibp2p:masterfrom Aug 30, 2022
Merged
transports/noise: Migrate away from deprecated sodiumoxide for tests#2817mxinden merged 10 commits intolibp2p:masterfrom
sodiumoxide for tests#2817mxinden merged 10 commits intolibp2p:masterfrom
Conversation
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
mxinden
reviewed
Aug 17, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks for looking into this @pinkforest!
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thanks! Two ideas from my end :)
thomaseizinger
changed the title
sodiumoxide for tests
4 tasks
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
mxinden
approved these changes
Aug 25, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the follow ups @pinkforest.
Will wait for another review from @thomaseizinger before merging.
thomaseizinger
approved these changes
Aug 28, 2022
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Sorry for the long delay and thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sodiumoxide is used for testing the legacy noise protocol crypto
Sodiumoxide is deprecated which brings for testing comparison in noise proto context;
This change migrates from sodiumoxide to:
Links to any relevant issues
Fixes #2811
Open Questions
Change checklist
Migrate testing from against sodiumoxide to libsodium-sys-stable and ed25519-compact
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
A changelog entry has been made in the appropriate crates