Skip to content

Comments

Replacement of Sodiumoxide#2815

Closed
AbhijithGanesh wants to merge 4 commits intolibp2p:masterfrom
AbhijithGanesh:RUSTSEC-2021-0137-PATCH
Closed

Replacement of Sodiumoxide#2815
AbhijithGanesh wants to merge 4 commits intolibp2p:masterfrom
AbhijithGanesh:RUSTSEC-2021-0137-PATCH

Conversation

@AbhijithGanesh
Copy link

@AbhijithGanesh AbhijithGanesh commented Aug 11, 2022

Signed-off-by: Abhijith Ganesh 67182544+AbhijithGanesh@users.noreply.github.com

Description

Replaces Sodiumoxide Crate with ed25519_dalek crate due to the security issue: RUSTSEC-2021-0137

Links to any relevant issues

Linked Issue: #2811

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
@thomaseizinger
Copy link
Contributor

I've triggered the build and it is failing. Did this work for you locally?

@AbhijithGanesh
Copy link
Author

My local test showed pass, I do second doubt the very nature of the function due to the way it's implemented. I ve not made it a draft because I felt the tests were essential, I am trying to work this out

@AbhijithGanesh
Copy link
Author

@thomaseizinger I am aware there are security and compliance related issues with this PR but I don't intend to leave this hanging. Owning_Ref is another crate which was patched recently by Max Inden. This is failing the CI. As I update my branch, it should go away

Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
@thomaseizinger
Copy link
Contributor

We are likely going to move forward with #2817 for this issue because it uses a different library to do the testing than what we use for the production code which is a good idea for cryptography stuff.

Going to close this in favor of #2817. Thank you for the contribution effort though! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants