Closed
Conversation
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
Contributor
|
I've triggered the build and it is failing. Did this work for you locally? |
Author
|
My local test showed pass, I do second doubt the very nature of the function due to the way it's implemented. I ve not made it a draft because I felt the tests were essential, I am trying to work this out |
Author
|
@thomaseizinger I am aware there are security and compliance related issues with this PR but I don't intend to leave this hanging. |
Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhijith Ganesh 67182544+AbhijithGanesh@users.noreply.github.com
Description
Replaces
SodiumoxideCrate withed25519_dalekcrate due to the security issue: RUSTSEC-2021-0137Links to any relevant issues
Linked Issue: #2811
Open Questions
Change checklist