Skip to content

Conversation

@leonardbf
Copy link
Owner

Previously the Azure NetApp Files CLI was an extension only.
R4 standard of RP for GA


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

Previously the Azure NetApp Files CLI was an extension only.
R4 standard of RP for GA
@leonardbf leonardbf merged commit da1784a into master May 10, 2019
leonardbf pushed a commit that referenced this pull request May 15, 2019
…e option input. (Azure#8429)

* Bug fix in parser logics for --play-ready-template option input.

* Bug fix #2 in parser logics for --play-ready-template option input.
@leonardbf leonardbf deleted the NFSAAS-2316-update-to-R4 branch July 24, 2019 16:15
leonardbf pushed a commit that referenced this pull request Oct 24, 2019
* FeatureManagement CLI Part 1 (#1)

* FeatureManagement CLI Part 1

FeatureManagement initial code setup and implementation of "show feature"  and "set feature" commands

* Adding "delete" and "list" feature commands
* Adding "set" and "show" feature commands
* Add "enable", "disable", "lock", "unlock" commands

* Final changes for feature management CLI (#2)

* FeatureManagement CLI Part 1

FeatureManagement initial code setup and implementation of "show feature"  and "set feature" commands

* Adding "delete" and "list" feature commands

* Resolving Comments

* Add "enable", "disable", "lock", "unlock" commands

* Resolving comments

* Resolving comments

* setup for filter commands

* Adding filter commands

* Adding Unit Tests

* Fix styling issues

* test recordings

* Update release history

* resolving comments

* resolving comments

* Minor change

* Add FeatureFlagValue Model

* Validate filter parameters

* Fix formatting of _params.py

* Change variable names

* Log warning when delete filter index mismatch

* Resolving comments

* Fix styling issues

* String formatting for python 2.7 compatibility

* Python 2.7 compatibility for unit tests

* fix id attribute for feature flag value

* Modify list feature default label behavior

* Check content type for features

* CLI team's suggested changes

* Update test recordings

* Changing commands to custom_commands

* changed empty label behavior for delete feature

* Change warning message

* Removing label from FeatureFlagValue

* Use shell_safe_json_parse for deserialiization
leonardbf pushed a commit that referenced this pull request Feb 3, 2020
* FeatureManagement CLI Part 1 (#1)

* FeatureManagement CLI Part 1

FeatureManagement initial code setup and implementation of "show feature"  and "set feature" commands

* Adding "delete" and "list" feature commands
* Adding "set" and "show" feature commands
* Add "enable", "disable", "lock", "unlock" commands

* Final changes for feature management CLI (#2)

* FeatureManagement CLI Part 1

FeatureManagement initial code setup and implementation of "show feature"  and "set feature" commands

* Adding "delete" and "list" feature commands

* Resolving Comments

* Add "enable", "disable", "lock", "unlock" commands

* Resolving comments

* Resolving comments

* setup for filter commands

* Adding filter commands

* Adding Unit Tests

* Fix styling issues

* test recordings

* Update release history

* resolving comments

* resolving comments

* Minor change

* Add FeatureFlagValue Model

* Validate filter parameters

* Fix formatting of _params.py

* Change variable names

* Log warning when delete filter index mismatch

* Resolving comments

* Fix styling issues

* String formatting for python 2.7 compatibility

* Python 2.7 compatibility for unit tests

* fix id attribute for feature flag value

* Modify list feature default label behavior

* Check content type for features

* CLI team's suggested changes

* Update test recordings

* Changing commands to custom_commands

* Stop reading dest file contents during export

* History file update

* Merge with latest code

* changed empty label behavior for delete feature

* Change warning message

* Removing label from FeatureFlagValue

* Use shell_safe_json_parse for deserialiization

* Updating export for feature flags

* Feature export scenario updates

* Import feature flags from json format

* Adding test

* Fix styling

* Fix Styling

* UPdate history file

* Add sample commands

* improving help messages

* Split print preview of features and kv

* Support alternate json format for ON/OFF features

* Adding more tests

* fix styling

* Use knack logger and enum arg type

* refactoring

* disabling ensure_ascii for json dumps

* Resolving comments

* Refactoring export command

* Resolvong CLI side comments

* Resolving comments

* Update test recordings

* Rename default_value variable

* fix history file

* change separator for history file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants