Skip to content

Conversation

@shigeyf
Copy link
Contributor

@shigeyf shigeyf commented Feb 5, 2019


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@tjprescott
Copy link
Member

This fails a test on Python 2.7.
test_content_key_policy_create_with_playready_success

@shigeyf
Copy link
Contributor Author

shigeyf commented Feb 11, 2019

@tjprescott
Travis CI testing is against not only to 'ams' module.
The error seems to be about 'vmss' and others.
This fix does not seem to be harmful. Please check doubly on your side.

@tjprescott
Copy link
Member

tjprescott commented Feb 11, 2019

The test that is failing is test_content_key_policy_create_with_playready_success which is a test for the AMS module. You will need to fix that.

@shigeyf
Copy link
Contributor Author

shigeyf commented Feb 12, 2019

Oops! Sorry, I missed the error line in such a long log! Let me check how I can fix the error.

@shigeyf
Copy link
Contributor Author

shigeyf commented Feb 13, 2019

I have fixed the test error: test_content_key_policy_create_with_playready_success
Appreciate your review!

Copy link

@BrianBlum BrianBlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

@tjprescott tjprescott merged commit 44f570a into Azure:dev Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants