NFSAAS-2316 first version of ANF CLI #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Azure NetApp Files CLI was an extension only. R4 standard of RP for GA
leonardbf
pushed a commit
that referenced
this pull request
May 15, 2019
* adding cluster admin option to osa create * adding direcctory read permissions to the aad app (#1) * adding cluster admin option to osa create * adding direcctory read permissions to the aad app * making active directory app always require directory permissions * infra node to 3 * adding new version of python sdk (#3) * adding cluster admin option to osa create * adding direcctory read permissions to the aad app * making app always require directory permissions * clean + infra node to 3 * fixing typo * using new version of acs python sdk * updating history.rst * Change type from scope to role * apply review * pep fix * fix merge conflict * update history and help * update recorded aks tests * Revert "update recorded aks tests" This reverts commit 8643736. * change api version for tests
leonardbf
pushed a commit
that referenced
this pull request
Oct 24, 2019
* FeatureManagement CLI Part 1 (#1) * FeatureManagement CLI Part 1 FeatureManagement initial code setup and implementation of "show feature" and "set feature" commands * Adding "delete" and "list" feature commands * Adding "set" and "show" feature commands * Add "enable", "disable", "lock", "unlock" commands * Final changes for feature management CLI (#2) * FeatureManagement CLI Part 1 FeatureManagement initial code setup and implementation of "show feature" and "set feature" commands * Adding "delete" and "list" feature commands * Resolving Comments * Add "enable", "disable", "lock", "unlock" commands * Resolving comments * Resolving comments * setup for filter commands * Adding filter commands * Adding Unit Tests * Fix styling issues * test recordings * Update release history * resolving comments * resolving comments * Minor change * Add FeatureFlagValue Model * Validate filter parameters * Fix formatting of _params.py * Change variable names * Log warning when delete filter index mismatch * Resolving comments * Fix styling issues * String formatting for python 2.7 compatibility * Python 2.7 compatibility for unit tests * fix id attribute for feature flag value * Modify list feature default label behavior * Check content type for features * CLI team's suggested changes * Update test recordings * Changing commands to custom_commands * changed empty label behavior for delete feature * Change warning message * Removing label from FeatureFlagValue * Use shell_safe_json_parse for deserialiization
leonardbf
pushed a commit
that referenced
this pull request
Feb 3, 2020
* FeatureManagement CLI Part 1 (#1) * FeatureManagement CLI Part 1 FeatureManagement initial code setup and implementation of "show feature" and "set feature" commands * Adding "delete" and "list" feature commands * Adding "set" and "show" feature commands * Add "enable", "disable", "lock", "unlock" commands * Final changes for feature management CLI (#2) * FeatureManagement CLI Part 1 FeatureManagement initial code setup and implementation of "show feature" and "set feature" commands * Adding "delete" and "list" feature commands * Resolving Comments * Add "enable", "disable", "lock", "unlock" commands * Resolving comments * Resolving comments * setup for filter commands * Adding filter commands * Adding Unit Tests * Fix styling issues * test recordings * Update release history * resolving comments * resolving comments * Minor change * Add FeatureFlagValue Model * Validate filter parameters * Fix formatting of _params.py * Change variable names * Log warning when delete filter index mismatch * Resolving comments * Fix styling issues * String formatting for python 2.7 compatibility * Python 2.7 compatibility for unit tests * fix id attribute for feature flag value * Modify list feature default label behavior * Check content type for features * CLI team's suggested changes * Update test recordings * Changing commands to custom_commands * Stop reading dest file contents during export * History file update * Merge with latest code * changed empty label behavior for delete feature * Change warning message * Removing label from FeatureFlagValue * Use shell_safe_json_parse for deserialiization * Updating export for feature flags * Feature export scenario updates * Import feature flags from json format * Adding test * Fix styling * Fix Styling * UPdate history file * Add sample commands * improving help messages * Split print preview of features and kv * Support alternate json format for ON/OFF features * Adding more tests * fix styling * Use knack logger and enum arg type * refactoring * disabling ensure_ascii for json dumps * Resolving comments * Refactoring export command * Resolvong CLI side comments * Resolving comments * Update test recordings * Rename default_value variable * fix history file * change separator for history file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Azure NetApp Files CLI was an extension only.
R4 standard of RP for GA
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.