Remove noop event listener when testing for passive events #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked in on Modernizr's implementation of this and found that they've made a small improvement. This appears to have been done to improve support for EdgeHTML 15: Modernizr/Modernizr#2299
lencioni
added a commit
to civiccc/react-waypoint
that referenced
this pull request
Jun 18, 2018
None of the changes affect how consolidated-events is used in react-waypoint. Changelog: - Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
lencioni
added a commit
to airbnb/react-outside-click-handler
that referenced
this pull request
Jun 18, 2018
- Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
lencioni
added a commit
to react-dates/react-dates
that referenced
this pull request
Jun 18, 2018
- Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
lencioni
added a commit
to react-dates/react-dates
that referenced
this pull request
Jun 18, 2018
- Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
devs-cloud
pushed a commit
to devs-cloud/react-date
that referenced
this pull request
Dec 27, 2019
- Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
MarcoAntonioAG
pushed a commit
to MarcoAntonioAG/React-dates
that referenced
this pull request
Mar 31, 2022
- Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked in on Modernizr's implementation of this and found that
they've made a small improvement.
This appears to have been done to improve support for EdgeHTML 15:
Modernizr/Modernizr#2299