Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up 'global' style build. #13

Closed
flarnie opened this issue Mar 30, 2015 · 4 comments
Closed

Set up 'global' style build. #13

flarnie opened this issue Mar 30, 2015 · 4 comments

Comments

@flarnie
Copy link
Contributor

flarnie commented Mar 30, 2015

We have set up a 'npm' style build system modeled after the 'React-Router' repository's 'npm' build. It would be nice to also have a 'global' style build. See the 'React-Router' package.json and their 'build/global' directory.

Once we have a global build set up, we could use that for issue #14 (Using global build in 'gh-pages' branch.)
@flarnie flarnie mentioned this issue Mar 30, 2015
Closed
@tdooner
Copy link

tdooner commented May 2, 2015

Does "global style build" mean a version which isn't a CommonJS module?

I found myself wanting this a moment ago -- I'm rewriting Mosaic to be React this weekend, and replacing the jQuery lazy load with react-waypoint, but I'm not fancy enough for the CommonJS module stuff yet.

Anyway, removing the var React = require('React') and the module.exports = Waypoint worked, but it would be good to just be able to use the official bower/npm build.

@lencioni
Copy link
Collaborator

lencioni commented May 2, 2015

Does "global style build" mean a version which isn't a CommonJS module?

Yes, exactly.

To be honest, I think you'd be best off just setting up webpack. They have a pretty full-featured webpack react starter that should get you up and running pretty quickly.

tdooner added a commit to tdooner/mosaic that referenced this issue May 3, 2015
@tdooner
WIP: Rewrite JS in React
ac5022a 
This is pretty much a direct port of the janky jQuery DOM manipulation
into a poorly-structured, <div>-heavy React component topology.

It uses react-waypoint to replace the jQuery lazy loading, and
react-router to handle the inter-page navigation, which should hopefully
give me a better place to go from when I want to add new pages to the
site.

TODO:
- Cleanup the parts where React eats my whitespace
- Rebuild the tags page (add that logic back in)
- Use Bower to manage vendored JS
  - Somewhat blocked by
    civiccc/react-waypoint#13
  - Unless we:
- Use some CommonJS builder (Webpack, Browserify, etc.) to compile JSX /
  minify JS / etc. (I explicitly want to avoid concatenating all JS into
  a single file for as long as possible, though. Mosaic is meant to be
  served over HTTP/2.)
@trotzig
Copy link
Collaborator

trotzig commented Oct 31, 2015

@flarnie is this still important? I'm trying to close out old and inactive issues, and this hasn't been touched in a while.

Also, hi! We miss you!

@trotzig
Copy link
Collaborator

trotzig commented Apr 9, 2016

Closing. Even though this would be convenient, I don't think we should support this use-case.

@trotzig trotzig closed this as completed Apr 9, 2016
lencioni added a commit that referenced this issue Jun 18, 2018
@lencioni
Allow consolidated-events ^2.0.0
a29e97d 
None of the changes affect how consolidated-events is used in
react-waypoint.

Changelog:

- Now built with rollup ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tdooner @lencioni @trotzig @flarnie