Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible Bug with 'resize' listener #8

Closed
flarnie opened this issue Mar 7, 2015 · 0 comments
Closed

Possible Bug with 'resize' listener #8

flarnie opened this issue Mar 7, 2015 · 0 comments
Assignees
@flarnie
Labels
bug

Comments

@flarnie
Copy link
Contributor

flarnie commented Mar 7, 2015

We listen to the 'scroll' and 'resize' events on the 'scrollableParent' element, which is sometimes the window. However, the 'resize' event is only triggered on the window element, so we may not catch it in cases that the 'scrollableParent' is not the window.

It seems safer to listen to the 'resize' event always on the window, rather than the scrollable parent.
@flarnie flarnie added the bug label Mar 7, 2015
@flarnie flarnie self-assigned this Mar 7, 2015
@flarnie flarnie closed this as completed in b2bda88 Mar 7, 2015
flarnie added a commit that referenced this issue Mar 7, 2015
@flarnie
Merge pull request #10 from brigade/fix_bug_8
a2cf68e 
Listen to 'resize' on window, not scrollableParent; fixes #8
lencioni added a commit that referenced this issue Jun 18, 2018
@lencioni
Allow consolidated-events ^2.0.0
a29e97d 
None of the changes affect how consolidated-events is used in
react-waypoint.

Changelog:

- Now built with rollup ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flarnie flarnie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flarnie