style(code): /model footer Ctrl+N hint follows display mode - #5247
Merged
Mason Daugherty (mdrxy) merged 2 commits intoAug 3, 2026
Merged
Conversation
The `/model` selector footer always read "Ctrl+N IDs", even after the rows had been flipped to raw `provider:model` specs, so the hint stopped describing what the next press would do. Render it from `_show_specs` and refresh the footer when the toggle fires. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
Mason Daugherty (mdrxy)
marked this pull request as ready for review
August 3, 2026 14:28
The `/model` picker's footer is written by both Ctrl+S (transient status message) and Ctrl+N (help line with the display-mode hint). Toggling display modes while a "Failed to save/clear default" notice was up wiped the only signal that the write had failed. Track whether the footer is showing a failure notice and hold back the Ctrl+N refresh while it is; rows still flip, and the notice's existing 3s timer restores the hint for whichever mode is current when it fires. Also make the Ctrl+N binding description mode-neutral, since it cannot track `_show_specs` the way the footer hint does.
/model footer Ctrl+N hint follows display mode/model footer Ctrl+N hint follows display mode
Mason Daugherty (mdrxy)
deleted the
open-swe/model-selector-names-toggle-footer
branch
August 3, 2026 16:15
Johannes du Plessis (johannes117)
pushed a commit
that referenced
this pull request
Aug 4, 2026
> [!CAUTION] > Merging this PR will automatically publish to **PyPI** and create a **GitHub release**. For the full release process, see [`.github/RELEASING.md`](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md). --- _Release notes preview: keep this section in sync with the package `CHANGELOG.md`. Publish reads the merged CHANGELOG via `release.yml`, not this PR description — keep them aligned anyway so the PR stays an accurate historical record for reviewers and anyone returning later._ --- ## [0.1.52](deepagents-code==0.1.51...deepagents-code==0.1.52) (2026-08-04) ### Features - Hooks v2 is now generally available, with support for loading hooks from installed plugins. ([#5307](#5307), [#5198](#5198)) - Auto approval classifier configuration now supports selecting the classifier model and setting a review timeout. ([#5205](#5205), [#5302](#5302)) - HITL rejection reasons are now framed for the model, and the approval menu makes reject-with-feedback easier to discover. ([#5259](#5259), [#5260](#5260)) - Added a tri-state `DEEPAGENTS_CODE_ONBOARDING` environment variable. ([#5301](#5301)) - The `/model` footer Ctrl+N hint now follows the current display mode. ([#5247](#5247)) - The price catalog now refreshes hourly in the background. ([#5264](#5264)) - Updated recommendations to include DeepSeek V4 Flash 0731. ([#5244](#5244)) ### Bug Fixes - Fixed several Hooks v2 lifecycle issues: session-end teardown is now bounded, hooks refresh after cwd switches, malformed hook resumes are handled, hook stops surface without agent errors, and unused `SessionEndCause` members were removed. ([#5248](#5248), [#5249](#5249), [#5233](#5233), [#5276](#5276), [#5240](#5240)) - `PreCompact` now fires before auto-compaction. ([#5277](#5277)) _End release notes preview._ --- > [!NOTE] > A **New Contributors** section is appended to the GitHub release notes automatically at publish time (see [Release Pipeline](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md#release-pipeline), step 2). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: langchain-oss-automated-triage[bot] <248757908+langchain-oss-automated-triage[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/modelselector footer now toggles its Ctrl+N hint between "IDs" and "names" to match the current row display mode.The
/modelselector footer always read "Ctrl+N IDs", even once rows were flipped to rawprovider:modelspecs, so the hint no longer described what the next press does. The hint is now derived from_show_specs("Ctrl+N IDs" while friendly names show, "Ctrl+N names" while specs show) and the footer is refreshed when the toggle fires.Made by Open SWE