Stav/merge starkware development #2153

Stavbe · 2025-08-07T14:07:23Z

See #2076 for full commit history of the starkware-development branch.

This change is

* Fix flow notation * Fix dependency

…2022)

* Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]>

…2023)

# TITLE Cherry-pick all the commits from main Description of the pull request changes and motivation. ## Checklist - [ ] Linked to Github Issue - [ ] Unit tests added - [ ] Integration tests added. - [ ] This change requires new documentation. - [ ] Documentation has been added/updated. - [ ] CHANGELOG has been updated.

# TITLE ## Description Description of the pull request changes and motivation. ## Checklist - [ ] Linked to Github Issue - [ ] Unit tests added - [ ] Integration tests added. - [ ] This change requires new documentation. - [ ] Documentation has been added/updated. - [ ] CHANGELOG has been updated.  - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/lambdaclass/cairo-vm/2036)

# TITLE ## Description Description of the pull request changes and motivation. ## Checklist - [ ] Linked to Github Issue - [ ] Unit tests added - [ ] Integration tests added. - [ ] This change requires new documentation. - [ ] Documentation has been added/updated. - [ ] CHANGELOG has been updated.

This PR is an as-is copy of AlonT's PR pushed to a fork repo.

Set disable trace padding flag if prover input info is required. + add 'proof mode' as required for prover_input_info

Added another flag to allow fast serialization of 'prover_input_info' into a binary file

* Remove duplicated `get_val` (#2065) * avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file * CI: Make cache keys depend on Cairo version (#2056) * Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * dev: make Memory::get `pub` (#2039) * dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests * feat(breaking): add support for hint accessible scopes (#2042) * feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * feat: add support for alias identifiers destination in program serde (#2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]> * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils (#2062) * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * docs: add --run_from_cairo_pie documentation for Cairo 0 and Cairo 1 (#2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * Fix WRITE_DIVMOD_SEGMENT hint (#2078) * Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md * Bump cairo-lang to 0.13.5 (#1959) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature * Prepare for Release v3.0.0-rc.1 (#2092) * Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI * fix: correct cache keys for no-std test coverage in CI (#2093) * Update rust.yml * Update rust.yml * Update rust toolchain to 1.87.0 (#2100) * update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow * fix Changelog link (#2104) * Improve memory_segments coverage (#2110) * Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments --------- Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]>

This reverts commit 7269a8f.

YairVaknin-starkware

Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware and @yuvalsw)

a discussion (no related file):
Why didn't you keep the history like a normal merge and squashed everything into one commit? Makes it much harder to make sure all changes are present.

Stavbe

Reviewable status: 0 of 32 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware, @YairVaknin-starkware, and @yuvalsw)

a discussion (no related file):

Previously, YairVaknin-starkware wrote…

Why didn't you keep the history like a normal merge and squashed everything into one commit? Makes it much harder to make sure all changes are present.

Done

YairVaknin-starkware

Reviewed 18 of 24 files at r1, 14 of 14 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anatgstarkware and @yuvalsw)

CHANGELOG.md line 22 at r4 (raw file):

* fix: Fix zero offset output base assumption [#2068](https://github.com/lambdaclass/cairo-vm/pull/2068)

* feat: Add perpendicular and dex with bitwise layouts [#2067](https://github.com/lambdaclass/cairo-vm/pull/2067)

perpetual

Code quote:

perpendicular

Stavbe

Reviewable status: 31 of 32 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware, @YairVaknin-starkware, and @yuvalsw)

CHANGELOG.md line 22 at r4 (raw file):

Previously, YairVaknin-starkware wrote…

perpetual

Done.

YairVaknin-starkware

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @anatgstarkware and @yuvalsw)

.github/workflows/rust.yml

vm/src/vm/runners/cairo_runner.rs

cairo_programs/poseidon_builtin_hole.cairo

CHANGELOG.md

gabrielbosio · 2025-08-11T14:00:39Z

Hi, @Stavbe, #2162 was merged into starkware-development but it is not included here, at least in the commit history. If the change from that PR is meant to be included in main I think it should be added here.

gabrielbosio · 2025-08-11T14:05:26Z

As an alternative, #2076 tracks the starkware-development branch. It does not have the updated changelog, but #2151 may fix that.

#2153 (comment)

…/merge_starkware_development

Stavbe

Hey @gabrielbosio, I updated the merge to also contain this commit.

Reviewable status: 14 of 33 files reviewed, 4 unresolved discussions (waiting on @anatgstarkware, @JulianGCalderon, @YairVaknin-starkware, and @yuvalsw)

CHANGELOG.md

.github/workflows/rust.yml

cairo_programs/poseidon_builtin_hole.cairo

vm/src/vm/runners/cairo_runner.rs

JulianGCalderon

LGTM

JulianGCalderon and others added 30 commits March 27, 2025 16:36

Add starkware-development to CI (like another main) (#2025)

106e5f8

Keep None memory cells for the prover input info (#2021)

ce73503

CI: Fix cache not found error (#2026)

05fb44f

* Fix flow notation * Fix dependency

Remove dependancy in cairo pie when collectiog builtin segments info (#…

bdd75dd

…2022)

use btreemap instead of hashmap for deterministic iteration order. (#…

92e3188

…2023)

fill holes is builtins segments

2137db8

fill holes is builtins segments

6dfd853

Added hints felt unpacking for blake (#2032)

895be71

This PR is an as-is copy of AlonT's PR pushed to a fork repo.

add prover input info flag to vm-cli

d729b9f

Stav/add prover input info flag (#2047)

b9330cd

set disable trace padding for prover input info

3179708

Stav/disable trace padding for prover input info (#2066)

ba51705

Set disable trace padding flag if prover input info is required. + add 'proof mode' as required for prover_input_info

Add_perp_and_dex_w_bitwise_layouts (#2067)

28f4004

Fix_zero_offset_output_base_assumption (#2068)

9c44e1c

add flag to serialize prover input info into binary files

58174f3

use bincode for faster writing prover input info (#2074)

33d75ca

Added another flag to allow fast serialization of 'prover_input_info' into a binary file

Use_btreemap_for_deterministic_order_of_pie_keys (#2085)

dc1c49b

[BREAKING] Compute_missing_builtin_cells_only_in_proof_mode (#2088)

b1a91f9

move prover input info to a new seperate file (#2079)

a5b3c9d

add trace not enabled error

547dca1

add trace not enabled error (#2080)

da5dffd

add test to filling holes (#2087)

627c1ac

memory comparision test only for non proof mode cases

41486b5

Stav/remove test compare to python vm (#2086)

b818326

Revert "Sync with main (#2116)" (#2117)

870fd60

This reverts commit 7269a8f.

Stavbe requested review from YairVaknin-starkware, anatgstarkware, gabrielbosio and yuvalsw August 7, 2025 14:46

Stavbe self-assigned this Aug 7, 2025

gabrielbosio previously approved these changes Aug 7, 2025

View reviewed changes

gabrielbosio mentioned this pull request Aug 8, 2025

Reminder: Enable memory length comparison with cairo-lang #2046

Closed

YairVaknin-starkware requested changes Aug 10, 2025

View reviewed changes

Stavbe force-pushed the stav/merge_starkware_development branch 2 times, most recently from 7ee6bd5 to 502616b Compare August 10, 2025 12:25

Stavbe commented Aug 10, 2025

View reviewed changes

YairVaknin-starkware requested changes Aug 10, 2025

View reviewed changes

Stavbe force-pushed the stav/merge_starkware_development branch from 502616b to 81e66f9 Compare August 10, 2025 13:32

Stavbe commented Aug 10, 2025

View reviewed changes

YairVaknin-starkware approved these changes Aug 10, 2025

View reviewed changes

Use_BTreeMap_in_pie_additional_data (#2162)

e2c6c91

JulianGCalderon reviewed Aug 11, 2025

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

vm/src/vm/runners/cairo_runner.rs Show resolved Hide resolved

cairo_programs/poseidon_builtin_hole.cairo Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/starkware-development' into stav…

3f63706

…/merge_starkware_development

Stavbe force-pushed the stav/merge_starkware_development branch from 81e66f9 to 3f63706 Compare August 12, 2025 07:33

Stavbe commented Aug 12, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

.github/workflows/rust.yml Outdated Show resolved Hide resolved

cairo_programs/poseidon_builtin_hole.cairo Show resolved Hide resolved

vm/src/vm/runners/cairo_runner.rs Show resolved Hide resolved

JulianGCalderon approved these changes Aug 12, 2025

View reviewed changes

gabrielbosio added this pull request to the merge queue Aug 12, 2025

Merged via the queue into main with commit 1b6a192 Aug 12, 2025
93 checks passed

gabrielbosio deleted the stav/merge_starkware_development branch August 12, 2025 16:25

gabrielbosio restored the stav/merge_starkware_development branch August 13, 2025 12:24

gabrielbosio mentioned this pull request Aug 13, 2025

Revert squashed starkware-development commit #2171

Merged

Stav/merge starkware development #2153

Stav/merge starkware development #2153

Uh oh!

Conversation

Stavbe commented Aug 7, 2025 • edited by gabrielbosio Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YairVaknin-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Stavbe left a comment

Choose a reason for hiding this comment

Uh oh!

YairVaknin-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Stavbe left a comment

Choose a reason for hiding this comment

Uh oh!

YairVaknin-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabrielbosio commented Aug 11, 2025

Uh oh!

gabrielbosio commented Aug 11, 2025

Uh oh!

Stavbe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JulianGCalderon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Stavbe commented Aug 7, 2025 •

edited by gabrielbosio

Loading