Stav/use btmap #2023

Stavbe · 2025-03-24T15:37:28Z

Use Btreemap instead of hashmap

Description

For deterministic iteration order in the adapter side.

Checklist

Linked to Github Issue
Unit tests added
Integration tests added.
This change requires new documentation.
- Documentation has been added/updated.
- CHANGELOG has been updated.

This change is

github-actions · 2025-03-24T15:46:10Z

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.294 s ±  0.053 s    [User: 25.491 s, System: 0.802 s]
  Range (min … max):   26.257 s … 26.332 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.243 s ±  0.082 s    [User: 25.432 s, System: 0.809 s]
  Range (min … max):   26.185 s … 26.301 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.803 s ±  0.166 s    [User: 25.758 s, System: 0.822 s]
  Range (min … max):   14.685 s … 14.920 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.582 s ±  0.046 s    [User: 25.564 s, System: 0.809 s]
  Range (min … max):   14.550 s … 14.615 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.507 s ±  0.159 s    [User: 38.566 s, System: 0.961 s]
  Range (min … max):   10.395 s … 10.619 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.630 s ±  0.366 s    [User: 37.628 s, System: 0.960 s]
  Range (min … max):   10.371 s … 10.889 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.589 s ±  0.272 s    [User: 38.366 s, System: 0.993 s]
  Range (min … max):   10.397 s … 10.781 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.652 s ±  0.216 s    [User: 37.880 s, System: 1.008 s]
  Range (min … max):   10.499 s … 10.805 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.402 s ±  0.077 s    [User: 38.508 s, System: 1.016 s]
  Range (min … max):   10.348 s … 10.457 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.246 s ±  0.184 s    [User: 38.396 s, System: 1.018 s]
  Range (min … max):   10.116 s … 10.377 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.308 s ±  0.084 s    [User: 38.816 s, System: 1.117 s]
  Range (min … max):   10.248 s … 10.368 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.299 s ±  0.146 s    [User: 38.853 s, System: 1.072 s]
  Range (min … max):   10.196 s … 10.402 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.00 ± 0.02 times faster than hyper_threading_main threads: 16

github-actions · 2025-03-24T16:07:03Z

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_factorial`	2.126 ± 0.018	2.102	2.165	1.00
`head big_factorial`	2.136 ± 0.017	2.119	2.177	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_fibonacci`	2.055 ± 0.011	2.042	2.075	1.00
`head big_fibonacci`	2.058 ± 0.011	2.042	2.076	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base blake2s_integration_benchmark`	7.546 ± 0.028	7.489	7.591	1.00
`head blake2s_integration_benchmark`	7.597 ± 0.015	7.566	7.609	1.01 ± 0.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base compare_arrays_200000`	2.170 ± 0.010	2.157	2.190	1.00
`head compare_arrays_200000`	2.183 ± 0.011	2.175	2.211	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_integration_benchmark`	1.429 ± 0.004	1.424	1.434	1.00
`head dict_integration_benchmark`	1.433 ± 0.006	1.428	1.447	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base field_arithmetic_get_square_benchmark`	1.200 ± 0.004	1.196	1.207	1.00
`head field_arithmetic_get_square_benchmark`	1.218 ± 0.005	1.210	1.225	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base integration_builtins`	7.593 ± 0.032	7.552	7.663	1.00
`head integration_builtins`	7.686 ± 0.043	7.606	7.777	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base keccak_integration_benchmark`	7.876 ± 0.125	7.781	8.162	1.00
`head keccak_integration_benchmark`	7.933 ± 0.100	7.883	8.215	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
`base linear_search`	2.144 ± 0.021	2.120	2.181	1.00
`head linear_search`	2.144 ± 0.010	2.132	2.160	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_cmp_and_pow_integration_benchmark`	1.509 ± 0.004	1.500	1.513	1.00 ± 0.00
`head math_cmp_and_pow_integration_benchmark`	1.508 ± 0.005	1.501	1.515	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_integration_benchmark`	1.452 ± 0.007	1.442	1.460	1.00
`head math_integration_benchmark`	1.458 ± 0.006	1.449	1.471	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base memory_integration_benchmark`	1.219 ± 0.012	1.211	1.251	1.01 ± 0.01
`head memory_integration_benchmark`	1.212 ± 0.011	1.205	1.243	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base operations_with_data_structures_benchmarks`	1.558 ± 0.004	1.552	1.565	1.00
`head operations_with_data_structures_benchmarks`	1.577 ± 0.008	1.567	1.587	1.01 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base pedersen`	533.4 ± 1.0	531.6	534.7	1.00
`head pedersen`	536.0 ± 2.8	532.2	541.1	1.00 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base poseidon_integration_benchmark`	630.7 ± 3.3	622.2	634.3	1.00 ± 0.01
`head poseidon_integration_benchmark`	629.9 ± 5.5	622.1	637.7	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base secp_integration_benchmark`	1.851 ± 0.004	1.844	1.858	1.00
`head secp_integration_benchmark`	1.859 ± 0.005	1.852	1.867	1.00 ± 0.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base set_integration_benchmark`	662.5 ± 5.2	654.0	670.5	1.05 ± 0.01
`head set_integration_benchmark`	628.0 ± 1.9	624.7	631.2	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base uint256_integration_benchmark`	4.155 ± 0.026	4.123	4.202	1.00
`head uint256_integration_benchmark`	4.240 ± 0.040	4.201	4.334	1.02 ± 0.01

codecov · 2025-03-24T16:08:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (63fa1b7) to head (0f78168).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2023   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         102      102           
  Lines       42755    42755           
=======================================
  Hits        41276    41276           
  Misses       1479     1479

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DavidLevitGurevich

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @FrancoGiachetta, @JulianGCalderon, and @yuvalsw)

yuvalsw

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @FrancoGiachetta and @JulianGCalderon)

JulianGCalderon · 2025-03-25T20:20:58Z

CHANGELOG.md

+* fix: Updated the logic for collecting builtin segment data for prover input info, removing dependency on the existence of stop pointers. [#2022](https://github.com/lambdaclass/cairo-vm/pull/2022)
+


This comment is repeated. Please remove it.

Stavbe

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich and @JulianGCalderon)

Stavbe · 2025-03-26T10:06:12Z

CHANGELOG.md

+* fix: Updated the logic for collecting builtin segment data for prover input info, removing dependency on the existence of stop pointers. [#2022](https://github.com/lambdaclass/cairo-vm/pull/2022)
+


JulianGCalderon

LGTM

Stavbe

Hi @JulianGCalderon, you are blocking&approve

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich and @JulianGCalderon)

JulianGCalderon · 2025-03-26T18:35:34Z

Hi @JulianGCalderon, you are blocking&approve

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich and @JulianGCalderon)

I think that issue is related to reviewable. It shouldn't be a problem as from Github's point of view, I approved the PR.

JulianGCalderon · 2025-03-26T22:11:05Z

@Stavbe there are some Ci jobs failing. Could you fix them please?

…2023)

…ambdaclass#2023)

…2023)

* Add starkware-development to CI (like another main) (#2025) * Keep None memory cells for the prover input info (#2021) * CI: Fix cache not found error (#2026) * Fix flow notation * Fix dependency * Remove dependancy in cairo pie when collectiog builtin segments info (#2022) * Add Commit Signing section (#2019) * Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> * use btreemap instead of hashmap for deterministic iteration order. (#2023) * fill holes is builtins segments * fill holes is builtins segments * Added hints felt unpacking for blake (#2032) This PR is an as-is copy of AlonT's PR pushed to a fork repo. * add prover input info flag to vm-cli * set disable trace padding for prover input info * Add_perp_and_dex_w_bitwise_layouts (#2067) * Fix_zero_offset_output_base_assumption (#2068) * add flag to serialize prover input info into binary files * Use_btreemap_for_deterministic_order_of_pie_keys (#2085) * [BREAKING] Compute_missing_builtin_cells_only_in_proof_mode (#2088) * move prover input info to a new seperate file (#2079) * add trace not enabled error * add test to filling holes (#2087) * memory comparision test only for non proof mode cases * Sync with main (#2116) * Remove duplicated `get_val` (#2065) * avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file * CI: Make cache keys depend on Cairo version (#2056) * Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * dev: make Memory::get `pub` (#2039) * dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests * feat(breaking): add support for hint accessible scopes (#2042) * feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * feat: add support for alias identifiers destination in program serde (#2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]> * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils (#2062) * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * docs: add --run_from_cairo_pie documentation for Cairo 0 and Cairo 1 (#2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * Fix WRITE_DIVMOD_SEGMENT hint (#2078) * Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md * Bump cairo-lang to 0.13.5 (#1959) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature * Prepare for Release v3.0.0-rc.1 (#2092) * Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI * fix: correct cache keys for no-std test coverage in CI (#2093) * Update rust.yml * Update rust.yml * Update rust toolchain to 1.87.0 (#2100) * update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow * fix Changelog link (#2104) * Improve memory_segments coverage (#2110) * Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments --------- Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]> * Revert "Sync with main (#2116)" (#2117) This reverts commit 7269a8f. * Bump cairo-lang to 0.13.5 (#1959) (#2118) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Enable_using_secure_run_in_proof_mode (#2113) * take ownershop instad of clone * Fixed bad submodule (#2131) * Added support for large files in PIE (#2136) * [starkware-development] Pin types-rs version to the one set in lockfile (#2142) * Update changelog * Pin types-rs version * Include_output_builtin_in_prover_input_info (#2138) * add relocate trace flag to the runner * remove prover input info struct and add getters instead (#2149) * Use_BTreeMap_in_pie_additional_data (#2162) --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: yuvalsw <[email protected]> Co-authored-by: YairVaknin-starkware <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]>

* Add starkware-development to CI (like another main) (#2025) * Keep None memory cells for the prover input info (#2021) * CI: Fix cache not found error (#2026) * Fix flow notation * Fix dependency * Remove dependancy in cairo pie when collectiog builtin segments info (#2022) * Add Commit Signing section (#2019) * Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> * use btreemap instead of hashmap for deterministic iteration order. (#2023) * fill holes is builtins segments * fill holes is builtins segments * Added hints felt unpacking for blake (#2032) This PR is an as-is copy of AlonT's PR pushed to a fork repo. * add prover input info flag to vm-cli * set disable trace padding for prover input info * Add_perp_and_dex_w_bitwise_layouts (#2067) * Fix_zero_offset_output_base_assumption (#2068) * add flag to serialize prover input info into binary files * Use_btreemap_for_deterministic_order_of_pie_keys (#2085) * [BREAKING] Compute_missing_builtin_cells_only_in_proof_mode (#2088) * move prover input info to a new seperate file (#2079) * add trace not enabled error * add test to filling holes (#2087) * memory comparision test only for non proof mode cases * Sync with main (#2116) * Remove duplicated `get_val` (#2065) * avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file * CI: Make cache keys depend on Cairo version (#2056) * Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * dev: make Memory::get `pub` (#2039) * dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests * feat(breaking): add support for hint accessible scopes (#2042) * feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * feat: add support for alias identifiers destination in program serde (#2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]> * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils (#2062) * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * docs: add --run_from_cairo_pie documentation for Cairo 0 and Cairo 1 (#2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * Fix WRITE_DIVMOD_SEGMENT hint (#2078) * Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md * Bump cairo-lang to 0.13.5 (#1959) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature * Prepare for Release v3.0.0-rc.1 (#2092) * Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI * fix: correct cache keys for no-std test coverage in CI (#2093) * Update rust.yml * Update rust.yml * Update rust toolchain to 1.87.0 (#2100) * update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow * fix Changelog link (#2104) * Improve memory_segments coverage (#2110) * Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments --------- Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]> * Revert "Sync with main (#2116)" (#2117) This reverts commit 7269a8f. * Bump cairo-lang to 0.13.5 (#1959) (#2118) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Enable_using_secure_run_in_proof_mode (#2113) * take ownershop instad of clone * Fixed bad submodule (#2131) * Added support for large files in PIE (#2136) * [starkware-development] Pin types-rs version to the one set in lockfile (#2142) * Update changelog * Pin types-rs version * Include_output_builtin_in_prover_input_info (#2138) * add relocate trace flag to the runner * remove prover input info struct and add getters instead (#2149) * Use_BTreeMap_in_pie_additional_data (#2162) * Update CHANGELOG for previous PR --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Stavbe <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: yuvalsw <[email protected]> Co-authored-by: YairVaknin-starkware <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]>

Stavbe changed the base branch from main to stav/fix_get_builtins_segment_in_prover_info March 24, 2025 15:38

Stavbe force-pushed the stav/use_btmap branch from 5fd0b1e to c2f648a Compare March 24, 2025 15:39

Stavbe force-pushed the stav/use_btmap branch from c2f648a to a99cca4 Compare March 24, 2025 15:48

Stavbe marked this pull request as ready for review March 24, 2025 15:49

Stavbe requested review from FrancoGiachetta, JulianGCalderon and yuvalsw March 24, 2025 15:49

Stavbe self-assigned this Mar 24, 2025

Stavbe force-pushed the stav/fix_get_builtins_segment_in_prover_info branch from fb8fa9b to 21bbb35 Compare March 25, 2025 09:31

Stavbe force-pushed the stav/use_btmap branch from a99cca4 to 409ad5d Compare March 25, 2025 09:40

DavidLevitGurevich reviewed Mar 25, 2025

View reviewed changes

yuvalsw approved these changes Mar 25, 2025

View reviewed changes

FrancoGiachetta approved these changes Mar 25, 2025

View reviewed changes

Stavbe force-pushed the stav/fix_get_builtins_segment_in_prover_info branch 2 times, most recently from 845e3e0 to b2a9287 Compare March 25, 2025 17:20

Stavbe force-pushed the stav/use_btmap branch from 409ad5d to 738afa4 Compare March 25, 2025 17:21

JulianGCalderon requested changes Mar 25, 2025

View reviewed changes

Stavbe force-pushed the stav/fix_get_builtins_segment_in_prover_info branch 2 times, most recently from 130c1dc to 9ce2f47 Compare March 26, 2025 09:50

Stavbe force-pushed the stav/use_btmap branch from 738afa4 to db1d354 Compare March 26, 2025 09:52

Stavbe commented Mar 26, 2025

View reviewed changes

JulianGCalderon approved these changes Mar 26, 2025

View reviewed changes

Stavbe changed the base branch from stav/fix_get_builtins_segment_in_prover_info to main March 26, 2025 14:47

Stavbe force-pushed the stav/use_btmap branch 2 times, most recently from 15a1f92 to d413702 Compare March 26, 2025 16:59

Stavbe commented Mar 26, 2025

View reviewed changes

use btreemap instead of hashmap for deterministic iteration order.

0f78168

Stavbe force-pushed the stav/use_btmap branch from d413702 to 0f78168 Compare March 27, 2025 08:43

Stavbe enabled auto-merge March 27, 2025 08:48

Stavbe added this pull request to the merge queue Mar 27, 2025

Merged via the queue into main with commit 60e6f24 Mar 27, 2025
93 checks passed

Stavbe deleted the stav/use_btmap branch March 27, 2025 09:51

Stavbe added a commit that referenced this pull request Mar 27, 2025

use btreemap instead of hashmap for deterministic iteration order. (#…

92e3188

…2023)

Stavbe added a commit that referenced this pull request Apr 3, 2025

use btreemap instead of hashmap for deterministic iteration order. (#…

94c0946

…2023)

enitrat pushed a commit to kkrt-labs/cairo-vm that referenced this pull request Apr 22, 2025

use btreemap instead of hashmap for deterministic iteration order. (l…

91b0618

…ambdaclass#2023)

enitrat pushed a commit to kkrt-labs/cairo-vm that referenced this pull request May 6, 2025

use btreemap instead of hashmap for deterministic iteration order. (l…

4d54578

…ambdaclass#2023)

gabrielbosio pushed a commit that referenced this pull request May 21, 2025

use btreemap instead of hashmap for deterministic iteration order. (#…

5b1a43c

…2023)

gabrielbosio pushed a commit that referenced this pull request Jul 31, 2025

use btreemap instead of hashmap for deterministic iteration order. (#…

becfd0a

…2023)

gabrielbosio pushed a commit that referenced this pull request Jul 31, 2025

use btreemap instead of hashmap for deterministic iteration order. (#…

805565b

…2023)

gabrielbosio pushed a commit that referenced this pull request Jul 31, 2025

use btreemap instead of hashmap for deterministic iteration order. (#…

7f48dae

…2023)

		* fix: Updated the logic for collecting builtin segment data for prover input info, removing dependency on the existence of stop pointers. [#2022](https://github.com/lambdaclass/cairo-vm/pull/2022)

Stav/use btmap #2023

Stav/use btmap #2023

Conversation

Stavbe commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use Btreemap instead of hashmap

Description

Checklist

Uh oh!

github-actions bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DavidLevitGurevich left a comment

Choose a reason for hiding this comment

Uh oh!

yuvalsw left a comment

Choose a reason for hiding this comment

Uh oh!

JulianGCalderon Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Stavbe Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

Stavbe left a comment

Choose a reason for hiding this comment

Uh oh!

Stavbe Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

JulianGCalderon left a comment

Choose a reason for hiding this comment

Uh oh!

Stavbe left a comment

Choose a reason for hiding this comment

Uh oh!

JulianGCalderon commented Mar 26, 2025

Uh oh!

JulianGCalderon commented Mar 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Stavbe commented Mar 24, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading

codecov bot commented Mar 24, 2025 •

edited

Loading