Revert squashed starkware-development commit

[gabrielbosio]

#2153 was accidentaly squash merged. This PR reverts that change. Once this PR is merged we have to open a PR for the same branch than #2153 so that we include the full commit history in main with a merge commit. Then we should also merge the branch of #2168 again.

[github-actions]

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.342 s ±  0.009 s    [User: 23.465 s, System: 0.872 s]
  Range (min … max):   24.335 s … 24.348 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     25.651 s ±  0.018 s    [User: 24.844 s, System: 0.805 s]
  Range (min … max):   25.639 s … 25.664 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.05 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.280 s ±  0.077 s    [User: 23.740 s, System: 0.848 s]
  Range (min … max):   13.225 s … 13.334 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.346 s ±  0.005 s    [User: 25.080 s, System: 0.835 s]
  Range (min … max):   14.342 s … 14.350 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.08 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.234 s ±  0.330 s    [User: 35.834 s, System: 1.061 s]
  Range (min … max):   10.001 s … 10.467 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.894 s ±  0.011 s    [User: 37.482 s, System: 1.016 s]
  Range (min … max):   10.886 s … 10.902 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.06 ± 0.03 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.238 s ±  0.003 s    [User: 35.935 s, System: 1.084 s]
  Range (min … max):   10.236 s … 10.240 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.228 s ±  0.009 s    [User: 37.964 s, System: 1.033 s]
  Range (min … max):   10.222 s … 10.235 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.891 s ±  0.138 s    [User: 36.354 s, System: 1.133 s]
  Range (min … max):    9.793 s …  9.988 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.299 s ±  0.099 s    [User: 38.326 s, System: 1.040 s]
  Range (min … max):   10.229 s … 10.369 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.04 ± 0.02 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.074 s ±  0.067 s    [User: 36.771 s, System: 1.211 s]
  Range (min … max):   10.027 s … 10.121 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.472 s ±  0.060 s    [User: 38.829 s, System: 1.135 s]
  Range (min … max):   10.430 s … 10.514 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.04 ± 0.01 times faster than hyper_threading_pr threads: 16

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.033 ± 0.007	2.024	2.045	1.00
head big_factorial	2.099 ± 0.012	2.083	2.128	1.03 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	1.963 ± 0.014	1.951	1.997	1.00
head big_fibonacci	2.034 ± 0.008	2.023	2.048	1.04 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	6.970 ± 0.024	6.941	7.019	1.00
head blake2s_integration_benchmark	7.763 ± 0.046	7.694	7.862	1.11 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.086 ± 0.009	2.074	2.099	1.00
head compare_arrays_200000	2.153 ± 0.009	2.143	2.173	1.03 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.402 ± 0.008	1.391	1.417	1.00
head dict_integration_benchmark	1.406 ± 0.004	1.400	1.414	1.00 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.168 ± 0.006	1.163	1.184	1.00
head field_arithmetic_get_square_benchmark	1.225 ± 0.006	1.218	1.231	1.05 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	7.127 ± 0.115	7.048	7.436	1.00
head integration_builtins	7.891 ± 0.082	7.842	8.122	1.11 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	7.140 ± 0.024	7.109	7.176	1.00
head keccak_integration_benchmark	8.034 ± 0.034	7.985	8.105	1.13 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.077 ± 0.044	2.051	2.195	1.00
head linear_search	2.132 ± 0.007	2.126	2.153	1.03 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.455 ± 0.004	1.449	1.464	1.00
head math_cmp_and_pow_integration_benchmark	1.472 ± 0.004	1.464	1.479	1.01 ± 0.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.408 ± 0.004	1.402	1.415	1.00
head math_integration_benchmark	1.439 ± 0.020	1.425	1.479	1.02 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.173 ± 0.004	1.168	1.179	1.00
head memory_integration_benchmark	1.193 ± 0.004	1.187	1.198	1.02 ± 0.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.480 ± 0.005	1.475	1.489	1.00
head operations_with_data_structures_benchmarks	1.560 ± 0.007	1.549	1.575	1.05 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	515.7 ± 2.5	513.8	522.7	1.00
head pedersen	525.7 ± 2.7	523.3	532.8	1.02 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base poseidon_integration_benchmark	598.6 ± 8.7	589.2	620.3	1.00
head poseidon_integration_benchmark	613.3 ± 5.8	605.6	622.8	1.02 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	1.752 ± 0.007	1.743	1.762	1.00
head secp_integration_benchmark	1.827 ± 0.008	1.819	1.845	1.04 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base set_integration_benchmark	616.0 ± 2.6	613.9	622.7	1.00
head set_integration_benchmark	668.1 ± 4.9	660.2	673.8	1.08 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	3.988 ± 0.009	3.977	4.002	1.00
head uint256_integration_benchmark	4.266 ± 0.041	4.221	4.359	1.07 ± 0.01

[codecov]

Codecov Report

❌ Patch coverage is 96.57534% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.67%. Comparing base (bf8967a) to head (92b40ef).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
vm/src/cairo_run.rs	72.72%	3 Missing ⚠️
vm/src/vm/runners/cairo_runner.rs	97.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
- Coverage   96.67%   96.67%   -0.01%     
==========================================
  Files         103      103              
  Lines       43944    43568     -376     
==========================================
- Hits        42483    42118     -365     
+ Misses       1461     1450      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[JulianGCalderon]

LGTM!