The Doc update for ScheduleDaemonSetPods #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for kubernetes-io-vnext-staging processing. Built with commit 7823131 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b2957180733d534bb9a15ac |
k8s-ci-robot
added
size/M
k82cn
commented
May 31, 2018
| - `node.kubernetes.io/disk-pressure` | ||
| - `node.kubernetes.io/memory-pressure` | ||
| - `node.kubernetes.io/unschedulable` (after version 1.10) |
There was a problem hiding this comment.
The PR is merged in 1.10, although the doc is update in 1.11 :(
|
This is not a 1.11 feature, so please just open this PR against |
|
Nevermind, got clarification. Thanks! |
tengqm
reviewed
Jun 1, 2018
| @@ -93,6 +93,7 @@ different Kubernetes components. | |||
| | `TokenRequest` | `false` | Alpha | 1.10 | | | |||
| | `VolumeScheduling` | `false` | Alpha | 1.9 | 1.9 | | |||
| | `VolumeScheduling` | `true` | Beta | 1.10 | | | |||
| | `ScheduleDaemonSetPods` | `false` | Alpha | 1.11 | | | |||
There was a problem hiding this comment.
- version incorrect
- mind the alpha-beta order
- provide a short description for the gate
| if the alpha feature `TaintNodesByCondition` is enabled. | ||
|
|
||
| Also note that the `node-role.kubernetes.io/master` `NoSchedule` toleration specified in the above example | ||
| is needed in version 1.6 or later to schedule on *master* nodes, because this is not a default toleration. |
There was a problem hiding this comment.
are you sure we want to mention things that old?
k82cn
force-pushed
the
kep548_doc
branch
2 times, most recently
from
111766b
to
0923e72
Compare
|
I rebased to resolve conflicts. |
bsalamat
reviewed
Jun 4, 2018
| @@ -106,6 +108,39 @@ when the Pod is created, so it is ignored by the scheduler). Therefore: | |||
| - The DaemonSet controller can make Pods even when the scheduler has not been started, which can help cluster | |||
| bootstrap. | |||
|
|
|||
| ### Scheduled by default scheduler (with ScheduleDaemonSetPods alpha feature) | |||
|
|
|||
| In version 1.10, `ScheduleDaemonSetPods` was introduced as an alpha feature. With this feature, | |||
There was a problem hiding this comment.
Should this be 1.11? I guess we could not enable the feature in 1.10.
| In version 1.11, `ScheduleDaemonSetPods` was introduced as an alpha feature. With this feature, | ||
| DaemonSet Pods are scheduled by default scheduler, instead of Daemonset controller. | ||
|
|
||
| When this feature is enabled, the `NodeAffinity` term (instead of `.spec.nodeName`) is added to the DaemonSet Pods, |
There was a problem hiding this comment.
Please add that when the feature is enabled, DS controller creates all DS pods upfront no matter whether they can be scheduled right away or not.
| ### Scheduled by default scheduler (with ScheduleDaemonSetPods alpha feature) | ||
|
|
||
| In version 1.11, `ScheduleDaemonSetPods` was introduced as an alpha feature. With this feature, | ||
| DaemonSet Pods are scheduled by default scheduler, instead of Daemonset controller. |
There was a problem hiding this comment.
s/Daemonset/DaemonSet/
to be consistent with the rest of the doc
| `TaintNodesByCondition` must be enabled. | ||
|
|
||
| When this feature and `TaintNodesByCondition` are enabled together, `node.kubernetes.io/network-unavailable:NoSchedule` | ||
| toleration is required to DaemonSet pods that using host network. |
There was a problem hiding this comment.
This sentence is unclear. Could you please rephrase?
There was a problem hiding this comment.
Something like this: When this feature and TaintNodesByCondition are enabled together, if DaemonSet uses host network, node.kubernetes.io/network-unavailable:NoSchedule toleration is required. ?
There was a problem hiding this comment.
Will DaemonSet controller add this toleration automatically when both features are enabled? If not, we'd break users when both features become beta.
There was a problem hiding this comment.
Yes, that's true. DaemonSet controller should add this toleration automatically to keep behaviour consistent. I'll open an PR for this :)
k8s-ci-robot
added
size/L
k8s-ci-robot
added
size/M
7 tasks
|
@MistyHacks, thanks, t he copyedit LGTM :), |
|
Is this ready to go now? |
janetkuo
reviewed
Jun 19, 2018
| That introduces the following issues: | ||
|
|
||
| * A DaemonSet cannot respect a Node’s resource changes, such as the node | ||
| having more free resources after other Pods exit ([#46935](https://github.com/kubernetes/kubernetes/issues/46935) |
There was a problem hiding this comment.
Remove this as this isn't directly related.
| * Inconsistent Pod behavior: Normal Pods waiting to be scheduled are created | ||
| and in `Pending` state, but DaemonSet pods are not created in `Pending` | ||
| state. This is confusing to the user. | ||
| * With preemption, different components, such as DaemonSets and the default |
There was a problem hiding this comment.
It'd be helpful to link to the preemption doc, such as this one: https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/
| state. This is confusing to the user. | ||
| * With preemption, different components, such as DaemonSets and the default | ||
| scheduler, may make different preemption decisions, which can cause | ||
| unexpected behaviorss. |
There was a problem hiding this comment.
Rephrase it to:
- Pod preemption is handled solely by default scheduler. Therefore, when preemption is enabled, the DaemonSet controller will make scheduling decisions without considering pod priority and preemption.
|
Done, @MistyHacks, please help to review the latest commit :) |
janetkuo
approved these changes
Jun 19, 2018
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Tech review is done. You may want to squash commits. |
|
/retest |
Signed-off-by: Da K. Ma <[email protected]>
k8s-ci-robot
removed
the
lgtm
|
I squashed and fixed a missing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mistyhacks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
@MistyHacks , thanks very much for your help, you're so nice :) |
mdlinville
pushed a commit
that referenced
this pull request
Jun 20, 2018
Signed-off-by: Da K. Ma <[email protected]>
mdlinville
pushed a commit
that referenced
this pull request
Jun 27, 2018
Signed-off-by: Da K. Ma <[email protected]>
mdlinville
pushed a commit
that referenced
this pull request
Jun 27, 2018
Signed-off-by: Da K. Ma <[email protected]>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jun 27, 2018
* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <[email protected]> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <[email protected]> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <[email protected]> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <[email protected]> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <[email protected]> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <[email protected]> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <[email protected]> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <[email protected]> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <[email protected]> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <[email protected]> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <[email protected]> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <[email protected]> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <[email protected]> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md
|
/sig apps |
k8s-ci-robot
added
sig/apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Da K. Ma [email protected]