StorageObjectInUseProtection is GA #8291

tengqm · 2018-05-03T05:47:49Z

Update feature gate reference for 1.11

xref: kubernetes/kubernetes#62870

k8sio-netlify-preview-bot · 2018-05-03T05:49:59Z

Deploy preview for kubernetes-io-vnext-staging ready!

Built with commit ed15ce6

https://deploy-preview-8291--kubernetes-io-vnext-staging.netlify.com

Bradamant3 · 2018-05-04T23:07:38Z

/retest

zacharysarah · 2018-05-11T18:47:42Z

/cc @mistyhacks

mdlinville · 2018-05-16T22:36:46Z

The underlying structure of the docs repository has changed due to the recent
Hugo migration. Specifically, all the files previously under docs/ are now in
content/en/docs/. I have rebased your PR without changing any of your work, so
that your changes are modifying the affected files in the new location, so this
PR is now reviewable again.

If you were using Github's web UI rather than a local Git client, you can stop
reading and continue working in this PR.

If you use the Git command-line client, you will need to make sure your local
branch is up to date with your fork. If you have local commits that have not
been pushed to your fork, it may be complicated to get them back. Do git log
and note their commit hashes for later.

Assuming your your fork's remote is called origin, hard-reset your local
branch to be the same as your fork's branch:

git fetch origin; git reset --hard origin/storage-protection-gate

If you didn't have local commits, you're now ready to keep working on this PR
locally. You can stop reading now.

If you did have local commits, cherry-pick them from oldest to newest. For
each commit that needs to be cherry-picked:

git cherry-pick <HASH>

You will need to resolve conflicts in these cherry-picked commits, which
involves moving your modified files into the correct new location. All the
content in docs/ moved to content/en/docs/, so you can move your local files
accordingly:

Do git add for each of the moved files
Do git mergetool and accept the
deleted rather than modified file
Continue the cherry-pick by doing git cherry-pick --continue

When you've cherry-picked all local commits back onto the local branch, push the
branch (with new commits) to your fork. You should not need to force the push.

mdlinville

A few changes due to the Hugo migration.

mdlinville · 2018-05-16T22:37:15Z

content/en/docs/reference/feature-gates.md

 This page contains an overview of the various feature gates an administrator
 can specify on different Kubernetes components.
-{{% /capture %}}
+{% endcapture %}


/assign @chenopis

I'm not sure the right way to do this in Hugo yet.

Verified that the way in red in line 9 is the new right way, so please revert these back to the Hugo way.

mdlinville · 2018-05-16T22:37:45Z

content/en/docs/reference/feature-gates.md

 **Note:** Please do try *Beta* features and give feedback on them!
 After they exit beta, it may not be practical for us to make more changes.
-{{< /note >}}
+{: .note}


Please revert this to use the Hugo short-code syntax (as shown in the red lines 123 and 126).

mdlinville · 2018-05-17T20:57:39Z

I was wrong about the need to change /docs/ to /content/en/docs/ so you can ignore the request to do that. The things about Hugo shortcodes still need to be addressed.

mdlinville · 2018-05-17T21:19:00Z

content/en/docs/reference/feature-gates.md

@@ -1,14 +1,13 @@
 ---
 title: Feature Gates
-content_template: templates/concept


This needs to be reverted.

mdlinville · 2018-05-17T21:19:22Z

content/en/docs/reference/feature-gates.md

 This page contains an overview of the various feature gates an administrator
 can specify on different Kubernetes components.
-{{% /capture %}}
+{% endcapture %}


Verified that the way in red in line 9 is the new right way, so please revert these back to the Hugo way.

Update feature gate reference for 1.11

mdlinville

/lgtm

Let's see how to get Netlify to re-run so we can see the result of this change.

mdlinville · 2018-05-22T00:43:46Z

/assign @chenopis
Can you help me figure out why Netlify is not running?

Bradamant3 · 2018-05-23T00:59:07Z

Because @mistyhacks already gave the real lgtm and bc we've figured out the Netlify problem isn't with this PR (preview looks fine):

/lgtm
/approve

k8s-ci-robot · 2018-05-23T00:59:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Bradamant3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment