-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with k8s.io/docs/concepts/workloads/controllers/daemonset/ #17336
Comments
Digging into this it looks like this paragraph does need updating. This paragraph was introduced in 1.11 via #8842 and the headings (enabled/disabled by default) were introduced separately in 1.12 via #9923 without updating the subsequent paragraph under the heading (this was when DaemonSet Controller was the default but then switched over to default scheduler). That's why there is a disconnect in the language being used and what the default behavior is. Introduction paragraph in https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/#scheduled-by-default-scheduler-enabled-by-default-since-1-12 should be updated to reflect the true default behavior. |
/assign |
/priority important-longterm |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a Bug Report
Problem:
"A DaemonSet ensures that all eligible nodes run a copy of a Pod. Normally, the node that a Pod runs on is selected by the Kubernetes scheduler. However, DaemonSet pods are created and scheduled by the DaemonSet controller instead."
This is shown as the default option for a daemonset, but just above, it says the opposite is the default behavior.
Proposed Solution:
Change the default section or change this paragraph to show the correct behavior
Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/
The text was updated successfully, but these errors were encountered: