Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPA Specificity Improvements #8757

Merged
merged 1 commit into from
Sep 4, 2018
Merged

HPA Specificity Improvements #8757

merged 1 commit into from
Sep 4, 2018

Conversation

DirectXMan12
Copy link
Contributor

This commit describes the HPA changes that went into 1.11, including
the addition of label selectors and the rework of the API.

cc kubernetes/enhancements#117
cc kubernetes/community#2055
cc kubernetes/kubernetes#64097

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 25, 2018 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 6596532

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b15766bdd6a54547c916802

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2018
@DirectXMan12
Copy link
Contributor Author

/hold
this is a placeholder as per the release requirements. Will have content shortly.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2018
@mdlinville mdlinville added this to the 1.11 milestone May 25, 2018
@mdlinville
Copy link
Contributor

Thanks, just remove the hold when you're ready for review.

@zparnold
Copy link
Member

@DirectXMan12 Hey there! Looks like we still need some docs to get this feature ready for release

Can you let me know when that’ll happen please? If there’s anything I can do to assist please let me know

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2018
@DirectXMan12
Copy link
Contributor Author

/unhold

@DirectXMan12 DirectXMan12 changed the title [placeholder] HPA Specificity Improvements HPA Specificity Improvements May 30, 2018
@DirectXMan12 DirectXMan12 mentioned this pull request May 30, 2018
Merged
@mdlinville
Copy link
Contributor

/hold cancel

👼

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2018
@mdlinville
Copy link
Contributor

@DirectXMan12 I've made two copyedit commits (one per file, for ease of review). PTAL and LGTM if good.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2018
@DirectXMan12
Copy link
Contributor Author

/hold until the corresponding k/k PR lands or does not land.

DirectXMan12
DirectXMan12 commented Jun 4, 2018
View reviewed changes
content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md Outdated
requested value. To do so, use the `target` type of `AverageValue`, and thus set `target.averageValue`
field instead of the `target.averageUtilization` field.
requested value, by using the `target` type of `AverageValue` instead of `averageUtilization`. This sets the
`target.averageValue` field instead of the `target.averageUtilization` field.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong -- it's a discriminated/tagged union (target is the tag, averageUtilization and friends are the value). You need to set target to AverageValue and then set target.averageValue yourself. This wording implies the latter gets set automatically. The original intention was

if you set target to Xyz, you must also set the xyz field

content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md Outdated
by the number of pods before being compared to the target. Object metrics look like this:
The second alternative metric type is *object metrics*. These metrics describe a different
object in the same namespace, instead of describing pods. The metrics are not
fetched from the object, but only describe it. Object metrics support `target` types of
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the but sounds weird here. I'd use

the metrics are not fetched from the object; they only describe it

or

the metrics describe the object, but are not necessarily fetched from it

@DirectXMan12
Copy link
Contributor Author

DirectXMan12 commented Jun 4, 2018 •
edited
Loading

added some comments on the copyedits

@mdlinville
Copy link
Contributor

I'm confused about the current state of this, because you commented on my edits, but your comments are now collapsed, but I don't think they were addressed. Can you let me know? Also, the Hugo shortcode thing -- I thought I fixed that and it is back wrong again. Did you force-push over my commit?

@mdlinville
Copy link
Contributor

It looks like a bit of a mess and I think some of it would be fixed by rebasing again on release-1.11.

@DirectXMan12
Copy link
Contributor Author

I didn't push anything new. The corresponding PR didn't make 1.11 due to a couple hiccups, so we'll have to rebase on 1.12 when ready ;-)

@mdlinville mdlinville removed this from the 1.11 milestone Jun 8, 2018
@mdlinville
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2018
@mdlinville mdlinville changed the title HPA Specificity Improvements WIP for 1.12 HPA Specificity Improvements Jun 12, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2018
@mdlinville mdlinville force-pushed the release-1.11 branch 2 times, most recently from 2844fcf to 30a04f8 Compare June 27, 2018 00:24
@DirectXMan12 DirectXMan12 mentioned this pull request Aug 21, 2018
Closed
7 tasks
@zacharysarah
Copy link
Contributor

@DirectXMan12 👋 Just an early heads up that merge conflicts need to be resolved before this PR can merge.

@DirectXMan12
HPA Specificity Improvements
fde92d9 
Updated the HPA docs to reference the `autoscaling/v2beta2` API version,
and added documentation about the new fields.
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 24, 2018
@DirectXMan12
Copy link
Contributor Author

I'm force-pushing this, because it looks like a merge commit was added to this PR, which has seriously messed with things. I've cherry-picked in misty's copyedits, added in my comments on the copyedits, and squashed them back down.

@DirectXMan12 DirectXMan12 changed the base branch from release-1.11 to release-1.12 August 24, 2018 15:51
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 24, 2018
@mdlinville
Copy link
Contributor

/lgtm

If it's no longer WIP, don't forget to change the title.

/hold
(for @zparnold )

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2018
@DirectXMan12 DirectXMan12 changed the title WIP for 1.12 HPA Specificity Improvements HPA Specificity Improvements Aug 24, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2018
@zparnold
Copy link
Member

zparnold commented Sep 4, 2018

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks, zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mistyhacks,zparnold]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9d84a49 into kubernetes:release-1.12 Sep 4, 2018
@DirectXMan12 DirectXMan12 deleted the feature/hpa-specificity branch September 5, 2018 17:00
detiber pushed a commit to detiber/kubernetes-website that referenced this pull request Sep 19, 2018
@DirectXMan12 @detiber
HPA Specificity Improvements (kubernetes#8757)
b73bffa 
Updated the HPA docs to reference the `autoscaling/v2beta2` API version,
and added documentation about the new fields.
k8s-ci-robot pushed a commit that referenced this pull request Sep 27, 2018
@jimangel @k8s-ci-robot
[Do Not Merge] Release 1.12 (#10292)
786d314 
* Update docs for fields allowed at root of CRD schema (#9973)

* add plugin docs and examples (#10053)

* docs update to promote TaintNodesByCondition to beta (#9626)

* HPA Specificity Improvements (#8757)

Updated the HPA docs to reference the `autoscaling/v2beta2` API version,
and added documentation about the new fields.

* adjust docs for pod ready++ (#10049)

* Remove --cadvisor-port - has been deprecated since v1.10 (#10023)

Change-Id: Id2a685473a243aef492a98ff450759f39e362557

* Add Documentation for Snapshot Feature (#9948)

* Add documentation for snapshot feature

* Update volume-snapshots.md

* Add dry-run to api-concepts (#10033)

* kubeadm-init: Update the offline support section (#10062)

The update includes the following things (in mind with Kubernetes 1.12):

- Remove the 1.8 image versions
- Add the 1.10 image versions that were missing until now
- Include a comment for the missing arch suffixes in 1.12

Signed-off-by: Rostislav M. Georgiev <[email protected]>

* Say bye to `DynamicProvisioningScheduling` (#10157)

The mentioned feature gate is now collapsed into `VolumeScheduling`.

xref: kubernetes/kubernetes#67432

* Update ResourceQuota per PriorityClass state for 1.12 (#10229)

* TokenRequest and TokenRequestProjection now beta (#10161)

xref: kubernetes/kubernetes#67349

* Change feature state for kms provider to beta. (#10230)

KMS Provider will be graduating to beta in v1.12, reflecting this change on the website.

* coredns default (#10200)

* Promote ShareProcessNamespace to beta in docs (#9996)

* Add CoreDNS details to DNS Debug docs (#10201)

* add coredns details

* address nits, add query logging section

* Update docs with topology aware dynamic provisioning (#9939)

* Document topology aware volume binding feature

* update for readability

* Update storage-classes.md

* comma splice

* don't abbreviate

* HPA Algorithm Information Improvements (#9780)

* Update HPA docs with more algorithm details

The HPA docs pointed to an out-of-date document for information on the
algorithm details, which users were finding confusing.  This sticks a
section on the algorithm in the HPA docs instead, documenting both
general behavior and corner cases.

* Add glossary info, HPA docs on quantities

People often ask about the quantity notation when working with the
metrics APIs, so this adds a glossary entry on quantities (since they're
used elsewhere in the system), and a short explantation in the HPA walkthough.

* Information about HPA readiness and stabilization

This adds information about the new changes to HPA readiness and
stabilization from kubernetes/enhancements#591, and other minor changes that
landed in Kubernetes 1.12.

* Update horizontal-pod-autoscale.md

* Audit 1.12 doc (#9953)

* audit 1.12 document

* remove legacy audit feature

kubernetes/kubernetes#65862

* update feature gate doc

* MountPropagation is now GA (#10090)

* RuntimeClass documentation (#10102)

* RuntimeClass documentation

* Update runtime-class.md

* Add documentation for Scheduler performance tuning (#10048)

* Add documentation for Scheduler performance tuning

* Update scheduler-perf-tuning.md

* TTL controller for cleaning up finished resources (#10064)

* TTL controller for cleaning up finished resources

* Address comments

* Update ttlafterfinished.md

* Bump quota configuration api version (#10217)

* Incremental update from master (#10278)

* fix invalid href of cloud controller manager (#10240)

* fix invalid yaml format (#10238)

* update storage-limits doc with Azure disk part (#10224)

update storage-limits doc with Azure disk part

fix comments

* Update kubelet-config-file.md (#10222)

Update link to KubeletConfiguration struct.

* fix a trivial misspelling (#10244)

* Fix cassandra-statefulset.yaml indent level (#10243)

* Mention minimum etcd versions (#10208)

Source: https://groups.google.com/d/msg/kubernetes-dev/jMPA4JzKiY4/HIx2ugvLBAAJ

* fix 404 error (#10250)

* Small verb tweak (#10190)

Present participle, ftw.

* Add AnchorJS logic for header links (#10155)

* Add AnchorJS JavaScript

* Remove existing inpage_heading logic

* Remove underline from anchor tags

* Use single icon and add touch visibility

* Use paragraph link icon for AnchorJS

* Update Sass to use code formatting in docsContent headers

* Update header size coverage to H3-H6

* fix broken link in kubefed.md (#10254)

* Update the version numbers for the X-Remote-Extra- and Impersonate-Extra- key fixes (#9827)

The fix was cherry picked into 1.11.3, 1.10.7, and 1.9.11:

kubernetes/kubernetes#67162
kubernetes/kubernetes#67163
kubernetes/kubernetes#67164

* fix typo (#10168)

* fix typo

* addressing comments.

* Update setup-ha-etcd-with-kubeadm.md

* fix typos (#10252)

* fix description of contribute guide (#10253)

* describe truncate feature about advanced audit (#10236)

* describe truncate feature about advanced audit

* Update audit.md

* docs update to promote ScheduleDaemonSetPods to beta (#9923)

* Dynamic volume limit updates for 1.12 (#10211)

* add a placeholder commit

* Update docs for csi volume limits

* Update storage-limits.md

* Add "MayRunAs" value among other GroupStrategies (#9888)

* Add CoreDNS details to the customize DNS doc (#10228)

* Add CoreDNS details to the customize DNS doc

Rewrite the document to include more details about CoreDNS, since it's now the default from v1.12

* Address comments

* Improve doc wording

* Fix link

* Update dns-custom-nameservers.md

* Update dns-custom-nameservers.md

* Fix secrets docs in 1.12 branch (#10056)

* Fix secrets docs

* Update secret.md

* Revert CoreDNS Docs (#10319)

* Revert "Add CoreDNS details to DNS Debug docs (#10201)"

This reverts commit 462817a.

* Revert "Add CoreDNS details to the customize DNS doc (#10228)"

This reverts commit e7319ee.

* Revert "coredns default (#10200)"

This reverts commit 698e93b.

* Add CRI installation instructions page

Added cri-installation page with CRI installation instructions
Referenced it from kubeadm-init and install-kubeadm pages.

* kubeadm: update API types documentation for 1.12 (#10283)

v1alpha2 -> v1alpha3
MasterConfiguration -> [new-api-types]

* TokenRequest feature documentation (#10295)

* AdvancedAuditing is now GA (#10156)

xref: kubernetes/kubernetes#65862

`AdvancedAuditing` feature is GA in 1.12. This PR adjusts the related
docs.

* update runtime-class.md (#10332)

* update runtime-class.md

* Update runtime-class.md

* Document cross-authorizer permissions for creating RBAC roles (#10015)

* Document cross-authorizer permissions for creating RBAC roles

* Update rbac.md

* kubeadm: update authored content for 1.12 (reference docs and cluster creation) (#10348)

* kubeadm: update authored content in reference docs for 1.12

* kubeadm: add time frame in create-cluster-kubeadm for 1.12

* add AllowedProcMountTypes and ProcMountType to docs (#9911)

Signed-off-by: Jess Frazelle <[email protected]>

* kubeadm: add new command line reference (#10306)

Add:
- placeholder files
- include place holder files
- include "renew" sub command
- add missing tabs for "alpha phase kubelet"

* Documenting SCTP support in Kubernetes (#10279)

* Documenting SCTP support in Kubernetes Service, Endpoint, NetworkPolicy and Pod

* Updates based on comments on the PR

* kubectl expose update with SCTP support

* Updated according to comments in the PR

* Revert "kubectl expose update with SCTP support"

This reverts commit 0d5a1e6.

* TLS Bootstrap and Server Cert Rotation feature documentation (#10232)

* TokenRequest feature documentation

* line wrapping to make review not insane

* update content for GA without major refactor

* Update kubelet-tls-bootstrapping.md

* Add clarifications for volume snapshots (#10296)

* Update kubadm ha installation for 1.12 (#10264)

* Update kubadm ha installation for 1.12

Signed-off-by: Chuck Ha <[email protected]>

* update stable version

Signed-off-by: Chuck Ha <[email protected]>

* Update stacked control plane for v1.12 (#2)

* use v1alpha3

Signed-off-by: Chuck Ha <[email protected]>

* more v1alpha3 (#4)

* updates

Signed-off-by: Chuck Ha <[email protected]>

* Document how to run in-tree cloud providers with kubeadm (#10357)

Change-Id: Iab6b996a830503d74a6eb0c507c5f8ca7a39235b

* kubeadm reference doc for release 1.12 (#10359)

* Revert "Revert "Add CoreDNS details to DNS Debug docs (#10201)""

This reverts commit bb30f4d.

* Revert "Revert "Add CoreDNS details to the customize DNS doc (#10228)""

This reverts commit bc23d45.

* Revert "Revert "coredns default (#10200)""

This reverts commit 7f4350d.

* add missing instruction for ha guide (#10374)

Signed-off-by: Chuck Ha <[email protected]>

* kubeadm - Ha upgrade updates (#10340)

* Update HA upgrade docs

* Adds external etcd HA upgrade guide

Signed-off-by: Chuck Ha <[email protected]>

* copyedit

* more edits

* add runasgroup in psp (#10076)

* update KubeletPluginsWatcher feature gate (#10205)

* generated 1.12 docs

* Building Multi-arch images with Manifests (#10379)

In 1.12, a variety of images used in a typical kubernetes installation
have started to using manifests to better support environments with arm
or ppc64le architectures. For example all images used with kubeadm by
default have manifests, another would be all the tests in the
conformance test suite. Here we capture the best practices for everyone
to start using manifests in their own workflows.

Change-Id: I5ba4c5fe55ffc9486a8251760f3352be4f2e1494

* Upgrade docs for v1.12 (#10344)

* generated assets and docs

* remove 1.7

* update 1.12

* update plugin documentation under docs>tasks>extend-kubectl (#10259)

* update plugin documentation under docs>tasks>extend-kubectl

* Update kubectl-plugins.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgrzadkowski fgrzadkowski Awaiting requested review from fgrzadkowski

@jszczepkowski jszczepkowski Awaiting requested review from jszczepkowski

Assignees

@mdlinville mdlinville

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.
6 participants
@DirectXMan12 @k8sio-netlify-preview-bot @mdlinville @zparnold @zacharysarah @k8s-ci-robot