Add CoreDNS details to the customize DNS doc #10228

rajansandeep · 2018-09-07T17:01:46Z

Rewrite the document to include more details about CoreDNS, since it's now the default from v1.12

k8sio-netlify-preview-bot · 2018-09-07T17:01:49Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 99cd887

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b92aefb1f12b7427c72597a

k8sio-netlify-preview-bot · 2018-09-07T17:03:06Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 077d285

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b9aa0dfb13fb10b0e5e1a86

rajansandeep · 2018-09-07T17:16:57Z

@johnbelamaric @chrisohaver @fturib PTAL

chrisohaver · 2018-09-07T17:19:34Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

@@ -28,40 +28,158 @@ DNS is a built-in Kubernetes service launched automatically
 using the addon manager
 [cluster add-on](http://releases.k8s.io/{{< param "githubbranch" >}}/cluster/addons/README.md).

-The running DNS Pod holds 3 containers:
+Following Kubernetes v1.12, CoreDNS is declared the default DNS Server instead of kube-dns in kubeadm. You may want to refer


This happened in 1.11 in kubeadm, right?

Aah yes, it is in 1.11 for kubeadm. Should I drop kubeadm here?

"instead of kube-dns. In kubeadm, this change was made in Kubernetes 1.11, but other installers have waited until 1.12. You should refer..."

johnbelamaric · 2018-09-07T18:13:19Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md


 When running a Pod, kubelet prepends the cluster DNS server and searches
 paths to the node's DNS settings.  If the node is able to resolve DNS names
 specific to the larger environment, Pods should also be able to resolve.
-But see [Known issues](/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues).
+But see [Known issues](https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues).


I think this was intentionally a relative URL, wasn't it. It should match what other links do (so should your link above).

johnbelamaric · 2018-09-07T18:15:29Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

-## Configure stub-domain and upstream DNS servers
+## CoreDNS
+
+CoreDNS is a flexible, extensible, authoritative DNS server which directly integrates with the Kubernetes API. 


I think this is a little too marketing-y for this doc.

I would just say:

CoreDNS is a general-purpose authoritative DNS-server that can serve as cluster DNS, complying with...

We already introduce coredns and what it is in another introductory document. I don't think we need to reintroduce it every time we mention it. Perhaps we should instead link to that doc from here.

johnbelamaric · 2018-09-07T18:16:39Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

+This can be configured by maintaining a [Corefile](https://coredns.io/2017/07/23/corefile-explained/), which is the CoreDNS
+configuration file. You can modify the ConfigMap for the CoreDNS Corefile to change how service discovery works. 
+
+Currently, CoreDNS carries the following default Corefile configuration.


s/Currently, CoreDNS carries/In Kubernetes, CoreDNS is installed with/

johnbelamaric · 2018-09-07T18:17:10Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

+* [health](https://coredns.io/plugins/health/): Health of CoreDNS is reported to http://localhost:8080/health.
+* [kubernetes](https://coredns.io/plugins/kubernetes/): CoreDNS will reply to DNS queries based on IP of the services and pods of Kubernetes. You can find more details [here](https://coredns.io/plugins/kubernetes/). 
+
+> The `pods insecure` option is provided for backward compatibility with kube-dns. You can use the `pod verified` option, which returns an A record only if there exists a pod in same namespace with matching IP.


Or pods disabled if you don't use pod records.

johnbelamaric · 2018-09-07T18:17:44Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

+
+### Configuration of Stub-domain and upstream nameserver using CoreDNS
+
+CoreDNS has the ability to configure stubdomains and upstream nameservers using the [proxy plugin](https://coredns.io/plugins/proxy/). 


Probably we should recommend forward instead.

We still use proxy in the default manifest.

johnbelamaric

Some tweaks

zparnold · 2018-09-10T03:10:05Z

@rajansandeep @chrisohaver @johnbelamaric Is this in a place where it's ready for my final review?

rajansandeep · 2018-09-10T19:03:47Z

@zparnold Yes, this is ready for final review.

chrisohaver · 2018-09-10T19:42:02Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

@@ -28,28 +28,22 @@ DNS is a built-in Kubernetes service launched automatically
 using the addon manager
 [cluster add-on](http://releases.k8s.io/{{< param "githubbranch" >}}/cluster/addons/README.md).

-The running DNS Pod holds 3 containers:
+Following Kubernetes v1.12, CoreDNS is declared the default DNS Server instead of kube-dns. In kubeadm, this change was made


"Following Kubernetes v1.12, CoreDNS is declared the default DNS Server instead of kube-dns. In kubeadm, this change was made in Kubernetes 1.11, but other installers have waited until 1.12. You should refer to the documentation of other installers to verify which is the default DNS server."

Perhaps change this to ...

"As of Kubernetes v1.12, CoreDNS is the recommended DNS Server, replacing kube-dns. However, kube-dns may still be installed by default with certain Kubernetes installer tools. You can refer to the documentation your installer to know which DNS server is installed by default."

chrisohaver · 2018-09-10T19:45:52Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

-
-## Inheriting DNS from the node
+The DNS server supports forward lookups (A records), service lookups (SRV records), and reverse IP address lookups (PTR
+records) as per the [DNS specifications] (/docs/concepts/services-networking/dns-pod-service/)


This link differs from the linked "DNS specifications" below. I think this link here is to general DNS Docs, and the link below is to the actual specifications. Slightly confusing that the links share the same title in this document.

Maybe rephrase here to ...

The DNS server provides name resolution for services and pods including forward lookups (A records), port lookups (SRV records), and reverse IP address lookups (PTR records). For more information see [DNS for Services and Pods] (/docs/concepts/services-networking/dns-pod-service/).

chrisohaver · 2018-09-10T19:47:31Z

content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md

+        loadbalance
+    }
+``` 
+The Corefile configuration is based on the following [plugins](https://coredns.io/plugins/) of CoreDNS:


"is based on" => "includes"

zparnold · 2018-09-13T04:35:03Z

@rajansandeep can you please address @chrisohaver 's concerns, and then I can review

rajansandeep · 2018-09-13T12:58:11Z

/assign @zparnold
I've addressed all concerns.

zparnold · 2018-09-13T15:22:16Z

Thanks! I'll take a look. 😄

zparnold · 2018-09-13T17:40:01Z

/lgtm
/approve

k8s-ci-robot · 2018-09-13T17:40:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zparnold]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This reverts commit e7319ee.

* Revert "Add CoreDNS details to DNS Debug docs (#10201)" This reverts commit 462817a. * Revert "Add CoreDNS details to the customize DNS doc (#10228)" This reverts commit e7319ee. * Revert "coredns default (#10200)" This reverts commit 698e93b.

This reverts commit bc23d45.

* Update docs for fields allowed at root of CRD schema (#9973) * add plugin docs and examples (#10053) * docs update to promote TaintNodesByCondition to beta (#9626) * HPA Specificity Improvements (#8757) Updated the HPA docs to reference the `autoscaling/v2beta2` API version, and added documentation about the new fields. * adjust docs for pod ready++ (#10049) * Remove --cadvisor-port - has been deprecated since v1.10 (#10023) Change-Id: Id2a685473a243aef492a98ff450759f39e362557 * Add Documentation for Snapshot Feature (#9948) * Add documentation for snapshot feature * Update volume-snapshots.md * Add dry-run to api-concepts (#10033) * kubeadm-init: Update the offline support section (#10062) The update includes the following things (in mind with Kubernetes 1.12): - Remove the 1.8 image versions - Add the 1.10 image versions that were missing until now - Include a comment for the missing arch suffixes in 1.12 Signed-off-by: Rostislav M. Georgiev <[email protected]> * Say bye to `DynamicProvisioningScheduling` (#10157) The mentioned feature gate is now collapsed into `VolumeScheduling`. xref: kubernetes/kubernetes#67432 * Update ResourceQuota per PriorityClass state for 1.12 (#10229) * TokenRequest and TokenRequestProjection now beta (#10161) xref: kubernetes/kubernetes#67349 * Change feature state for kms provider to beta. (#10230) KMS Provider will be graduating to beta in v1.12, reflecting this change on the website. * coredns default (#10200) * Promote ShareProcessNamespace to beta in docs (#9996) * Add CoreDNS details to DNS Debug docs (#10201) * add coredns details * address nits, add query logging section * Update docs with topology aware dynamic provisioning (#9939) * Document topology aware volume binding feature * update for readability * Update storage-classes.md * comma splice * don't abbreviate * HPA Algorithm Information Improvements (#9780) * Update HPA docs with more algorithm details The HPA docs pointed to an out-of-date document for information on the algorithm details, which users were finding confusing. This sticks a section on the algorithm in the HPA docs instead, documenting both general behavior and corner cases. * Add glossary info, HPA docs on quantities People often ask about the quantity notation when working with the metrics APIs, so this adds a glossary entry on quantities (since they're used elsewhere in the system), and a short explantation in the HPA walkthough. * Information about HPA readiness and stabilization This adds information about the new changes to HPA readiness and stabilization from kubernetes/enhancements#591, and other minor changes that landed in Kubernetes 1.12. * Update horizontal-pod-autoscale.md * Audit 1.12 doc (#9953) * audit 1.12 document * remove legacy audit feature kubernetes/kubernetes#65862 * update feature gate doc * MountPropagation is now GA (#10090) * RuntimeClass documentation (#10102) * RuntimeClass documentation * Update runtime-class.md * Add documentation for Scheduler performance tuning (#10048) * Add documentation for Scheduler performance tuning * Update scheduler-perf-tuning.md * TTL controller for cleaning up finished resources (#10064) * TTL controller for cleaning up finished resources * Address comments * Update ttlafterfinished.md * Bump quota configuration api version (#10217) * Incremental update from master (#10278) * fix invalid href of cloud controller manager (#10240) * fix invalid yaml format (#10238) * update storage-limits doc with Azure disk part (#10224) update storage-limits doc with Azure disk part fix comments * Update kubelet-config-file.md (#10222) Update link to KubeletConfiguration struct. * fix a trivial misspelling (#10244) * Fix cassandra-statefulset.yaml indent level (#10243) * Mention minimum etcd versions (#10208) Source: https://groups.google.com/d/msg/kubernetes-dev/jMPA4JzKiY4/HIx2ugvLBAAJ * fix 404 error (#10250) * Small verb tweak (#10190) Present participle, ftw. * Add AnchorJS logic for header links (#10155) * Add AnchorJS JavaScript * Remove existing inpage_heading logic * Remove underline from anchor tags * Use single icon and add touch visibility * Use paragraph link icon for AnchorJS * Update Sass to use code formatting in docsContent headers * Update header size coverage to H3-H6 * fix broken link in kubefed.md (#10254) * Update the version numbers for the X-Remote-Extra- and Impersonate-Extra- key fixes (#9827) The fix was cherry picked into 1.11.3, 1.10.7, and 1.9.11: kubernetes/kubernetes#67162 kubernetes/kubernetes#67163 kubernetes/kubernetes#67164 * fix typo (#10168) * fix typo * addressing comments. * Update setup-ha-etcd-with-kubeadm.md * fix typos (#10252) * fix description of contribute guide (#10253) * describe truncate feature about advanced audit (#10236) * describe truncate feature about advanced audit * Update audit.md * docs update to promote ScheduleDaemonSetPods to beta (#9923) * Dynamic volume limit updates for 1.12 (#10211) * add a placeholder commit * Update docs for csi volume limits * Update storage-limits.md * Add "MayRunAs" value among other GroupStrategies (#9888) * Add CoreDNS details to the customize DNS doc (#10228) * Add CoreDNS details to the customize DNS doc Rewrite the document to include more details about CoreDNS, since it's now the default from v1.12 * Address comments * Improve doc wording * Fix link * Update dns-custom-nameservers.md * Update dns-custom-nameservers.md * Fix secrets docs in 1.12 branch (#10056) * Fix secrets docs * Update secret.md * Revert CoreDNS Docs (#10319) * Revert "Add CoreDNS details to DNS Debug docs (#10201)" This reverts commit 462817a. * Revert "Add CoreDNS details to the customize DNS doc (#10228)" This reverts commit e7319ee. * Revert "coredns default (#10200)" This reverts commit 698e93b. * Add CRI installation instructions page Added cri-installation page with CRI installation instructions Referenced it from kubeadm-init and install-kubeadm pages. * kubeadm: update API types documentation for 1.12 (#10283) v1alpha2 -> v1alpha3 MasterConfiguration -> [new-api-types] * TokenRequest feature documentation (#10295) * AdvancedAuditing is now GA (#10156) xref: kubernetes/kubernetes#65862 `AdvancedAuditing` feature is GA in 1.12. This PR adjusts the related docs. * update runtime-class.md (#10332) * update runtime-class.md * Update runtime-class.md * Document cross-authorizer permissions for creating RBAC roles (#10015) * Document cross-authorizer permissions for creating RBAC roles * Update rbac.md * kubeadm: update authored content for 1.12 (reference docs and cluster creation) (#10348) * kubeadm: update authored content in reference docs for 1.12 * kubeadm: add time frame in create-cluster-kubeadm for 1.12 * add AllowedProcMountTypes and ProcMountType to docs (#9911) Signed-off-by: Jess Frazelle <[email protected]> * kubeadm: add new command line reference (#10306) Add: - placeholder files - include place holder files - include "renew" sub command - add missing tabs for "alpha phase kubelet" * Documenting SCTP support in Kubernetes (#10279) * Documenting SCTP support in Kubernetes Service, Endpoint, NetworkPolicy and Pod * Updates based on comments on the PR * kubectl expose update with SCTP support * Updated according to comments in the PR * Revert "kubectl expose update with SCTP support" This reverts commit 0d5a1e6. * TLS Bootstrap and Server Cert Rotation feature documentation (#10232) * TokenRequest feature documentation * line wrapping to make review not insane * update content for GA without major refactor * Update kubelet-tls-bootstrapping.md * Add clarifications for volume snapshots (#10296) * Update kubadm ha installation for 1.12 (#10264) * Update kubadm ha installation for 1.12 Signed-off-by: Chuck Ha <[email protected]> * update stable version Signed-off-by: Chuck Ha <[email protected]> * Update stacked control plane for v1.12 (#2) * use v1alpha3 Signed-off-by: Chuck Ha <[email protected]> * more v1alpha3 (#4) * updates Signed-off-by: Chuck Ha <[email protected]> * Document how to run in-tree cloud providers with kubeadm (#10357) Change-Id: Iab6b996a830503d74a6eb0c507c5f8ca7a39235b * kubeadm reference doc for release 1.12 (#10359) * Revert "Revert "Add CoreDNS details to DNS Debug docs (#10201)"" This reverts commit bb30f4d. * Revert "Revert "Add CoreDNS details to the customize DNS doc (#10228)"" This reverts commit bc23d45. * Revert "Revert "coredns default (#10200)"" This reverts commit 7f4350d. * add missing instruction for ha guide (#10374) Signed-off-by: Chuck Ha <[email protected]> * kubeadm - Ha upgrade updates (#10340) * Update HA upgrade docs * Adds external etcd HA upgrade guide Signed-off-by: Chuck Ha <[email protected]> * copyedit * more edits * add runasgroup in psp (#10076) * update KubeletPluginsWatcher feature gate (#10205) * generated 1.12 docs * Building Multi-arch images with Manifests (#10379) In 1.12, a variety of images used in a typical kubernetes installation have started to using manifests to better support environments with arm or ppc64le architectures. For example all images used with kubeadm by default have manifests, another would be all the tests in the conformance test suite. Here we capture the best practices for everyone to start using manifests in their own workflows. Change-Id: I5ba4c5fe55ffc9486a8251760f3352be4f2e1494 * Upgrade docs for v1.12 (#10344) * generated assets and docs * remove 1.7 * update 1.12 * update plugin documentation under docs>tasks>extend-kubectl (#10259) * update plugin documentation under docs>tasks>extend-kubectl * Update kubectl-plugins.md

Add CoreDNS details to the customize DNS doc

99cd887

Rewrite the document to include more details about CoreDNS, since it's now the default from v1.12

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2018

k8s-ci-robot requested review from bowei and Rajakavitha1 September 7, 2018 17:01

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2018

chrisohaver reviewed Sep 7, 2018

View reviewed changes

johnbelamaric reviewed Sep 7, 2018

View reviewed changes

johnbelamaric suggested changes Sep 7, 2018

View reviewed changes

rajansandeep mentioned this pull request Sep 7, 2018

Switch default DNS plugin to CoreDNS kubernetes/enhancements#566

Closed

Address comments

b0e0168

chrisohaver reviewed Sep 10, 2018

View reviewed changes

Improve doc wording

4f52330

Fix link

e9e980b

chrisohaver approved these changes Sep 13, 2018

View reviewed changes

k8s-ci-robot assigned zparnold Sep 13, 2018

Update dns-custom-nameservers.md

4d74c0e

Update dns-custom-nameservers.md

077d285

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2018

k8s-ci-robot merged commit e7319ee into kubernetes:release-1.12 Sep 13, 2018

zparnold added a commit that referenced this pull request Sep 17, 2018

Revert "Add CoreDNS details to the customize DNS doc (#10228)"

bc23d45

This reverts commit e7319ee.

zparnold mentioned this pull request Sep 17, 2018

Revert CoreDNS Docs #10319

Merged

zparnold added a commit that referenced this pull request Sep 21, 2018

Revert "Revert "Add CoreDNS details to the customize DNS doc (#10228)""

045cbb1

This reverts commit bc23d45.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CoreDNS details to the customize DNS doc #10228

Add CoreDNS details to the customize DNS doc #10228

rajansandeep commented Sep 7, 2018

k8sio-netlify-preview-bot commented Sep 7, 2018

k8sio-netlify-preview-bot commented Sep 7, 2018 •

edited

Loading

rajansandeep commented Sep 7, 2018

chrisohaver Sep 7, 2018

rajansandeep Sep 7, 2018

johnbelamaric Sep 7, 2018

johnbelamaric Sep 7, 2018

johnbelamaric Sep 7, 2018

chrisohaver Sep 7, 2018

johnbelamaric Sep 7, 2018

johnbelamaric Sep 7, 2018

johnbelamaric Sep 7, 2018

johnbelamaric Sep 7, 2018

chrisohaver Sep 7, 2018

johnbelamaric Sep 7, 2018

johnbelamaric left a comment

zparnold commented Sep 10, 2018

rajansandeep commented Sep 10, 2018

chrisohaver Sep 10, 2018

chrisohaver Sep 10, 2018

chrisohaver Sep 13, 2018 •

edited

Loading

chrisohaver Sep 10, 2018

zparnold commented Sep 13, 2018

rajansandeep commented Sep 13, 2018

zparnold commented Sep 13, 2018

zparnold commented Sep 13, 2018

k8s-ci-robot commented Sep 13, 2018


		### Configuration of Stub-domain and upstream nameserver using CoreDNS

		CoreDNS has the ability to configure stubdomains and upstream nameservers using the [proxy plugin](https://coredns.io/plugins/proxy/).

Add CoreDNS details to the customize DNS doc #10228

Add CoreDNS details to the customize DNS doc #10228

Conversation

rajansandeep commented Sep 7, 2018

k8sio-netlify-preview-bot commented Sep 7, 2018

k8sio-netlify-preview-bot commented Sep 7, 2018 • edited Loading

rajansandeep commented Sep 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnbelamaric left a comment

Choose a reason for hiding this comment

zparnold commented Sep 10, 2018

rajansandeep commented Sep 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisohaver Sep 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zparnold commented Sep 13, 2018

rajansandeep commented Sep 13, 2018

zparnold commented Sep 13, 2018

zparnold commented Sep 13, 2018

k8s-ci-robot commented Sep 13, 2018

k8sio-netlify-preview-bot commented Sep 7, 2018 •

edited

Loading

chrisohaver Sep 13, 2018 •

edited

Loading