docs update to promote ScheduleDaemonSetPods to beta #9923

Huang-Wei · 2018-08-20T17:17:42Z

ScheduleDaemonSetPods is promoted to beta in 1.12. This PR is used to track all website related changes.

k8sio-netlify-preview-bot · 2018-09-04T17:49:29Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 75a10e9

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b95fdc067610c29d29674de

Huang-Wei · 2018-09-05T22:55:02Z

/assign @bsalamat @k82cn
for tech reviewing

k82cn · 2018-09-06T11:16:54Z

content/en/docs/concepts/workloads/controllers/daemonset.md

@@ -154,7 +154,7 @@ In addition, `node.kubernetes.io/unschedulable:NoSchedule` toleration is added
 automatically to DaemonSet Pods. The default scheduler ignores
 `unschedulable` Nodes when scheduling DaemonSet Pods.

-When this feature is enabled, if DaemonSet uses the host network, you must also add the
+If DaemonSet uses the host network, you must also add the


When kubernetes/kubernetes#64954 merged, this's not necessary.

@k82cn Can you place a note in kubernetes/kubernetes#64954 to remind someone to update this page when it is merged?

@zparnold no worries, I have an eye on that PR.

k82cn · 2018-09-06T11:17:09Z

content/en/docs/concepts/workloads/controllers/daemonset.md

@@ -115,9 +115,9 @@ when the Pod is created, so it is ignored by the scheduler).  Therefore:
   bootstrap.


-### Scheduled by default scheduler
+### Scheduled by default scheduler (enabled by default in 1.12)


k82cn · 2018-09-06T11:17:17Z

content/en/docs/concepts/workloads/controllers/daemonset.md

@@ -103,7 +103,7 @@ If you do not specify either, then the DaemonSet controller will create Pods on

 ## How Daemon Pods are Scheduled

-### Scheduled by DaemonSet controller (default)
+### Scheduled by DaemonSet controller (disabled by default in 1.12)


zparnold · 2018-09-09T22:36:51Z

/approve
@k82cn When you think this is good from a tech review standpoint, I will go ahead and merge.

k8s-ci-robot · 2018-09-09T22:37:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zparnold]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Huang-Wei · 2018-09-09T22:38:59Z

@zparnold thanks for reviewing.

Let's do a hold for now.

/hold

And when kubernetes/kubernetes#64954 is merged, I will update corresponding wordings, and do a unhold. Sounds good to you?

Huang-Wei · 2018-09-10T05:16:23Z

/hold cancel

Huang-Wei · 2018-09-10T06:08:34Z

@zparnold @k82cn PTAL. The statements related with outofdisk and hotnetwork daemonset pod has been updated.

k82cn · 2018-09-12T09:23:28Z

content/en/docs/concepts/workloads/controllers/daemonset.md

-| `node.kubernetes.io/unschedulable`       | NoSchedule | `ScheduleDaemonSetPods`                                      | 1.11+   | When `ScheduleDaemonSetPods` is enabled, DaemonSet pods tolerate unschedulable attributes by default scheduler. |
-| `node.kubernetes.io/network-unavailable` | NoSchedule | `ScheduleDaemonSetPods` (pods using hostNetwork)             | 1.11+   | When `ScheduleDaemonSetPods` is enabled, DaemonSet pods, who uses host network, tolerate network-unavailable attributes by default scheduler. |
-| `node.kubernetes.io/out-of-disk`         | NoSchedule | `ExperimentalCriticalPodAnnotation` (critical pod only)      | 1.8+    |                                                              |
+| `node.kubernetes.io/unschedulable`       | NoSchedule |                                                              | 1.12+   | DaemonSet pods tolerate unschedulable attributes by default scheduler.                                                    |


We also support not-ready/unreachable:NoSchedule right now.

@k82cn Hmm... I didn't see any PR mentioning that.

Also I did a test: create a two-node cluster, then go to node2 and disconnect with apiserver (using iptables command), then node2 is expected to have taint applied:

spec: taints: - effect: NoSchedule key: node.kubernetes.io/unreachable timeAdded: 2018-09-12T17:54:52Z

But when I create a deamonset, only node1 is landed with a pod:

NAME READY STATUS RESTARTS AGE IP NODE NOMINATED NODE pause-rwp5n 1/1 Running 0 7m20s 10.244.2.4 kube-node-1 <none>

And here is the toleration list of daemonset pod on node1:

tolerations: - effect: NoExecute key: node.kubernetes.io/not-ready operator: Exists - effect: NoExecute key: node.kubernetes.io/unreachable operator: Exists - effect: NoSchedule key: node.kubernetes.io/disk-pressure operator: Exists - effect: NoSchedule key: node.kubernetes.io/memory-pressure operator: Exists - effect: NoSchedule key: node.kubernetes.io/unschedulable operator: Exists

Did I miss anything?

@Huang-Wei doesn't your experiment verify that not-ready and unreachable tolerations are added as well?

@bsalamat that's NoExecute effect. I think @k82cn meant NoSchedule effect. BTW: I enabled ScheduleDaemonSetPods=true.

Here is a tolerations list when running ds in v1.11.0:

tolerations: - effect: NoExecute key: node.kubernetes.io/not-ready operator: Exists - effect: NoExecute key: node.kubernetes.io/unreachable operator: Exists - effect: NoSchedule key: node.kubernetes.io/disk-pressure operator: Exists - effect: NoSchedule key: node.kubernetes.io/memory-pressure operator: Exists

I think the behavior in 1.12 is good - the only additional toleration is node.kubernetes.io/unschedulable. That's as expected because we're explicitly handling unschedulable case by leveraging taint/tolerations mechanism (kubectl taint node will add an explicit taint for that node).

I see. Thanks.
I agree that the tolerations added in 1.12 look good.

oh, really sorry, confused with TaintNodesByCondition :(
I'm ok with the doc.

zparnold · 2018-09-12T17:05:48Z

@Huang-Wei Can you address those comments please?

Huang-Wei · 2018-09-12T18:11:18Z

@zparnold let me check with @k82cn on that first.

k82cn · 2018-09-13T01:05:36Z

LGTM :)

zparnold · 2018-09-13T01:24:53Z

/lgtm

* Update docs for fields allowed at root of CRD schema (#9973) * add plugin docs and examples (#10053) * docs update to promote TaintNodesByCondition to beta (#9626) * HPA Specificity Improvements (#8757) Updated the HPA docs to reference the `autoscaling/v2beta2` API version, and added documentation about the new fields. * adjust docs for pod ready++ (#10049) * Remove --cadvisor-port - has been deprecated since v1.10 (#10023) Change-Id: Id2a685473a243aef492a98ff450759f39e362557 * Add Documentation for Snapshot Feature (#9948) * Add documentation for snapshot feature * Update volume-snapshots.md * Add dry-run to api-concepts (#10033) * kubeadm-init: Update the offline support section (#10062) The update includes the following things (in mind with Kubernetes 1.12): - Remove the 1.8 image versions - Add the 1.10 image versions that were missing until now - Include a comment for the missing arch suffixes in 1.12 Signed-off-by: Rostislav M. Georgiev <[email protected]> * Say bye to `DynamicProvisioningScheduling` (#10157) The mentioned feature gate is now collapsed into `VolumeScheduling`. xref: kubernetes/kubernetes#67432 * Update ResourceQuota per PriorityClass state for 1.12 (#10229) * TokenRequest and TokenRequestProjection now beta (#10161) xref: kubernetes/kubernetes#67349 * Change feature state for kms provider to beta. (#10230) KMS Provider will be graduating to beta in v1.12, reflecting this change on the website. * coredns default (#10200) * Promote ShareProcessNamespace to beta in docs (#9996) * Add CoreDNS details to DNS Debug docs (#10201) * add coredns details * address nits, add query logging section * Update docs with topology aware dynamic provisioning (#9939) * Document topology aware volume binding feature * update for readability * Update storage-classes.md * comma splice * don't abbreviate * HPA Algorithm Information Improvements (#9780) * Update HPA docs with more algorithm details The HPA docs pointed to an out-of-date document for information on the algorithm details, which users were finding confusing. This sticks a section on the algorithm in the HPA docs instead, documenting both general behavior and corner cases. * Add glossary info, HPA docs on quantities People often ask about the quantity notation when working with the metrics APIs, so this adds a glossary entry on quantities (since they're used elsewhere in the system), and a short explantation in the HPA walkthough. * Information about HPA readiness and stabilization This adds information about the new changes to HPA readiness and stabilization from kubernetes/enhancements#591, and other minor changes that landed in Kubernetes 1.12. * Update horizontal-pod-autoscale.md * Audit 1.12 doc (#9953) * audit 1.12 document * remove legacy audit feature kubernetes/kubernetes#65862 * update feature gate doc * MountPropagation is now GA (#10090) * RuntimeClass documentation (#10102) * RuntimeClass documentation * Update runtime-class.md * Add documentation for Scheduler performance tuning (#10048) * Add documentation for Scheduler performance tuning * Update scheduler-perf-tuning.md * TTL controller for cleaning up finished resources (#10064) * TTL controller for cleaning up finished resources * Address comments * Update ttlafterfinished.md * Bump quota configuration api version (#10217) * Incremental update from master (#10278) * fix invalid href of cloud controller manager (#10240) * fix invalid yaml format (#10238) * update storage-limits doc with Azure disk part (#10224) update storage-limits doc with Azure disk part fix comments * Update kubelet-config-file.md (#10222) Update link to KubeletConfiguration struct. * fix a trivial misspelling (#10244) * Fix cassandra-statefulset.yaml indent level (#10243) * Mention minimum etcd versions (#10208) Source: https://groups.google.com/d/msg/kubernetes-dev/jMPA4JzKiY4/HIx2ugvLBAAJ * fix 404 error (#10250) * Small verb tweak (#10190) Present participle, ftw. * Add AnchorJS logic for header links (#10155) * Add AnchorJS JavaScript * Remove existing inpage_heading logic * Remove underline from anchor tags * Use single icon and add touch visibility * Use paragraph link icon for AnchorJS * Update Sass to use code formatting in docsContent headers * Update header size coverage to H3-H6 * fix broken link in kubefed.md (#10254) * Update the version numbers for the X-Remote-Extra- and Impersonate-Extra- key fixes (#9827) The fix was cherry picked into 1.11.3, 1.10.7, and 1.9.11: kubernetes/kubernetes#67162 kubernetes/kubernetes#67163 kubernetes/kubernetes#67164 * fix typo (#10168) * fix typo * addressing comments. * Update setup-ha-etcd-with-kubeadm.md * fix typos (#10252) * fix description of contribute guide (#10253) * describe truncate feature about advanced audit (#10236) * describe truncate feature about advanced audit * Update audit.md * docs update to promote ScheduleDaemonSetPods to beta (#9923) * Dynamic volume limit updates for 1.12 (#10211) * add a placeholder commit * Update docs for csi volume limits * Update storage-limits.md * Add "MayRunAs" value among other GroupStrategies (#9888) * Add CoreDNS details to the customize DNS doc (#10228) * Add CoreDNS details to the customize DNS doc Rewrite the document to include more details about CoreDNS, since it's now the default from v1.12 * Address comments * Improve doc wording * Fix link * Update dns-custom-nameservers.md * Update dns-custom-nameservers.md * Fix secrets docs in 1.12 branch (#10056) * Fix secrets docs * Update secret.md * Revert CoreDNS Docs (#10319) * Revert "Add CoreDNS details to DNS Debug docs (#10201)" This reverts commit 462817a. * Revert "Add CoreDNS details to the customize DNS doc (#10228)" This reverts commit e7319ee. * Revert "coredns default (#10200)" This reverts commit 698e93b. * Add CRI installation instructions page Added cri-installation page with CRI installation instructions Referenced it from kubeadm-init and install-kubeadm pages. * kubeadm: update API types documentation for 1.12 (#10283) v1alpha2 -> v1alpha3 MasterConfiguration -> [new-api-types] * TokenRequest feature documentation (#10295) * AdvancedAuditing is now GA (#10156) xref: kubernetes/kubernetes#65862 `AdvancedAuditing` feature is GA in 1.12. This PR adjusts the related docs. * update runtime-class.md (#10332) * update runtime-class.md * Update runtime-class.md * Document cross-authorizer permissions for creating RBAC roles (#10015) * Document cross-authorizer permissions for creating RBAC roles * Update rbac.md * kubeadm: update authored content for 1.12 (reference docs and cluster creation) (#10348) * kubeadm: update authored content in reference docs for 1.12 * kubeadm: add time frame in create-cluster-kubeadm for 1.12 * add AllowedProcMountTypes and ProcMountType to docs (#9911) Signed-off-by: Jess Frazelle <[email protected]> * kubeadm: add new command line reference (#10306) Add: - placeholder files - include place holder files - include "renew" sub command - add missing tabs for "alpha phase kubelet" * Documenting SCTP support in Kubernetes (#10279) * Documenting SCTP support in Kubernetes Service, Endpoint, NetworkPolicy and Pod * Updates based on comments on the PR * kubectl expose update with SCTP support * Updated according to comments in the PR * Revert "kubectl expose update with SCTP support" This reverts commit 0d5a1e6. * TLS Bootstrap and Server Cert Rotation feature documentation (#10232) * TokenRequest feature documentation * line wrapping to make review not insane * update content for GA without major refactor * Update kubelet-tls-bootstrapping.md * Add clarifications for volume snapshots (#10296) * Update kubadm ha installation for 1.12 (#10264) * Update kubadm ha installation for 1.12 Signed-off-by: Chuck Ha <[email protected]> * update stable version Signed-off-by: Chuck Ha <[email protected]> * Update stacked control plane for v1.12 (#2) * use v1alpha3 Signed-off-by: Chuck Ha <[email protected]> * more v1alpha3 (#4) * updates Signed-off-by: Chuck Ha <[email protected]> * Document how to run in-tree cloud providers with kubeadm (#10357) Change-Id: Iab6b996a830503d74a6eb0c507c5f8ca7a39235b * kubeadm reference doc for release 1.12 (#10359) * Revert "Revert "Add CoreDNS details to DNS Debug docs (#10201)"" This reverts commit bb30f4d. * Revert "Revert "Add CoreDNS details to the customize DNS doc (#10228)"" This reverts commit bc23d45. * Revert "Revert "coredns default (#10200)"" This reverts commit 7f4350d. * add missing instruction for ha guide (#10374) Signed-off-by: Chuck Ha <[email protected]> * kubeadm - Ha upgrade updates (#10340) * Update HA upgrade docs * Adds external etcd HA upgrade guide Signed-off-by: Chuck Ha <[email protected]> * copyedit * more edits * add runasgroup in psp (#10076) * update KubeletPluginsWatcher feature gate (#10205) * generated 1.12 docs * Building Multi-arch images with Manifests (#10379) In 1.12, a variety of images used in a typical kubernetes installation have started to using manifests to better support environments with arm or ppc64le architectures. For example all images used with kubeadm by default have manifests, another would be all the tests in the conformance test suite. Here we capture the best practices for everyone to start using manifests in their own workflows. Change-Id: I5ba4c5fe55ffc9486a8251760f3352be4f2e1494 * Upgrade docs for v1.12 (#10344) * generated assets and docs * remove 1.7 * update 1.12 * update plugin documentation under docs>tasks>extend-kubectl (#10259) * update plugin documentation under docs>tasks>extend-kubectl * Update kubectl-plugins.md

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2018

k8s-ci-robot requested review from Rajakavitha1 and zhangxiaoyu-zidif August 20, 2018 17:17

This was referenced Aug 20, 2018

Promote ScheduleDaemonSetPods to Beta in 1.12 kubernetes/kubernetes#66526

Closed

Schedule DaemonSet Pods by kube-scheduler kubernetes/enhancements#548

Closed

Bradamant3 added this to the 1.12 milestone Aug 27, 2018

Huang-Wei force-pushed the ScheduleDaemonSetPods-beta branch from 6b55873 to c2d951a Compare September 4, 2018 17:49

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2018

Huang-Wei changed the title ~~[WIP] docs update to promote ScheduleDaemonSetPods to beta~~ docs update to promote ScheduleDaemonSetPods to beta Sep 5, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2018

k8s-ci-robot assigned bsalamat and k82cn Sep 5, 2018

k82cn reviewed Sep 6, 2018

View reviewed changes

Huang-Wei force-pushed the ScheduleDaemonSetPods-beta branch 2 times, most recently from f182e88 to 588b8a1 Compare September 7, 2018 23:16

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2018

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2018

docs update to promote ScheduleDaemonSetPods to beta

75a10e9

Huang-Wei force-pushed the ScheduleDaemonSetPods-beta branch from 588b8a1 to 75a10e9 Compare September 10, 2018 05:14

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2018

k82cn reviewed Sep 12, 2018

View reviewed changes

k8s-ci-robot assigned zparnold Sep 13, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2018

k8s-ci-robot merged commit 0e2ba47 into kubernetes:release-1.12 Sep 13, 2018

Huang-Wei deleted the ScheduleDaemonSetPods-beta branch September 13, 2018 05:31

christophercarney mentioned this pull request Nov 5, 2019

Issue with k8s.io/docs/concepts/workloads/controllers/daemonset/ #17336

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs update to promote ScheduleDaemonSetPods to beta #9923

docs update to promote ScheduleDaemonSetPods to beta #9923

Huang-Wei commented Aug 20, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Sep 4, 2018 •

edited

Loading

Huang-Wei commented Sep 5, 2018

k82cn Sep 6, 2018

zparnold Sep 9, 2018

Huang-Wei Sep 9, 2018

Huang-Wei Sep 10, 2018

k82cn Sep 6, 2018

k82cn Sep 6, 2018

zparnold commented Sep 9, 2018

k8s-ci-robot commented Sep 9, 2018

Huang-Wei commented Sep 9, 2018

Huang-Wei commented Sep 10, 2018

Huang-Wei commented Sep 10, 2018

k82cn Sep 12, 2018 •

edited

Loading

Huang-Wei Sep 12, 2018

bsalamat Sep 12, 2018

Huang-Wei Sep 12, 2018 •

edited

Loading

Huang-Wei Sep 12, 2018

bsalamat Sep 12, 2018

k82cn Sep 13, 2018

zparnold commented Sep 12, 2018

Huang-Wei commented Sep 12, 2018

k82cn commented Sep 13, 2018

zparnold commented Sep 13, 2018

docs update to promote ScheduleDaemonSetPods to beta #9923

docs update to promote ScheduleDaemonSetPods to beta #9923

Conversation

Huang-Wei commented Aug 20, 2018 • edited Loading

k8sio-netlify-preview-bot commented Sep 4, 2018 • edited Loading

Huang-Wei commented Sep 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zparnold commented Sep 9, 2018

k8s-ci-robot commented Sep 9, 2018

Huang-Wei commented Sep 9, 2018

Huang-Wei commented Sep 10, 2018

Huang-Wei commented Sep 10, 2018

k82cn Sep 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Huang-Wei Sep 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zparnold commented Sep 12, 2018

Huang-Wei commented Sep 12, 2018

k82cn commented Sep 13, 2018

zparnold commented Sep 13, 2018

Huang-Wei commented Aug 20, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Sep 4, 2018 •

edited

Loading

k82cn Sep 12, 2018 •

edited

Loading

Huang-Wei Sep 12, 2018 •

edited

Loading