Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA TTLAfterFinished #29987

Closed
wants to merge 200 commits into from
Closed

GA TTLAfterFinished #29987

wants to merge 200 commits into from

Conversation

sahilvv
Copy link
Contributor

@sahilvv sahilvv commented Oct 8, 2021

This PR updates the TTLAfterFinish controller to stable as part of 1.23 k8s release.

Related PRs:

RA489 and others added 30 commits April 6, 2021 16:52
Makes option 3 for "reclaiming" a released PV a bit clearer. Used to be:

> Manually delete the associated storage asset, or if you want to reuse the same storage asset, create a new PersistentVolume with the same storage asset definition.

But the 2nd part applies more to reclamation option 1 and is kind of contradictory with option 3 (which isn't really "reclaiming" anything AFAICT). So just  move to it's own stand alone sentence.
CBC is not recommended any more due to vulnerability
to padding oracle attacks.

Promote secretbox instead.
use "latest" => "Always"
use nothing => "Always"
use any but "latest" => "IfNotPresent"
update to latest release version since version 1.22 doesn't support 3.8
@netlify
Copy link

netlify bot commented Oct 8, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 6832778

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6163cb91cde08e000795a989

😎 Browse the preview: https://deploy-preview-29987--kubernetes-io-main-staging.netlify.app

@@ -8,17 +8,14 @@ weight: 70

<!-- overview -->

{{< feature-state for_k8s_version="v1.21" state="beta" >}}
{{< feature-state for_k8s_version="v1.23" state="stable" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim do we actually need this now that the feature graduated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep it for a few releases, so that readers can easily see that it only recently graduated and they might need to check feature gates if they're actually running an older version than v1.23

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sahilvv

PRs that cover the upcoming release should not target the main branch - see https://kubernetes.io/docs/contribute/new-content/new-features/

You'll need to rebase this against dev-1.23, force-push, and then change the merge base of your PR.


The TTL controller provides a TTL (time to live) mechanism to limit the lifetime of resource
objects that have finished execution. TTL controller only handles
{{< glossary_tooltip text="Jobs" term_id="job" >}} for now,
and may be expanded to handle other resources that will finish execution,
such as Pods and custom resources.

This feature is currently beta and enabled by default, and can be disabled via
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahilvv remember / please be advised to also update the contents of the feature gates page to move TTLAfterFinished into the graduated section.

@sftim
Copy link
Contributor

sftim commented Oct 9, 2021

/milestone 1.23

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Oct 9, 2021
@sahilvv sahilvv changed the base branch from main to dev-1.23 October 11, 2021 05:23
@sahilvv sahilvv changed the base branch from dev-1.23 to main October 11, 2021 05:23
@sahilvv sahilvv changed the base branch from main to dev-1.23 October 11, 2021 05:29
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sftim after the PR has been reviewed.
You can assign the PR to them by writing /assign @sftim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pl Issues or PRs related to Polish language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 11, 2021
@sahilvv sahilvv closed this Oct 11, 2021
@sahilvv sahilvv deleted the ga_ttl branch October 11, 2021 06:02
@sahilvv
Copy link
Contributor Author

sahilvv commented Oct 11, 2021

Closing this PR as I messed up the git rebasing. See #30031 for the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pl Issues or PRs related to Polish language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.