-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GA TTLAfterFinished #29987
GA TTLAfterFinished #29987
Conversation
Makes option 3 for "reclaiming" a released PV a bit clearer. Used to be: > Manually delete the associated storage asset, or if you want to reuse the same storage asset, create a new PersistentVolume with the same storage asset definition. But the 2nd part applies more to reclamation option 1 and is kind of contradictory with option 3 (which isn't really "reclaiming" anything AFAICT). So just move to it's own stand alone sentence.
Signed-off-by: Ritikaa96 <[email protected]>
CBC is not recommended any more due to vulnerability to padding oracle attacks. Promote secretbox instead.
Added missing ServiceAccount, ClusterRole and ClusterRoleBinding. kubernetes#15280 https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml
Co-authored-by: Rey Lejano <[email protected]>
Co-authored-by: Rey Lejano <[email protected]>
Co-authored-by: Rey Lejano <[email protected]>
Co-authored-by: Rey Lejano <[email protected]>
Signed-off-by: bhumijgupta <[email protected]>
Signed-off-by: bhumijgupta <[email protected]>
Co-authored-by: Rey Lejano <[email protected]>
use "latest" => "Always" use nothing => "Always" use any but "latest" => "IfNotPresent"
update to latest release version since version 1.22 doesn't support 3.8
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 6832778 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6163cb91cde08e000795a989 😎 Browse the preview: https://deploy-preview-29987--kubernetes-io-main-staging.netlify.app |
@@ -8,17 +8,14 @@ weight: 70 | |||
|
|||
<!-- overview --> | |||
|
|||
{{< feature-state for_k8s_version="v1.21" state="beta" >}} | |||
{{< feature-state for_k8s_version="v1.23" state="stable" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim do we actually need this now that the feature graduated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep it for a few releases, so that readers can easily see that it only recently graduated and they might need to check feature gates if they're actually running an older version than v1.23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sahilvv
PRs that cover the upcoming release should not target the main branch - see https://kubernetes.io/docs/contribute/new-content/new-features/
You'll need to rebase this against dev-1.23, force-push, and then change the merge base of your PR.
|
||
The TTL controller provides a TTL (time to live) mechanism to limit the lifetime of resource | ||
objects that have finished execution. TTL controller only handles | ||
{{< glossary_tooltip text="Jobs" term_id="job" >}} for now, | ||
and may be expanded to handle other resources that will finish execution, | ||
such as Pods and custom resources. | ||
|
||
This feature is currently beta and enabled by default, and can be disabled via | ||
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahilvv remember / please be advised to also update the contents of the feature gates page to move TTLAfterFinished
into the graduated section.
/milestone 1.23 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closing this PR as I messed up the git rebasing. See #30031 for the latest changes. |
This PR updates the TTLAfterFinish controller to stable as part of 1.23 k8s release.
Related PRs: