KEP-592: Graduate TTL after finish to stable #2841

sahilvv · 2021-07-27T17:42:14Z

One-line PR description: This PR graduates TTL for completed jobs to stable in 1.23
Issue link: Enhancement issue: TTL after finish #592[https://github.com/TTL after finish #592]
Other comments: This was spoken about in the sig-apps meeting on 7/26.

k8s-ci-robot · 2021-07-27T17:42:22Z

Welcome @sahilvv!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-07-27T17:42:22Z

Hi @sahilvv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-07-27T17:42:24Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sahilvv · 2021-07-27T17:57:36Z

CLA done. retest

keps/sig-apps/592-ttl-after-finish/README.md

ravisantoshgudimetla

Thank you @sahilvv for working on this. Please look at my comments.

ravisantoshgudimetla · 2021-08-18T14:17:25Z

keps/sig-apps/592-ttl-after-finish/README.md

@@ -237,7 +237,7 @@ Mitigations:

 ### Beta -> GA

- Make a decision on wehther or not the feature should be extended to pods
+- ~~Make a decision on whether or not the feature should be extended to pods~~


I'll handle this in a separate KEP/ alpha level implementation PR. You can for now say, TTL controller can be GA'ed without handling pods. The ability to extend TTL controller to work with pods can be introduced via a featuregate so that we can collect feedback and improve.

addressed in my latest commit. Thanks @ravisantoshgudimetla

keps/sig-apps/592-ttl-after-finish/README.md

soltysh · 2021-08-19T16:31:18Z

/ok-to-test

soltysh

One nit, @ravisantoshgudimetla can lgtm
/approve

soltysh · 2021-08-19T16:31:53Z

keps/sig-apps/592-ttl-after-finish/README.md

@@ -237,7 +237,7 @@ Mitigations:

 ### Beta -> GA

- Make a decision on wehther or not the feature should be extended to pods
+- ~~Make a decision on whether or not the feature should be extended to pods~~


keps/prod-readiness/sig-apps/592.yaml

wojtek-t · 2021-08-23T06:57:03Z

/assign

I will review later this week.

ravisantoshgudimetla

Squash and this LGTM

Thank you @sahilvv

wojtek-t · 2021-08-30T07:52:10Z

/approve PRR

Incorporating feedback

sahilvv · 2021-08-30T17:46:17Z

@ravisantoshgudimetla squashed all commits in one. Good to proceed to with LGTM

ravisantoshgudimetla

/lgtm

Thank you @sahilvv

k8s-ci-robot · 2021-08-30T18:16:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, sahilvv, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/prod-readiness/OWNERS~~ [wojtek-t]
~~keps/sig-apps/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2021

k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 27, 2021

k8s-ci-robot requested review from kow3ns and soltysh July 27, 2021 17:42

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 27, 2021

sahilvv commented Jul 27, 2021

View reviewed changes

keps/sig-apps/592-ttl-after-finish/README.md Show resolved Hide resolved

ravisantoshgudimetla reviewed Aug 18, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2021

soltysh approved these changes Aug 19, 2021

View reviewed changes

wojtek-t reviewed Aug 23, 2021

View reviewed changes

keps/prod-readiness/sig-apps/592.yaml Show resolved Hide resolved

k8s-ci-robot assigned wojtek-t Aug 23, 2021

ravisantoshgudimetla reviewed Aug 27, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021

Graduate TTL after finish to stable

ee3a716

Incorporating feedback

sahilvv force-pushed the ttl_ga branch from 61acbed to ee3a716 Compare August 30, 2021 17:45

ravisantoshgudimetla approved these changes Aug 30, 2021

View reviewed changes

k8s-ci-robot assigned ravisantoshgudimetla Aug 30, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2021

k8s-ci-robot merged commit 97da0f7 into kubernetes:master Aug 30, 2021

k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021

sahilvv mentioned this pull request Sep 23, 2021

GA TTLAfterFinish kubernetes/kubernetes#105219

Merged

This was referenced Oct 8, 2021

GA TTLAfterFinished kubernetes/website#29987

Closed

GA TTLAfterFinished kubernetes/website#30031

Merged

sahilvv mentioned this pull request Oct 26, 2021

REQUEST: New membership for sahilvv kubernetes/org#3057

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KEP-592: Graduate TTL after finish to stable #2841

KEP-592: Graduate TTL after finish to stable #2841

sahilvv commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

sahilvv commented Jul 27, 2021

ravisantoshgudimetla left a comment

ravisantoshgudimetla Aug 18, 2021

soltysh Aug 19, 2021

sahilvv Aug 24, 2021

soltysh commented Aug 19, 2021

soltysh left a comment

soltysh Aug 19, 2021

wojtek-t commented Aug 23, 2021

ravisantoshgudimetla left a comment

wojtek-t commented Aug 30, 2021

sahilvv commented Aug 30, 2021

ravisantoshgudimetla left a comment

k8s-ci-robot commented Aug 30, 2021

KEP-592: Graduate TTL after finish to stable #2841

KEP-592: Graduate TTL after finish to stable #2841

Conversation

sahilvv commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

k8s-ci-robot commented Jul 27, 2021

sahilvv commented Jul 27, 2021

ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

ravisantoshgudimetla Aug 18, 2021

Choose a reason for hiding this comment

soltysh Aug 19, 2021

Choose a reason for hiding this comment

sahilvv Aug 24, 2021

Choose a reason for hiding this comment

soltysh commented Aug 19, 2021

soltysh left a comment

Choose a reason for hiding this comment

soltysh Aug 19, 2021

Choose a reason for hiding this comment

wojtek-t commented Aug 23, 2021

ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

wojtek-t commented Aug 30, 2021

sahilvv commented Aug 30, 2021

ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 30, 2021