TTL after finish #592

janetkuo · 2018-07-23T21:23:47Z

Feature Description

One-line feature description (can be used as a release note): Introduce a TTL controller to clean up Jobs and Pods after they finish.
Primary contact (assignee): @janetkuo
Responsible SIGs: sig-apps
Design proposal link (community repo): https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/0026-ttl-after-finish.md (https://goo.gl/YxtxTi, KEP for TTL-after-finished controller community#2552)
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @kow3ns @enisoc @tnozicka
Approver (likely from SIG/area to which feature belongs): @kow3ns
Feature target (which target equals to which milestone):
- Alpha release target (1.12)
- Beta release target (1.21)
- Stable release target (1.23)

tnozicka · 2018-08-01T11:22:55Z

Design proposal link (community repo): https://goo.gl/YxtxTi

Does the google doc need to be moved to community repo?

tnozicka · 2018-08-15T13:48:10Z

Reviewers from multiple companies preferred

Happy to review as well and help fill in the diversity requirement here.

janetkuo · 2018-08-16T16:16:21Z

Thanks @tnozicka! Added you as reviewer

janetkuo · 2018-08-16T17:50:51Z

Updated link to KEP as well

zparnold · 2018-08-20T20:28:52Z

Hey there! @janetkuo I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

janetkuo · 2018-08-23T22:15:47Z

@zparnold I've opened the docs PR: kubernetes/website#10064; it's still WIP

Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. TTL for cleaning up Jobs after they finish **What this PR does / why we need it**: kubernetes/enhancements#592 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #64470 For kubernetes/enhancements#592 **Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews **Release note**: ```release-note Add a TTL machenism to clean up Jobs after they finish. ```

Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. TTL for cleaning up Jobs after they finish **What this PR does / why we need it**: kubernetes/enhancements#592 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #64470 For kubernetes/enhancements#592 **Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews **Release note**: ```release-note Add a TTL machenism to clean up Jobs after they finish. ``` Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea

justaugustus · 2018-09-05T22:09:22Z

@janetkuo --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

janetkuo · 2018-09-06T23:18:18Z

@justaugustus yes we're landing it for 1.12. The docs is under review kubernetes/website#10064

justaugustus · 2018-09-07T16:46:52Z

Thanks for the update, @janetkuo!

Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. TTL for cleaning up Jobs after they finish **What this PR does / why we need it**: kubernetes/enhancements#592 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #64470 For kubernetes/enhancements#592 **Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews **Release note**: ```release-note Add a TTL machenism to clean up Jobs after they finish. ``` Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea

ameukam · 2018-10-05T16:34:21Z

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

kacole2 · 2018-10-08T15:50:58Z

@janetkuo following up from @ameukam's comment. Is there a plan for this to graduate to beta in 1.13?

janetkuo · 2018-10-09T00:49:36Z

There's currently no plan to graduate it to beta in 1.13.

kacole2 · 2018-10-09T00:52:44Z

/milestone clear

fejta-bot · 2019-01-07T01:21:23Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2019-02-06T01:41:06Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

salaxander · 2021-09-01T15:31:26Z

/milestone v1.23

salaxander · 2021-09-01T17:58:00Z

Hi @ahg-g! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

~~KEP file using the latest template has been merged into the k/enhancements repo.~~
~~KEP status is marked as implementable~~
~~KEP has a test plan section filled out.~~
~~KEP has up to date graduation criteria.~~
~~KEP has a production readiness review that has been completed and merged into k/enhancements.~~

Looks like we're all set for enhancements freeze :)

Thanks!

jlbutler · 2021-09-22T15:38:36Z

Hi @ahg-g 👋 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

chrisnegus · 2021-10-11T16:33:39Z

Hi @sahilvv 👋 1.23 Docs shadow here.

Just want to verify that there are two docs PRs to track for this KEP in 1.23:

kubernetes/website#29987
kubernetes/website#30031

sahilvv · 2021-10-12T05:42:24Z

@chrisnegus you can ignore kubernetes/website#29987. kubernetes/website#30031 contains all the changes needed for graduating this feature to stable in 1.23. Let me know if any further questions.

salaxander · 2021-11-04T02:05:05Z

Hi @ahg-g. Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
All PRs are fully merged by the code freeze deadline.
Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

sahilvv · 2021-11-04T17:22:53Z

@salaxander I am the owner of this KEP and feature to take to GA state in 1.23. To answer your questions:

All PRs are merged to the k8s repo at this time
Doc update PRs are merged to dev-1.23 branch at this time.

No pending tasks left related to this KEP to the best of my knowledge.

Thanks.

salaxander · 2021-11-08T17:49:12Z

Hi @sahilvv - thanks for the update!

I've updated our tracking to show this as complete. When you get a chance, could you link the k/k PRs in the issue description?

Thanks!

sahilvv · 2021-11-08T20:23:21Z

@salaxander Following are the PRs to move this feature from Beta to Stable/GA state:

kubernetes/kubernetes#105219
kubernetes/website#30031

gracenng · 2022-01-09T04:58:38Z

1.24 Enhancements Lead here,

@sahilvv, could you please update the KEP status to implemented and close this issue then?

Thanks :)

sahilvv · 2022-01-12T01:27:38Z

@gracenng pardon my dumb question, I did mark the KEP as stable in PR https://github.com/kubernetes/enhancements/pull/2841/files. Let me know where I need to flip the status to implemented.

gracenng · 2022-01-12T06:25:30Z

hi @sahilvv , I could have been more clear. This line should be implemented instead of implementable

https://github.com/sahilvv/enhancements/blob/ee3a716a89c3aa0a16891447a46123bf9bd564f4/keps/sig-apps/592-ttl-after-finish/kep.yaml#L10

sahilvv · 2022-01-22T08:43:32Z

@gracenng above PR#3147 is merged. I am not sure how to close the issue as I don't see that as an option.

gracenng · 2022-01-22T18:03:47Z

Done, thanks

janetkuo added sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Jul 23, 2018

janetkuo added this to the v1.12 milestone Jul 23, 2018

janetkuo self-assigned this Jul 23, 2018

justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 25, 2018

janetkuo mentioned this issue Jul 31, 2018

TTL for cleaning up Jobs after they finish kubernetes/kubernetes#66840

Merged

kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 8, 2018

k8s-ci-robot removed this from the v1.12 milestone Oct 9, 2018

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2019

This was referenced May 25, 2021

Add TTLAfterFinished feature reference chuntaochen/website#1

Merged

Add TTLAfterFinished feature reference kubernetes/website#28112

Closed

sahilvv mentioned this issue Jul 27, 2021

KEP-592: Graduate TTL after finish to stable #2841

Merged

k8s-ci-robot modified the milestones: v1.21, v1.23 Sep 1, 2021

mmiranda96 mentioned this issue Sep 16, 2021

Remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features kubernetes/test-infra#23642

Closed

sahilvv mentioned this issue Sep 23, 2021

GA TTLAfterFinish kubernetes/kubernetes#105219

Merged

gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 9, 2022

gracenng removed this from the v1.23 milestone Jan 9, 2022

sahilvv mentioned this issue Jan 15, 2022

Mark TTL-after-finish KEP-592 to implemented #3147

Merged

gracenng closed this as completed Jan 22, 2022

github-actions bot mentioned this issue May 6, 2022

Blog: Frontiers, fsGroups and frogs: the Kubernetes 1.23 release interview rajula96reddy/rss-issue-action-test#19

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TTL after finish #592

TTL after finish #592

janetkuo commented Jul 23, 2018 •

edited by soltysh

Loading

tnozicka commented Aug 1, 2018

tnozicka commented Aug 15, 2018

janetkuo commented Aug 16, 2018

janetkuo commented Aug 16, 2018

zparnold commented Aug 20, 2018

janetkuo commented Aug 23, 2018

justaugustus commented Sep 5, 2018

janetkuo commented Sep 6, 2018 •

edited

Loading

justaugustus commented Sep 7, 2018

ameukam commented Oct 5, 2018

kacole2 commented Oct 8, 2018

janetkuo commented Oct 9, 2018

kacole2 commented Oct 9, 2018

fejta-bot commented Jan 7, 2019

fejta-bot commented Feb 6, 2019

salaxander commented Sep 1, 2021

salaxander commented Sep 1, 2021 •

edited

Loading

jlbutler commented Sep 22, 2021

chrisnegus commented Oct 11, 2021

sahilvv commented Oct 12, 2021

salaxander commented Nov 4, 2021

sahilvv commented Nov 4, 2021

salaxander commented Nov 8, 2021

sahilvv commented Nov 8, 2021

gracenng commented Jan 9, 2022

sahilvv commented Jan 12, 2022

gracenng commented Jan 12, 2022

sahilvv commented Jan 22, 2022

gracenng commented Jan 22, 2022

TTL after finish #592

TTL after finish #592

Comments

janetkuo commented Jul 23, 2018 • edited by soltysh Loading

Feature Description

tnozicka commented Aug 1, 2018

tnozicka commented Aug 15, 2018

janetkuo commented Aug 16, 2018

janetkuo commented Aug 16, 2018

zparnold commented Aug 20, 2018

janetkuo commented Aug 23, 2018

justaugustus commented Sep 5, 2018

janetkuo commented Sep 6, 2018 • edited Loading

justaugustus commented Sep 7, 2018

ameukam commented Oct 5, 2018

kacole2 commented Oct 8, 2018

janetkuo commented Oct 9, 2018

kacole2 commented Oct 9, 2018

fejta-bot commented Jan 7, 2019

fejta-bot commented Feb 6, 2019

salaxander commented Sep 1, 2021

salaxander commented Sep 1, 2021 • edited Loading

jlbutler commented Sep 22, 2021

chrisnegus commented Oct 11, 2021

sahilvv commented Oct 12, 2021

salaxander commented Nov 4, 2021

sahilvv commented Nov 4, 2021

salaxander commented Nov 8, 2021

sahilvv commented Nov 8, 2021

gracenng commented Jan 9, 2022

sahilvv commented Jan 12, 2022

gracenng commented Jan 12, 2022

sahilvv commented Jan 22, 2022

gracenng commented Jan 22, 2022

janetkuo commented Jul 23, 2018 •

edited by soltysh

Loading

janetkuo commented Sep 6, 2018 •

edited

Loading

salaxander commented Sep 1, 2021 •

edited

Loading