Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated kubectl flag delete-local-data in kubeadm docs #29058

Closed
xinydev opened this issue Jul 21, 2021 · 4 comments · Fixed by #29076
Closed

Update deprecated kubectl flag delete-local-data in kubeadm docs #29058

xinydev opened this issue Jul 21, 2021 · 4 comments · Fixed by #29076
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@xinydev
Copy link
Member

xinydev commented Jul 21, 2021

This is a Bug Report

Problem:

https://github.com/kubernetes/website/blob/main/content/en/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md#remove-the-node

kubectl drain <node name> --delete-local-data --force --ignore-daemonsets

Flag --delete-local-data has been deprecated, This option is deprecated and will be deleted. Use --delete-emptydir-data.

I don’t know if it’s a good time to update this flag . If so, I can help update it.

Proposed Solution:

Update to

kubectl drain <node name> --delete-emptydir-data  --force --ignore-daemonsets

Page to Update:
https://kubernetes.io/zh/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#tear-down

https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#remove-the-node

https://kubernetes.io/ja/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#%E3%83%8E%E3%83%BC%E3%83%89%E3%81%AE%E5%89%8A%E9%99%A4

https://kubernetes.io/fr/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#tear-down

https://kubernetes.io/id/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#menghapus-node

/sig cluster-lifecycle

@xinydev xinydev added the kind/bug Categorizes issue or PR as related to a bug. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 21, 2021
@xinydev
Copy link
Member Author

xinydev commented Jul 21, 2021

cc @neolit123

@neolit123
Copy link
Member

Flag --delete-local-data has been deprecated, This option is deprecated and will be deleted. Use --delete-emptydir-data.
I don’t know if it’s a good time to update this flag . If so, I can help update it.

i see the discussion / PR here:
kubernetes/kubernetes#80228
kubernetes/kubernetes#95076

using --delete-emptydir-data in the kubeadm docs makes sense.

/triage accepted
/help

@k8s-ci-robot
Copy link
Contributor

@neolit123:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Flag --delete-local-data has been deprecated, This option is deprecated and will be deleted. Use --delete-emptydir-data.
I don’t know if it’s a good time to update this flag . If so, I can help update it.

i see the discussion / PR here:
kubernetes/kubernetes#80228
kubernetes/kubernetes#95076

using --delete-emptydir-data in the kubeadm docs makes sense.

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 21, 2021
@xinydev
Copy link
Member Author

xinydev commented Jul 21, 2021

/assign

@xinydev xinydev changed the title Update deprecated kubeadm flag delete-local-data Update deprecated kubectl flag delete-local-data in kubeadm docs Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants