Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graceful recovery tests #2440

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented Aug 21, 2024

Fix graceful recovery tests

Problem: Graceful recovery tests were failing in the pipeline

Solutions:

  • Increase timeout when testing for passing/failing traffic after a container or pod restart. The timeout was set to 20 seconds, with a polling interval of 500ms, but the per-request timeout was 10 seconds. This means we were only retrying the request twice when a request timed out because it couldn't connect. Increasing the overall timeout to 60 seconds increased the number of retries and eliminated the errors.
  • Remove the kubectl drain flag --delete-local-data since it no longer exists and replace it with --delete-emptydir-data. See: Update deprecated kubectl flag delete-local-data in kubeadm docs kubernetes/website#29058.

Fixes #2429

Testing:

  • Ran locally multiple times without error
  • Ran in pipeline multiple times without error

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug Something isn't working label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (0075167) to head (22c88b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2440   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files         100      100           
  Lines        7527     7527           
  Branches       50       50           
=======================================
  Hits         6687     6687           
  Misses        784      784           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kate-osborn kate-osborn force-pushed the fix/graceful-recovery-test branch 2 times, most recently from bddacea to f62bd42 Compare August 22, 2024 00:29
@kate-osborn kate-osborn changed the title Increase test for traffic timeout Fix graceful recovery tests Aug 22, 2024
@kate-osborn kate-osborn marked this pull request as ready for review August 22, 2024 15:35
@kate-osborn kate-osborn requested a review from a team as a code owner August 22, 2024 15:35
@kate-osborn kate-osborn merged commit 5d1a655 into nginxinc:main Aug 22, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Graceful recovery test failing
5 participants