Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubectl deprecated flag delete-local-data to delete-emptydir-data #29076

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Update kubectl deprecated flag delete-local-data to delete-emptydir-data #29076

merged 1 commit into from
Jul 26, 2021

Conversation

xinydev
Copy link
Member

@xinydev xinydev commented Jul 22, 2021 •
edited
Loading

Fix: #29058

Update kubectl deprecated flag --delete-local-data to --delete-emptydir-data

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/fr Issues or PRs related to French language labels Jul 22, 2021
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2021
@netlify
Copy link

netlify bot commented Jul 22, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: d095a14

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60fa2c1b6eca200007cf402d

😎 Browse the preview: https://deploy-preview-29076--kubernetes-io-main-staging.netlify.app

sftim
sftim reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be OK to merge, but might cause a conflict for localization teams.
/sig cluster-lifecycle
LGTM

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 22, 2021
@neolit123
Copy link
Member

neolit123 commented Jul 22, 2021 via email

@xinydev
Copy link
Member Author

xinydev commented Jul 23, 2021 •
edited
Loading

/hold

Only need to update the English version, otherwise there will be conflicts. These changes will be synchronized by the localization team

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2021
@xinydev
Update kubectl deprecated flag delete-local-data
d095a14 
Signed-off-by: XinYang <[email protected]>

revert changes

Signed-off-by: XinYang <[email protected]>

update more

Signed-off-by: XinYang <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2021
@xinydev
Copy link
Member Author

xinydev commented Jul 23, 2021

/unhold
/remove-language zh
/remove-language fr
/remove-language id
/remove-language ja

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language labels Jul 23, 2021
@tengqm
Copy link
Contributor

tengqm commented Jul 25, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9dddd55c82dc315c422f7521ddff33cc95572fad

sftim
sftim reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 09903e1 into kubernetes:main Jul 26, 2021
@xinydev xinydev mentioned this pull request Aug 2, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@inductor inductor Awaiting requested review from inductor

@rbenzair rbenzair Awaiting requested review from rbenzair

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deprecated kubectl flag delete-local-data in kubeadm docs
5 participants
@xinydev @neolit123 @tengqm @k8s-ci-robot @sftim