Add robustness test on 3.6, 3,5 and 3.4#34834
Conversation
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
|
/test pull-test-infra-unit-test-race-detector-nonblocking |
|
Question, @ahrtr. The description (and job prefix) refer to a periodic job, but you added the jobs to the presubmits. Is this a mistake? Or do we want them as presubmits (I'm trying to follow up what led to this pull request, but a lot of things happened since last week and still trying to catch up). |
|
We removed all experimental flags in etcd-io/etcd#19959, it makes the main branch much cleaner. But it also breaks the robustness test against release-3.4 and 3.5. So I am trying to fix it in etcd-io/etcd#20001. But the problem is the robustness-test-3.[4-5] are periodically workflows, which can't be verified immediately. So I temporarily add them presubmits in this PR. Once we finish the etcd-io/etcd#20001, we will revert this PR. |
|
/hold Let me cancel hold after I resolved the e2e workflow failures in etcd-io/etcd#20001. This doesn't block others to approve this PR. |
ivanvc
left a comment
There was a problem hiding this comment.
I forgot about this pull request. Thanks for the explanation, @ahrtr. I think the jobs' name (having the ci prefix) may be misleading. It would be better to have it as a pull, like the rest of the presubmits. Feel free to remove the hold if we want to have them running sooner rather than later running.
/hold
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel Let's verify the workflow now, thx |
|
@ahrtr: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adding the periodically robustness test against 3.4-3.6 to verify the etcd-io/etcd#20001. Once the PR gets merged, we can remove them.
cc @ivanvc @jmhbnz