Skip to content

Add robustness test on 3.6, 3,5 and 3.4#34834

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ahrtr:etcd_test_20250521
May 24, 2025
Merged

Add robustness test on 3.6, 3,5 and 3.4#34834
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ahrtr:etcd_test_20250521

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented May 21, 2025

Adding the periodically robustness test against 3.4-3.6 to verify the etcd-io/etcd#20001. Once the PR gets merged, we can remove them.

cc @ivanvc @jmhbnz

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from jmhbnz and wenjiaswe May 21, 2025 15:48
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the etcd_test_20250521 branch from fb295eb to 0289dc4 Compare May 21, 2025 15:57
@ahrtr
Copy link
Member Author

ahrtr commented May 21, 2025

/test pull-test-infra-unit-test-race-detector-nonblocking

@ivanvc
Copy link
Member

ivanvc commented May 22, 2025

Question, @ahrtr. The description (and job prefix) refer to a periodic job, but you added the jobs to the presubmits. Is this a mistake? Or do we want them as presubmits (I'm trying to follow up what led to this pull request, but a lot of things happened since last week and still trying to catch up).

@ahrtr
Copy link
Member Author

ahrtr commented May 22, 2025

@ivanvc

We removed all experimental flags in etcd-io/etcd#19959, it makes the main branch much cleaner. But it also breaks the robustness test against release-3.4 and 3.5. So I am trying to fix it in etcd-io/etcd#20001. But the problem is the robustness-test-3.[4-5] are periodically workflows, which can't be verified immediately.

So I temporarily add them presubmits in this PR. Once we finish the etcd-io/etcd#20001, we will revert this PR.

@ahrtr
Copy link
Member Author

ahrtr commented May 22, 2025

/hold

Let me cancel hold after I resolved the e2e workflow failures in etcd-io/etcd#20001. This doesn't block others to approve this PR.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2025
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this pull request. Thanks for the explanation, @ahrtr. I think the jobs' name (having the ci prefix) may be misleading. It would be better to have it as a pull, like the rest of the presubmits. Feel free to remove the hold if we want to have them running sooner rather than later running.

/hold
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented May 24, 2025

/hold cancel

Let's verify the workflow now, thx

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit b7d8226 into kubernetes:master May 24, 2025
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ahrtr: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml
Details

In response to this:

Adding the periodically robustness test against 3.4-3.6 to verify the etcd-io/etcd#20001. Once the PR gets merged, we can remove them.

cc @ivanvc @jmhbnz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants