Cleanup the deprecated experimental flags

[ahrtr]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[codecov]

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (f19aca6) to head (5625446).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
server/etcdserver/bootstrap.go	0.00%	2 Missing ⚠️
server/etcdmain/config.go	75.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/config/config.go	80.23% <ø> (ø)
server/embed/config.go	78.23% <100.00%> (-1.80%)	⬇️
server/embed/etcd.go	76.32% <100.00%> (ø)
server/features/etcd_features.go	60.00% <ø> (ø)
server/etcdmain/config.go	72.51% <75.00%> (-3.31%)	⬇️
server/etcdserver/bootstrap.go	63.59% <0.00%> (ø)

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19959      +/-   ##
==========================================
- Coverage   68.91%   68.80%   -0.12%     
==========================================
  Files         424      424              
  Lines       35860    35744     -116     
==========================================
- Hits        24714    24594     -120     
- Misses       9725     9727       +2     
- Partials     1421     1423       +2     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19aca6...5625446. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[serathius]

Nice

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahrtr]

/test pull-etcd-integration-1-cpu-amd64

[ahrtr]

@serathius thx for the quick review!

[ahrtr]

@ivanvc @jmhbnz @fuweid @serathius @siyuanfoundation

We cleaned up all experimental flags, the robustness test on main branch may not be able to test stable releases. At least release-3.5 and 3.4 won't work. release-3.6 might still work.

[serathius]

We cleaned up all experimental flags, the robustness test on main branch may not be able to test stable releases.

Ups, right. That's not great. Maybe we could disable passing experimental flags for now to make the tests green?

[ahrtr]

We cleaned up all experimental flags, the robustness test on main branch may not be able to test stable releases.

Ups, right. That's not great. Maybe we could disable passing experimental flags for now to make the tests green?

We have two approaches,

• The robustness test on main branch is only to test main; and use robustness test on 3.6 to test all stable releases.
  • Pros: clear
  • Cros: maintain two sets of robustness test :(
• We update test cases, and try to avoid use all such experimental or migrated fields. Let me try this for now
  • Pros: still maintain one robustness test
  • Not sure how many test will be affected for now.