Skip to content

Remove prefix --experimental- instead of --experimental from flag#20019

Merged
ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr:robust_test_20250524
May 25, 2025
Merged

Remove prefix --experimental- instead of --experimental from flag#20019
ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr:robust_test_20250524

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented May 24, 2025

Otherwise, we will get flags something like below when converting experimental flag to non-experimental flag,

  • ---compaction-batch-limit=10
  • ---watch-progress-notify-interval=100ms

See errors below,

    main_test.go:144: failed triggering failpoint, err: failed to find etcd ready lines ["ready to serve client requests"], err: match not found.  Set EXPECT_DEBUG for more info Errs: [unexpected exit code [2] after running [/tmp/etcd-release-3.6-failpoints/bin/etcd --name=TestRobustnessExploratoryKubernetesLowTrafficClusterOfSize1-test-0 --listen-client-urls=http://localhost:20000 --advertise-client-urls=http://localhost:20000 --listen-peer-urls=http://localhost:20001 --initial-advertise-peer-urls=http://localhost:20001 --initial-cluster-token=new --data-dir=/tmp/TestRobustnessExploratoryKubernetesLowTrafficClusterOfSize13155801533/001 --snapshot-count=1000 --snapshot-count=1000 ---compaction-batch-limit=1000 ---watch-progress-notify-interval=100ms --initial-cluster-token=new --initial-cluster=TestRobustnessExploratoryKubernetesLowTrafficClusterOfSize1-test-0=http://localhost:20001 --initial-cluster-state=new]], last lines:
        bad flag syntax: ---compaction-batch-limit=1000
        Usage:
        
          etcd [flags]
            Start an etcd server.
        
          etcd --version
            Show the version of etcd.
        
          etcd -h | --help
            Show the help information about etcd.
        
          etcd --config-file
            Path to the server configuration file. Note that if a configuration file is provided, other command line flags and environment variables will be ignored.
        
          etcd gateway
            Run the stateless pass-through etcd TCP connection forwarding proxy.
        
          etcd grpc-proxy
            Run the stateless etcd v3 gRPC L7 reverse proxy.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

…flag

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the robust_test_20250524 branch from 72ad6b6 to 96e40b2 Compare May 24, 2025 18:41
@ahrtr ahrtr changed the title Remove prefix '-' or '--' from flag Remove prefix --experimental- instead of --experimental from flag May 24, 2025
@ahrtr
Copy link
Member Author

ahrtr commented May 24, 2025

followup to #20001

@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.00%. Comparing base (ebcfdd0) to head (96e40b2).
Report is 2 commits behind head on main.

Additional details and impacted files

see 144 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20019      +/-   ##
==========================================
- Coverage   68.74%   62.00%   -6.74%     
==========================================
  Files         424      412      -12     
  Lines       35757    34663    -1094     
==========================================
- Hits        24580    21493    -3087     
- Misses       9761    11594    +1833     
- Partials     1416     1576     +160     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcfdd0...96e40b2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr
Copy link
Member Author

ahrtr commented May 24, 2025

All other PRs are affected, we need to get this PR merged asap. cc @fuweid @ivanvc @jmhbnz @serathius Please approve this PR when you get 1 second.

Note: we just merged kubernetes/test-infra#34834 today. Will revert that PR once this PR gets verified & merged.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit fb5bc00 into etcd-io:main May 25, 2025
33 of 34 checks passed
@ahrtr ahrtr deleted the robust_test_20250524 branch May 26, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants