Skip to content

create image pushing job for kube-scheduler-simulator#23567

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sanposhiho:job-for-scheduler-siumulator
Sep 14, 2021
Merged

create image pushing job for kube-scheduler-simulator#23567
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sanposhiho:job-for-scheduler-siumulator

Conversation

@sanposhiho
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho commented Sep 12, 2021

Hello team. This PR creates image pushing job for kube-scheduler-simulator.

part of kubernetes-sigs/kube-scheduler-simulator#19

staging repo was created in kubernetes/k8s.io#2681

On the repo, cloudbuild.yaml will be created in kubernetes-sigs/kube-scheduler-simulator#21

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2021
@sanposhiho sanposhiho changed the title Add: create image pushing job for kube-scheduler-simulator create image pushing job for kube-scheduler-simulator Sep 12, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2021
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Sep 13, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 13, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 13, 2021
@sanposhiho
Copy link
Copy Markdown
Member Author

@spiffxp thanks for reviewing, fixed it

Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2021
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Sep 14, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 14, 2021
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Sep 14, 2021

changed to use k8s-staging-test-infra/image-builder instead of k8s-testimages/image-builder because a test was failed
Ref: #23587

spec:
serviceAccountName: gcb-builder
containers:
- image: gcr.io/k8s-testimages/image-builder:v20210622-762366a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- image: gcr.io/k8s-testimages/image-builder:v20210622-762366a
- image: gcr.io/k8s-staging-test-infra/image-builder:v20210913-fc7c4e84f6

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Sep 14, 2021

Can you rebase to drop the merge commit

@sanposhiho sanposhiho force-pushed the job-for-scheduler-siumulator branch from 1a6ea19 to 15dc9f4 Compare September 14, 2021 14:38
@sanposhiho
Copy link
Copy Markdown
Member Author

Can you rebase to drop the merge commit

👍 done

Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b1842b into kubernetes:master Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 14, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@sanposhiho: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-sched-simulator.yaml using file config/jobs/image-pushing/k8s-staging-sched-simulator.yaml
Details

In response to this:

Hello team. This PR creates image pushing job for kube-scheduler-simulator.

part of kubernetes-sigs/kube-scheduler-simulator#19

staging repo was created in kubernetes/k8s.io#2681

On the repo, cloudbuild.yaml will be created in kubernetes-sigs/kube-scheduler-simulator#21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants