Support build with cloudbuild for gcr#21
Conversation
|
/kind feature |
|
image pushing job |
|
/label tide/merge-method-squash |
| # this must be specified in seconds. If omitted, defaults to 600s (10 mins) | ||
| timeout: 1200s | ||
| steps: | ||
| - name: gcr.io/cloud-builders/docker |
There was a problem hiding this comment.
Is this conventional? I noticed some repos used gcr.io/k8s-staging-test-infra/gcb-docker-gcloud.
There was a problem hiding this comment.
If your build process is driven by a Makefile or similar, you can use GCB to invoke that. We provide the gcr.io/k8s-testimages/gcb-docker-gcloud image, which contains components that are likely to be useful for your builds.
https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md#makefile-build-example
So, gcr.io/k8s-staging-test-infra/gcb-docker-gcloud image is for Makefile build, maybe...?
Because simple build example uses gcr.io/cloud-builders/docker (and I followed it.)
https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md#simple-build-example
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
part of #19
guide: https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md
For the most part, it is almost the same as the example in the guide.