Update cloud-provider-azure variable names for consistency#21917
Conversation
b31462a to
9199315
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, chewong, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@CecileRobertMichon: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Following up on kubernetes-sigs/azurefile-csi-driver#459.
cloud-provider-azure e2e uses different environment variable names than everything else (https://github.com/kubernetes-sigs/cloud-provider-azure/blob/83ec139e2224561e12e896c483b31cb08ad351a2/site/content/en/development/e2e/e2e-tests-azure.md). Updating kubetest to set the same environment variables for consistency. The new names are also slightly better syntactically IMO.
This change will have no effect on current tests. Kept the old variables for now. The plan is to update the actual vars once this is merged and then remove the old vars.
/assign @chewong @feiskyer @nilo19