Skip to content

Update cloud-provider-azure variable names for consistency#21917

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
CecileRobertMichon:cloud-provider-vars
Apr 23, 2021
Merged

Update cloud-provider-azure variable names for consistency#21917
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
CecileRobertMichon:cloud-provider-vars

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Member

Following up on kubernetes-sigs/azurefile-csi-driver#459.

cloud-provider-azure e2e uses different environment variable names than everything else (https://github.com/kubernetes-sigs/cloud-provider-azure/blob/83ec139e2224561e12e896c483b31cb08ad351a2/site/content/en/development/e2e/e2e-tests-azure.md). Updating kubetest to set the same environment variables for consistency. The new names are also slightly better syntactically IMO.

This change will have no effect on current tests. Kept the old variables for now. The plan is to update the actual vars once this is merged and then remove the old vars.

/assign @chewong @feiskyer @nilo19

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubetest sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2021
Copy link
Copy Markdown
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2021
Copy link
Copy Markdown
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2021
Copy link
Copy Markdown
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, chewong, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 211d449 into kubernetes:master Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 23, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
Details

In response to this:

Following up on kubernetes-sigs/azurefile-csi-driver#459.

cloud-provider-azure e2e uses different environment variable names than everything else (https://github.com/kubernetes-sigs/cloud-provider-azure/blob/83ec139e2224561e12e896c483b31cb08ad351a2/site/content/en/development/e2e/e2e-tests-azure.md). Updating kubetest to set the same environment variables for consistency. The new names are also slightly better syntactically IMO.

This change will have no effect on current tests. Kept the old variables for now. The plan is to update the actual vars once this is merged and then remove the old vars.

/assign @chewong @feiskyer @nilo19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/kubetest area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants