Skip to content

Rename E2E environment variables for consistency across projects#599

Merged
feiskyer merged 1 commit into
kubernetes-sigs:masterfrom
CecileRobertMichon:rename-e2e-vars
Apr 30, 2021
Merged

Rename E2E environment variables for consistency across projects#599
feiskyer merged 1 commit into
kubernetes-sigs:masterfrom
CecileRobertMichon:rename-e2e-vars

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Following up on kubernetes-sigs/azurefile-csi-driver#459.

cloud-provider-azure e2e uses different environment variable names than everything else (https://github.com/kubernetes-sigs/cloud-provider-azure/blob/83ec139e2224561e12e896c483b31cb08ad351a2/site/content/en/development/e2e/e2e-tests-azure.md). Updating kubetest to set the same environment variables for consistency. The new names are also slightly better syntactically IMO.

/hold until kubernetes/test-infra#21917 is merged

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Rename E2E environment variables for consistency across projects

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 22, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CecileRobertMichon
To complete the pull request process, please assign andyzhangx after the PR has been reviewed.
You can assign the PR to them by writing /assign @andyzhangx in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

(for testing)

/test pull-cloud-provider-azure-e2e-ccm-capz

@feiskyer
Copy link
Copy Markdown
Member

/retest

@nilo19
Copy link
Copy Markdown
Contributor

nilo19 commented Apr 23, 2021

The kubeconfig is missing

@feiskyer
Copy link
Copy Markdown
Member

while most test failures reported "No credentials provided for AAD application" (test failure is expected), the logs of capz job is very confusing as there's no error reported there. @CecileRobertMichon could you help to fix error logs of capz job?

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

@feiskyer I'm still working on the capz job, you can ignore it for now.

The other ones should be fixed once the jobs get the latest kubetest image.

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

/retest

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

/hold until kubernetes/test-infra#21920 merges

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@CecileRobertMichon: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cloud-provider-azure-e2e-ccm-capz aa5ce6b link /test pull-cloud-provider-azure-e2e-ccm-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

/hold cancel

@feiskyer this is ready. I'm working on fixing the capz test in #607.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
Copy link
Copy Markdown
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021
@feiskyer feiskyer merged commit ce2b984 into kubernetes-sigs:master Apr 30, 2021
@MartinForReal MartinForReal added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants