Rename E2E environment variables for consistency across projects#599
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
c071862 to
aa5ce6b
Compare
|
(for testing) /test pull-cloud-provider-azure-e2e-ccm-capz |
|
/retest |
|
The kubeconfig is missing |
|
while most test failures reported "No credentials provided for AAD application" (test failure is expected), the logs of capz job is very confusing as there's no error reported there. @CecileRobertMichon could you help to fix error logs of capz job? |
|
@feiskyer I'm still working on the capz job, you can ignore it for now. The other ones should be fixed once the jobs get the latest kubetest image. |
|
/retest |
1 similar comment
|
/retest |
|
/hold until kubernetes/test-infra#21920 merges |
|
/retest |
|
@CecileRobertMichon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
What this PR does / why we need it: Following up on kubernetes-sigs/azurefile-csi-driver#459.
cloud-provider-azure e2e uses different environment variable names than everything else (https://github.com/kubernetes-sigs/cloud-provider-azure/blob/83ec139e2224561e12e896c483b31cb08ad351a2/site/content/en/development/e2e/e2e-tests-azure.md). Updating kubetest to set the same environment variables for consistency. The new names are also slightly better syntactically IMO.
/hold until kubernetes/test-infra#21917 is merged
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: