Add a presubmit job for kubernetes-client/haskell

[akshaymankar]

I have never used prow before, so I am totally looking for suggestions.
It would be great if a couple of directories could be cached across builds, but I couldn't find much about how it can be done. So I would appreciate some help in that. 🙏

[k8s-ci-robot]

Welcome @akshaymankar!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @akshaymankar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chases2]

/test all

[chases2]

Thanks for including an owners file!

Please add some of these people to the review by typing

/assign @brendandburns 
or
/cc @mbohlool 

[chases2]

You may have an easier time if you put this code in a bash file in this repository, and call that script. decorate: true will pull down a repository for you.

Also, I see that this script is just calling the script at https://get.haskellstack.org/. Is that script stored in git somewhere?

[akshaymankar]

I see that some projects keep their presubmits.sh in the project repo, like repo-infra. Do you recommend we keep a script like this, or should I put a script somewhere in this (test-infra) repository? If its the later, can you please tell me where I should keep the script?

About the script at https://get.haskellstack.org/, it is in a git repository, but I guess it would be better to have stack (the build tool) in the base image for running tests.

[chases2]

A script for another repo's presubmits should be with the code it's testing, in that repository. Otherwise, you'll have a harder time maintaining those tests.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akshaymankar
To complete the pull request process, please assign chases2
You can assign the PR to them by writing /assign @chases2 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[akshaymankar]

/retest

[k8s-ci-robot]

@akshaymankar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[akshaymankar]

@chases2 @mbohlool @brendanburns Would any two of you please be sponsors of my membership of this org?

[chases2]

/ok-to-test

[chases2]

Once this is passing tests, it looks fine to me. I think you might have less flakiness if you pull a repository with the pod utilities instead of curling for the script, but that's just a hunch.

If you're looking for sponsors, you'll need more than just one. I'd recommend trying to organize that on Slack

[k8s-ci-robot]

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

• akshaymankar
  • config/jobs/kubernetes-client/haskell/OWNERS
  • config/testgrids/kubernetes/clients/OWNERS

[k8s-ci-robot]

@akshaymankar: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-test-infra-bazel	b8539f6	link	/test pull-test-infra-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[akshaymankar]

/reopen

[k8s-ci-robot]

@akshaymankar: Failed to re-open PR: state cannot be changed. The add-haskell-client branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.