-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Integration tests #61
Add Integration tests #61
Conversation
/approve cancel |
FYI, there is nothing wrong with ghc-8.0.2 . It is with a bug introduced in lts-4.7 is not on time-1.9.1 yet, so that's why we haven't seen the error in stack builds. |
224278f
to
ecff4d3
Compare
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I am sorry this got stuck in the whole conversation about travis/prow. I think we should just merge the pull request and look at the prow separately. /remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonschoning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #40
There are two tests which can also serve as exmaples:
KUBECONFIG
from environment to create a client. Then uses the client to create a namespace and a deployment in the namespace. It then verifies if the deployment exists.Other changes to travis config:
--fast
for speed and also to avoid travis timeout.stack --install-ghc query locals
withstack --system-ghc query locals
in cabal builds. This removes unnecessary installation of ghc in~/.stack
.My travis-foo isn't great, so I couldn't figure out how to add jobs and also keep the matrix, so I just added to the matrix. If someone has a better idea, please feel free to suggest :)
Click here to see the last run of the config. It is fast because most things are cached, a new PR would take much longer to run.
For all of this to be useful we should either switch on travis builds for this repository or translate this work to prow. I saw a conversation about it here: kubernetes/org#651. I looked at prow for a bit, seems like we can get much better parallelism(much needed) and also pr tooling (arguable if we need it). But we'd definitely miss the matrix feature, caching and osx builds.
Anyhoo, I think we should enable travis builds for now and consider translating separately. From the conversation linked above I understand only members of @kubernetes-client/haskell-admins can enable travis builds. So I request one of them to please do so :)