-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a presubmit job for kubernetes-client/haskell #15331
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2fd0da6
Add presubmit job for kubernetes-client/haskell
akshaymankar 639bd3a
Use .yaml instead of .yml for haskell client tests
akshaymankar ba7e34b
Specify fully qualified image name
akshaymankar 71f8776
Make haskell-client presubmits optional for now
akshaymankar 52f5c8b
Remove folks not in kubernetes org from OWNERS file
akshaymankar b8539f6
Add test grids for clients
akshaymankar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # See the OWNERS docs at https://go.k8s.io/owners | ||
|
|
||
| approvers: | ||
| - brendandburns | ||
| - mbohlool | ||
| - akshaymankar | ||
| reviewers: | ||
| - brendandburns | ||
| - mbohlool | ||
| - akshaymankar | ||
24 changes: 24 additions & 0 deletions
24
config/jobs/kubernetes-client/haskell/client-haskell-presubmits.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| presubmits: | ||
| kubernetes-client/haskell: | ||
| - name: client-haskell-unit-tests | ||
| always_run: true | ||
| decorate: true | ||
| optional: true | ||
| spec: | ||
| containers: | ||
| - image: docker.io/ubuntu:bionic | ||
| env: | ||
| command: | ||
| - bash | ||
| args: | ||
| - -c | ||
| - | | ||
| set -euo pipefail | ||
|
|
||
| apt-get update | ||
| apt-get install -y curl build-essential | ||
| curl -sSL https://get.haskellstack.org/ | sh | ||
| stack test | ||
| annotations: | ||
| testgrid-dashboards: client-haskell | ||
| testgrid-tab-name: client-haskell-presubmits |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # See the OWNERS docs at https://go.k8s.io/owners | ||
|
|
||
| approvers: | ||
| - brendandburns | ||
| - mbohlool | ||
| - akshaymankar | ||
| reviewers: | ||
| - brendandburns | ||
| - mbohlool | ||
| - akshaymankar |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| dashboard_groups: | ||
| - name: clients | ||
| dashboard_names: | ||
| - client-haskell | ||
|
|
||
| dashboards: | ||
| - name: client-haskell | ||
| dashboard_tab: | ||
| - name: client-haskell-presubmits | ||
| test_group_name: client-haskell-presubmits | ||
| base_options: include-filter-by-regex=clients | ||
| description: presubmits for haskell client |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including an owners file!
Please add some of these people to the review by typing