Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iso: add XFS_QUOTA support to guest vm #9999

Merged
merged 1 commit into from
Dec 22, 2020
Merged

iso: add XFS_QUOTA support to guest vm #9999

merged 1 commit into from
Dec 22, 2020

Conversation

amarts
Copy link
Contributor

@amarts amarts commented Dec 18, 2020

Having the Quota support for xfs would allow some of the CSI projects
to utilize the feature in their automated testing, as PV Claim requests
has volume-size as an option, which is implemented with help of quota
feature in many cases.

fixes: #9879
Signed-off-by: Amar Tumballi [email protected]

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @amarts!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @amarts. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@amarts amarts mentioned this pull request Dec 18, 2020
Closed
@amarts
iso: add XFS_QUOTA support to menuconfig options
1bd16ae 
Having the Quota support for xfs would allow some of the CSI projects
to utilize the feature in their automated testing, as PV Claim requests
has volume-size as an option, which is implemented with help of quota
feature in many cases.

Signed-off-by: Amar Tumballi <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 18, 2020
@amarts
Copy link
Contributor Author

amarts commented Dec 22, 2020

@tstromberg adding you here, as this PR is done with the references you pointed in the issue. Thanks.

medyagh
medyagh approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this @amarts it will be included in the next release. meanwhile you can build the ISO and use the --iso-url flag to use local iso

@medyagh medyagh merged commit 025991f into kubernetes:master Dec 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amarts, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISO: Enable CONFIG_XFS_QUOTA
4 participants
@amarts @k8s-ci-robot @minikube-bot @medyagh