Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Change: the PR template to not have 'fixes #issuenumber' suggestion #10000

Closed
amarts opened this issue Dec 18, 2020 · 3 comments
Closed

Comments

@amarts
Copy link
Contributor

amarts commented Dec 18, 2020

** What happened **

  1. I picked up an issue, and committed a fix, and opened a PR. (iso: add XFS_QUOTA support to guest vm #9999)
  2. While opening the PR, it recommended me to have 'Fixes: #issues number' in commit to have it reviewed faster.
  3. As a practice in other practices, I had the fixes: as part of commit message.
  4. After opening the PR, it got tagged with <invalid-commit-message>

** What is ideal **

  1. Looks like having mentions or issue numbers in commit message is not recommended now as per policy, so change the PR template file to clearly talk about it, so it would remind people again.
@Jorropo
Copy link
Contributor

Jorropo commented Dec 18, 2020

https://github.com/kubernetes/minikube/blame/master/.github/pull_request_template.md#L4

This seems pretty clear to me that it should be in the description not the title (end of line 4).
As in #9998 (I did put in the title at first by reflex) :)

@amarts
Copy link
Contributor Author

amarts commented Dec 18, 2020

@Jorropo thanks. I agree, that it says the issue number in 'description' :-)

👍

@amarts amarts closed this as completed Dec 18, 2020
@bl-ue
Copy link

bl-ue commented Dec 18, 2020

Issue 10,000! 😄😄😄 @amarts You lucked out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants