Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Enable CONFIG_XFS_QUOTA #9879

Closed
floek opened this issue Dec 8, 2020 · 1 comment · Fixed by #9999
Closed

ISO: Enable CONFIG_XFS_QUOTA #9879

floek opened this issue Dec 8, 2020 · 1 comment · Fixed by #9999
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@floek
Copy link

floek commented Dec 8, 2020

Please enable CONFIG_XFS_QUOTA in linux kernel options for the VirtualBox ISO image. This leeds to problems with the kadalu storage provider. See: kadalu/kadalu#351

Steps to reproduce the issue:

  1. Boot minikube
  2. try to mount a xfs filesystem with quota support.

Full output of failed command:
mount: /bricks/storage-pool-1/data: wrong fs type, bad option, bad superblock on /dev/loop0, missing codepage or helper program, or other error.

Full output of minikube start command used, if not already included:
😄 minikube v1.15.1 auf Darwin 11.0.1
✨ Using the virtualbox driver based on existing profile
👍 Starting control plane node minikube in cluster minikube
🔄 Restarting existing virtualbox VM for "minikube" ...
🐳 Vorbereiten von Kubernetes v1.19.4 auf Docker 19.03.13...
🔎 Verifying Kubernetes components...
🌟 Enabled addons: storage-provisioner, default-storageclass
🏄 Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 10, 2020
@tstromberg
Copy link
Contributor

tstromberg commented Dec 10, 2020 •
edited
Loading

Sounds like a great idea. If you are willing to send a PR, we'd be happy to merge it. Here's the doc around adding kernel modules:

https://minikube.sigs.k8s.io/docs/contrib/building/iso/#adding-kernel-modules

Here's an example PR: #8670

@tstromberg tstromberg added the area/guest-vm General configuration issues with the minikube guest VM label Dec 10, 2020
@tstromberg tstromberg changed the title Enable CONFIG_XFS_QUOTA in VirtualBox ISO ISO: Enable CONFIG_XFS_QUOTA Dec 10, 2020
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Dec 10, 2020
amarts added a commit to amarts/minikube that referenced this issue Dec 18, 2020
@amarts
iso: add XFS_QUOTA support to menuconfig options
109d27b 
Having the Quota support for xfs would allow some of the CSI projects
to utilize the feature in their automated testing, as PV Claim requests
has volume-size as an option, which is implemented with help of quota
feature in many cases.

Fixes: kubernetes#9879
Signed-off-by: Amar Tumballi <[email protected]>
@amarts amarts mentioned this issue Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iso: add XFS_QUOTA support to guest vm amarts/minikube
2 participants
@tstromberg @floek