-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "parallels" driver library and make this driver built into minikube #9517
Conversation
Hi @legal90. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/assign @tstromberg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing it, I have no way of testing this myself but I trust you have tested this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind putting the PR description the before and after this PR output ?
Codecov Report
@@ Coverage Diff @@
## master #9517 +/- ##
==========================================
+ Coverage 29.05% 29.11% +0.06%
==========================================
Files 171 172 +1
Lines 10446 10461 +15
==========================================
+ Hits 3035 3046 +11
- Misses 6988 6990 +2
- Partials 423 425 +2
|
@medyagh Thanks you! Yes, I can add more details and provide "before" and "after" behavior later today. But since you've merged #9494 I will also need to rebase this PR. Could you please tell me how do you want
|
I personally think that doing so built-in creates a better user experience, rather than forcing users to download a separate helper binary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my perspective.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: legal90, medyagh, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 70f4bc7.
It contains the fix for macOS 11
bb25d9a
to
067ead1
Compare
@tstromberg @medyagh I rebased the branch, updated the PR title and description. The idea is still the same - this PR makes |
Thank you! |
Changes:
Fixes Parallels driver is getting called as a built-in library instead of RPC Server #9493 . As we can see from
go.mod
, minikube is already shipped with parallels driver built-in. The requirement of havingdocker-machine-driver-parallels
binary available on the user's host is not needed, since it's not actually used by minikube.Reverts Remove Init function from the parallels driver definition #9494 because it's the opposite (alternative) way of fixing the same issue.
Fixes parallels: Your Mac host is not connected to Shared network. #9357. The updated dependency
github.com/Parallels/docker-machine-parallels/v2 v2.0.1
includes the fix for macOS 11 BigSur. Ref: Improve the check if Shared network adapter is connected Parallels/docker-machine-parallels#96Before this PR:
Make sure the
docker-machine-driver-parallels
is not available:Then minikube requires user to install it:
After this PR:
Now the driver is built-in, so no additional action is required form user (as long as Parallels Desktop for Mac is installed and license is activated)
cc @sharifelgamal , @afbjorklund , @tstromberg