-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Init function from the parallels driver definition #9494
Conversation
That's needed for minikube to stop treating "parallels" as a built-in driver and use RPC calls for calling its functionality
Hi @legal90. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #9494 +/- ##
=======================================
Coverage 29.05% 29.05%
=======================================
Files 171 171
Lines 10443 10443
=======================================
Hits 3034 3034
Misses 6987 6987
Partials 422 422 |
This patch is based on the following logic: minikube/pkg/minikube/machine/client.go Lines 92 to 94 in 97d96bf
But I'm a bit confused by the name |
I think this latter approach is going to be the better one. Feel free to open that PR and I'll review it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: legal90, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #9493
That's needed for
minikube
to stop treatingparallels
as a built-in driver and use RPC calls for calling its functionality.