Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Init function from the parallels driver definition #9494

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Oct 19, 2020

Fixes #9493

That's needed for minikube to stop treating parallels as a built-in driver and use RPC calls for calling its functionality.

That's needed for minikube to stop treating "parallels" as a built-in driver and use RPC calls for calling its functionality
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @legal90. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #9494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9494   +/-   ##
=======================================
  Coverage   29.05%   29.05%           
=======================================
  Files         171      171           
  Lines       10443    10443           
=======================================
  Hits         3034     3034           
  Misses       6987     6987           
  Partials      422      422           

@legal90
Copy link
Contributor Author

legal90 commented Oct 19, 2020

This patch is based on the following logic:

if def.Init == nil {
return api.legacyClient.NewHost(drvName, rawDriver)
}

But I'm a bit confused by the name legacyClient there. So please let me know if you want to keep drivers built-in instead of actually calling them via RPC.
In this case I will submit another PR - with the dependency version bump + the removal of checking the docker-machine-driver-parallels path, as it won't be used anymore.

@sharifelgamal
Copy link
Collaborator

This patch is based on the following logic:

if def.Init == nil {
return api.legacyClient.NewHost(drvName, rawDriver)
}

But I'm a bit confused by the name legacyClient there. So please let me know if you want to keep drivers built-in instead of actually calling them via RPC.
In this case I will submit another PR - with the dependency version bump + the removal of checking the docker-machine-driver-parallels path, as it won't be used anymore.

I think this latter approach is going to be the better one. Feel free to open that PR and I'll review it.

@medyagh medyagh merged commit 103c98e into kubernetes:master Oct 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: legal90, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@legal90 legal90 deleted the fix-parallels-rpc branch October 22, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallels driver is getting called as a built-in library instead of RPC Server
6 participants