Skip to content

Commit

Permalink
Do not require "parallels" driver binary since it's built-in to minikube
Browse files Browse the repository at this point in the history
  • Loading branch information
legal90 committed Oct 21, 2020
1 parent 0758a7f commit bb25d9a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 22 deletions.
6 changes: 3 additions & 3 deletions pkg/minikube/registry/drvs/parallels/parallels.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ func configure(cfg config.ClusterConfig, n config.Node) (interface{}, error) {
}

func status() registry.State {
_, err := exec.LookPath("docker-machine-driver-parallels")
_, err := exec.LookPath("prlctl")
if err != nil {
return registry.State{Error: err, Fix: "Install docker-machine-driver-parallels", Doc: "https://minikube.sigs.k8s.io/docs/reference/drivers/parallels/"}
return registry.State{Error: err, Fix: "Install Parallels Desktop for Mac", Doc: "https://minikube.sigs.k8s.io/docs/drivers/parallels/"}
}
return registry.State{Installed: true, Healthy: true, Running: true}
return registry.State{Installed: true, Healthy: true}
}
18 changes: 0 additions & 18 deletions site/content/en/docs/drivers/includes/parallels_usage.inc
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,6 @@

* Parallels Desktop 11.0.0+ Pro or Business edition

## Driver Installation

If the [Brew Package Manager](https://brew.sh/) is installed, run:

```shell
brew install docker-machine-parallels
```

Otherwise:

```shell
latest=$(curl -s https://api.github.com/repos/Parallels/docker-machine-parallels/releases/latest \
| grep -o 'http.*docker-machine-driver-parallels' | head -n1)
curl -LO $latest
install docker-machine-driver-parallels /usr/local/bin/
```


## Usage

Start a cluster using the parallels driver:
Expand Down
2 changes: 1 addition & 1 deletion site/content/en/docs/drivers/parallels.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ aliases:

## Overview

The Parallels driver is particularly useful for users who own Parallels Desktop, as it does not require VT-x hardware support.
The Parallels driver is particularly useful for users who own Parallels Desktop for Mac, as it does not require VT-x hardware support.

{{% readfile file="/docs/drivers/includes/parallels_usage.inc" %}}

Expand Down

0 comments on commit bb25d9a

Please sign in to comment.