Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

none: check for docker and root uid #7388

Merged
merged 2 commits into from
Apr 2, 2020
Merged

none: check for docker and root uid #7388

merged 2 commits into from
Apr 2, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Apr 2, 2020 •
edited
Loading

Fixes #7107 #7166

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 2, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 65.365384 64.389507 62.921975]
All Times Minikube (PR 7388): [ 64.551522 63.580670 63.758232]

Average minikube: 64.225622
Average Minikube (PR 7388): 63.963475

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7388) |
+----------------------+-----------+--------------------+
| minikube v           |  0.221374 |           0.219087 |
| Creating kvm2        | 41.160202 |          40.945825 |
| Preparing Kubernetes | 20.844850 |          20.784707 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

All Times minikube: [ 63.534786 60.445283 62.006516]
All Times Minikube (PR 7388): [ 62.643400 64.645777 65.518895]

Average minikube: 61.995528
Average Minikube (PR 7388): 64.269357

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7388) |
+----------------------+-----------+--------------------+
| minikube v           |  0.218635 |           0.222026 |
| Creating kvm2        | 39.949526 |          41.887735 |
| Preparing Kubernetes | 20.166803 |          20.674070 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit a305b65 into kubernetes:master Apr 2, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
@prasadkatti prasadkatti mentioned this pull request Apr 4, 2020
Closed
@afbjorklund afbjorklund mentioned this pull request Apr 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

none as non-root: Unable to load config: stat: stat config.json: permission denied
4 participants
@tstromberg @k8s-ci-robot @minikube-pr-bot @medyagh