wip: Improved message when docker is not installed for none

[zerefwayne]

fixes #7166

before:

medya@none-experiment-instance-1-medya:~$ sudo minikube start --vm-driver=none
😄  minikube v1.8.2 on Ubuntu 18.04
✨  Using the none driver based on user configuration
🤹  Running on localhost (CPUs=2, Memory=7470MB, Disk=9749MB) ...
💣  Unable to start VM. Please investigate and run 'minikube delete' if possible: creating host: create: precreate:
 exec: "docker": executable file not found in $PATH
😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

after:

$ sudo ./out/minikube start --driver=none
😄  minikube v1.9.0 on Ubuntu 18.04
✨  Using the none driver based on existing profile
👍  Starting control plane node  in cluster minikube
🤹  Running on localhost (CPUs=8, Memory=15803MB, Disk=149202MB) ...
🤦  StartHost failed, but will try again: creating host: create: precreate: docker not found in $PATH. please install docker or try adding it to the $PATH
🤹  Running on localhost (CPUs=8, Memory=15803MB, Disk=149202MB) ...
❌  StartHost failed again: creating host: create: precreate: docker not found in $PATH. please install docker or try adding it to the $PATH
👉  Run: "minikube delete", then "minikube start --alsologtostderr -v=1" to try again with more logging
💣  Failed to start none bare metal machine. "minikube start" may fix it.: creating host: create: precreate: docker not found in $PATH. please install docker or try adding it to the $PATH
😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

This pull request changes the error message from exec: "docker": executable file not found in $PATH to docker not found in $PATH. please install docker or try adding it to the $PATH

[k8s-ci-robot]

Welcome @zerefwayne!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @zerefwayne. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zerefwayne
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zerefwayne]

/assign @priyawadhwa

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

this is not the right place to add a solution message

[zerefwayne]

Can you suggest where should I put this message?

As you said the open an issue shouldn't appear, I'll change the log function from error -> withMessage.

[medyagh]

zerefwayne the purpose was of the issue was not to show the failure to create an issue

🤹  Running on localhost (CPUs=8, Memory=15803MB, Disk=149202MB) ...
❌  StartHost failed again: creating host: create: precreate: docker not found in $PATH. please install docker or try adding it to the $PATH
👉  Run: "minikube delete", then "minikube start --alsologtostderr -v=1" to try again with more logging
💣  Failed to start none bare metal machine. "minikube start" may fix it.: creating host: create: precreate: docker not found in $PATH. please install docker or try adding it to the $PATH
😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

we dont want to direct ppl to create an issue, when we know what the problem is,

this PR instead should check the error if docker is not installed, should exit with a message

[priyawadhwa]

Hey @zerefwayne thanks for opening this PR. You can check if docker is installed in the precreate check for the none driver:

https://github.com/kubernetes/minikube/blob/master/pkg/drivers/none/none.go#L82

if you can't find the docker executable, output something like this:

		out.T(out.FailureType, `Unable to find docker executable on PATH, please make sure it is correctly installed: {{.error}}`, out.V{"error": err})

[afbjorklund]

Alternative implementation in #7388

✨  Using the docker driver based on user configuration

❗  'docker' driver reported an issue: exec: "docker": executable file not found in $PATH
💡  Suggestion: Docker is required.
📘  Documentation: https://minikube.sigs.k8s.io/docs/reference/drivers/docker/

💣  docker does not appear to be installed