Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve message when docker is not installed for none #7166

Closed
medyagh opened this issue Mar 23, 2020 · 7 comments
Closed

improve message when docker is not installed for none #7166

medyagh opened this issue Mar 23, 2020 · 7 comments
Assignees
@zerefwayne
Labels
co/none-driver co/runtime/docker Issues specific to a docker runtime good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 23, 2020 •
edited
Loading

when docker is not installed for none, instead of crashing, we could tell user nicely, please install docker

medya@none-experiment-instance-1-medya:~$ sudo minikube start --vm-driver=none
😄  minikube v1.8.2 on Ubuntu 18.04
✨  Using the none driver based on user configuration
🤹  Running on localhost (CPUs=2, Memory=7470MB, Disk=9749MB) ...
💣  Unable to start VM. Please investigate and run 'minikube delete' if possible: creating host: create: precreate:
 exec: "docker": executable file not found in $PATH
😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose
@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. needs-solution-message Issues where where offering a solution for an error would be helpful priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 23, 2020
@afbjorklund
Copy link
Collaborator

I still think that this one is worse: #5549

@afbjorklund afbjorklund added co/none-driver co/runtime/docker Issues specific to a docker runtime labels Mar 23, 2020
@afbjorklund
Copy link
Collaborator

Possibly related to #6402

@priyawadhwa priyawadhwa added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 25, 2020
@zerefwayne
Copy link

@priyawadhwa @afbjorklund I think I can work on this one.

@priyawadhwa
Copy link

@zacharysarah great, I'll assign you to the issue. Let me know if you have any questions.

@zerefwayne
Copy link

zerefwayne commented Apr 1, 2020 •
edited
Loading

@priyawadhwa @medyagh

  1. How do I reproduce the error as I have docker installed on Ubuntu 18.04? Is there any alternative to completely removing docker to solve this problem? Resolved 👍
  2. I couldn't find the exact location in code from where the error message is being generated even after using grep. Resolved 👍

@afbjorklund
Copy link
Collaborator

afbjorklund commented Apr 1, 2020 •
edited
Loading

@zerefwayne : you can just rename it temporarily, and move it back again when done

sudo mv /usr/bin/docker /usr/bin/docker.orig

@zerefwayne zerefwayne mentioned this issue Apr 1, 2020
Closed
@tstromberg tstromberg removed the needs-solution-message Issues where where offering a solution for an error would be helpful label Apr 2, 2020
@tstromberg tstromberg mentioned this issue Apr 2, 2020
Merged
@prasadkatti
Copy link
Contributor

this issue should be closed since it is fixed by #7388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerefwayne zerefwayne

Labels
co/none-driver co/runtime/docker Issues specific to a docker runtime good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wip: Improved message when docker is not installed for none
6 participants
@tstromberg @medyagh @prasadkatti @afbjorklund @priyawadhwa @zerefwayne