-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provisioner: only reload docker if necessary, don't install curl #7115
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7115 +/- ##
==========================================
- Coverage 37.19% 37.14% -0.05%
==========================================
Files 146 146
Lines 9106 9118 +12
==========================================
Hits 3387 3387
- Misses 5303 5315 +12
Partials 416 416
|
/ok-to-test |
Error: running mkcmp: exit status 1 |
The "curl" package is being installed, because the default install command is func installDockerGeneric(p Provisioner, baseURL string) error {
// install docker - until cloudinit we use ubuntu everywhere so we
// just install it using the docker repos
if output, err := p.SSHCommand(fmt.Sprintf("if ! type docker; then curl -sSL %s | sh -; fi", baseURL)); err != nil {
return fmt.Errorf("error installing docker: %s", output)
}
return nil
} However, the |
This modernizes the provisioner in three important ways:
NewSystemdProvisioner
to avoid unnecessaryapt-get
commands to install curl.glog
for consistency with rest of minikube codebaseThis PR improves "minikube start" performance on an already running cluster by a second or so.