-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip kubeadm if cluster is running & properly configured #7124
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7124 +/- ##
==========================================
- Coverage 36.96% 36.95% -0.01%
==========================================
Files 145 145
Lines 9165 9167 +2
==========================================
Hits 3388 3388
- Misses 5359 5361 +2
Partials 418 418
|
/ok-to-test |
All Times Minikube (PR 7124): [ 66.037811 66.203720 64.962396] Average minikube: 65.085793 Averages Time Per Log
|
All Times Minikube (PR 7124): [ 68.036779 67.438663 64.682441] Average minikube: 65.055623 Averages Time Per Log
|
In combination with #7115 - this speeds up "minikube start" on a running cluster so that it only takes ~3 seconds.
This should also improve reliability when "minikube start" is run on a running cluster, as it has less work to do.