Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip kubeadm if cluster is running & properly configured #7124

Merged
merged 3 commits into from
Mar 21, 2020

Conversation

tstromberg
Copy link
Contributor

In combination with #7115 - this speeds up "minikube start" on a running cluster so that it only takes ~3 seconds.

This should also improve reliability when "minikube start" is run on a running cluster, as it has less work to do.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #7124 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7124      +/-   ##
==========================================
- Coverage   36.96%   36.95%   -0.01%     
==========================================
  Files         145      145              
  Lines        9165     9167       +2     
==========================================
  Hits         3388     3388              
- Misses       5359     5361       +2     
  Partials      418      418              
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/bsutil/binaries.go 5.12% <0.00%> (-0.28%) ⬇️
pkg/minikube/bootstrapper/bsutil/files.go 0.00% <0.00%> (ø)

@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 20, 2020
@minikube-pr-bot
Copy link

All Times Minikube (PR 7124): [ 66.037811 66.203720 64.962396]
All Times minikube: [ 68.052642 63.957943 63.246795]

Average minikube: 65.085793
Average Minikube (PR 7124): 65.734642

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7124) |
+----------------------+-----------+--------------------+
| minikube v           |  0.218078 |           0.219074 |
| Creating kvm2        | 41.835136 |          41.357480 |
| Preparing Kubernetes |  1.012549 |           0.767338 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.080977 |          21.150909 |
| Waiting for cluster  |  0.230517 |           0.566989 |
+----------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

All Times Minikube (PR 7124): [ 68.036779 67.438663 64.682441]
All Times minikube: [ 64.861405 66.250171 64.055292]

Average minikube: 65.055623
Average Minikube (PR 7124): 66.719294

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7124) |
+----------------------+-----------+--------------------+
| minikube v           |  0.222339 |           0.209298 |
| Creating kvm2        | 41.095940 |          43.238951 |
| Preparing Kubernetes | 21.652971 |          21.236913 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |  0.410265 |                    |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 5a5f869 into kubernetes:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants