Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: excessive systemctl reload/restarts #7103

Closed
tstromberg opened this issue Mar 18, 2020 · 1 comment · Fixed by #7115
Closed

docker: excessive systemctl reload/restarts #7103

tstromberg opened this issue Mar 18, 2020 · 1 comment · Fixed by #7115
Assignees
Labels
area/performance Performance related issues co/docker-driver Issues related to kubernetes in container kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@tstromberg
Copy link
Contributor

tstromberg commented Mar 18, 2020

I noticed this while running minikube start on a running instance:

I0318 13:50:11.255632   48225 main.go:110] libmachine: About to run SSH command:
sudo systemctl -f daemon-reload 
I0318 13:50:11.533986   48225 main.go:110] libmachine: About to run SSH command:
sudo systemctl -f enable docker
I0318 13:50:11.794742   48225 main.go:110] libmachine: About to run SSH command:
sudo systemctl daemon-reload
I0318 13:50:12.073229   48225 main.go:110] libmachine: About to run SSH command:
sudo systemctl -f restart docker

This should be sufficient, though possibly not needed either:

sudo systemctl -f daemon-reload && sudo systemctl -f restart docker

@tstromberg tstromberg added area/performance Performance related issues co/docker-driver Issues related to kubernetes in container priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 18, 2020
@tstromberg tstromberg changed the title docker: excessive docker reload/restarts docker: excessive systemctl reload/restarts Mar 18, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 18, 2020

This is normal libmachine provisioner behaviour. It does a daemon-reload before all start/restart operations.

	// systemd needs reloaded when config changes on disk; we cannot
	// be sure exactly when it changes from the provisioner so
	// we call a reload on every restart to be safe

The first one we did on purpose, I think.

        // because in kic base image we pre-install docker it already has a service file. we need to daemon-reload for the new systemd file

@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2020
@tstromberg tstromberg self-assigned this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance related issues co/docker-driver Issues related to kubernetes in container kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants