-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the crio.conf instead of overwriting it #6219
Conversation
For some reason it was left with the generic CRI
We are only changing one config value, anyway
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6219 +/- ##
==========================================
+ Coverage 38.23% 38.34% +0.11%
==========================================
Files 123 124 +1
Lines 8262 8363 +101
==========================================
+ Hits 3159 3207 +48
- Misses 4694 4736 +42
- Partials 409 420 +11
|
/ok-to-test |
All Times minikube: [ 124.638582 128.181906 123.734581] Average minikube: 125.518356 Averages Time Per Log
|
cb8e516
to
c017dc9
Compare
All Times minikube: [ 123.107335 110.087499 122.794099] Average Minikube (PR 6219): 125.237186 Averages Time Per Log
|
All Times Minikube (PR 6219): [ 130.280601 131.379232 133.523626] Average minikube: 234.179668 Averages Time Per Log
|
/ok-to-test |
Fixes #5677