Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI-O config (/etc/crio/crio.conf) should not be hardcoded (nor overwritten without a prompt) #6009

Closed
intelfx opened this issue Dec 3, 2019 · 3 comments
Assignees
Labels
co/none-driver co/runtime/crio CRIO related issues kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@intelfx
Copy link

intelfx commented Dec 3, 2019

With minikube start --vm-driver=none --container-runtime=crio, minikube attempts to overwrite any pre-existing CRI-O configuration at /etc/crio/crio.conf with a hardcoded template.

First, this has a potential for user data loss (if the user has a nontrivial configuration in place).

Second, this makes minikube/crio unusable on any systems that do not adhere to the hardcoded paths (e. g. Arch Linux, which has /usr/bin/conmon and /usr/lib/cni instead of /usr/libexec/crio/conmon and /opt/cni/bin).

Finally, this makes it impossible to use any container runtime other than crun (which is often the motivation to use CRI-O in the first place).

@afbjorklund
Copy link
Collaborator

This is related to #5677 (about the template). Data loss is to be expected when using the "none" driver, but there is also compatibility issues with different crio versions and the afforementioned paths.

@afbjorklund afbjorklund added co/runtime/crio CRIO related issues co/none-driver priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 3, 2019
@afbjorklund
Copy link
Collaborator

This already overwrites the configuration from the ISO as well, so the crio.conf in the Buildroot package is not what ends up being used... To make matters worse, crio.conf is in "cri.go" and not in "crio.go".

@afbjorklund afbjorklund added this to the v1.7.0-candidate milestone Dec 3, 2019
@tstromberg tstromberg removed this from the v1.7.0-candidate milestone Dec 9, 2019
@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Dec 19, 2019
@afbjorklund afbjorklund self-assigned this Jan 6, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Jan 6, 2020

Removed the hard-coded configuration, now only updating the pause_image.

See #6219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/none-driver co/runtime/crio CRIO related issues kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants